View Issue Details

IDProjectCategoryView StatusLast Update
15920Bug reports[All Projects] Survey takingpublic2020-03-02 11:59
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version3.22.7 
Target VersionFixed in Version 
Summary15920: PHP notice when submlt a survey
Description

When submit a survey with refurl at 1 : receive a PHP Notice with debug = 2

Steps To Reproduce

Import included survey
Set debug = 2
Activate survey
Launch and submit survey

Additional Information

`$this->LEMsessid``seems empty, copy paster from EM ?

TagsNo tags attached.
Complete LimeSurvey version number (& build)3.22.7 github
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database & DB-Versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Activities

DenisChenu

DenisChenu

2020-02-26 19:20

developer  

limesurvey_survey_urlNottice.lss (14,880 bytes)
PHP notice.html (19,688 bytes)
DenisChenu

DenisChenu

2020-02-26 19:29

developer   ~56211

$this->setArgs(); is done before $this->LEMsessid = 'survey_'.$this->iSurveyid;

My opinion : $this->LEMsessid = 'survey_'.$this->iSurveyid; must be moved in setVarFromArgs

DenisChenu

DenisChenu

2020-02-27 08:25

developer   ~56215

Looking at code : 4.X have same issue

DenisChenu

DenisChenu

2020-02-27 08:25

developer   ~56216

@cdorin, @ollehaer

I have the fix : OK to fix in 3.X ? broke survey submit but only with debug set to 2.

DenisChenu

DenisChenu

2020-02-27 08:39

developer   ~56217

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29623

lime_release_bot

lime_release_bot

2020-03-02 11:59

administrator   ~56270

Fixed in Release 4.1.8+200302

Related Changesets

LimeSurvey: master 10454b9f

2020-02-27 08:38:53

DenisChenu

Details Diff
Fixed issue 15920: PHP notice when submit a survey with refurl
Dev: move $this->LEMsessid to setVarFromArgs function
Dev: send surveyid from the param in setVarFromArgs
Affected Issues
15920
mod - application/helpers/SurveyRuntimeHelper.php Diff File

Issue History

Date Modified Username Field Change
2020-02-26 19:20 DenisChenu New Issue
2020-02-26 19:20 DenisChenu File Added: limesurvey_survey_urlNottice.lss
2020-02-26 19:20 DenisChenu File Added: PHP notice.html
2020-02-26 19:29 DenisChenu Note Added: 56211
2020-02-27 08:25 DenisChenu Note Added: 56215
2020-02-27 08:25 DenisChenu Note Added: 56216
2020-02-27 08:37 DenisChenu Assigned To => DenisChenu
2020-02-27 08:37 DenisChenu Status new => assigned
2020-02-27 08:39 DenisChenu Changeset attached => LimeSurvey master 10454b9f
2020-02-27 08:39 DenisChenu Note Added: 56217
2020-02-27 08:39 DenisChenu Resolution open => fixed
2020-03-02 11:59 lime_release_bot Note Added: 56270
2020-03-02 11:59 lime_release_bot Status assigned => closed