View Issue Details

IDProjectCategoryView StatusLast Update
15890Bug reportsTheme editorpublic2020-07-03 11:02
ReporterMazi Assigned To 
PrioritynormalSeverityminor 
Status resolvedResolutionopen 
Product Version3.22.5 
Summary15890: Overview of un-installed themes shows incorrectly parsed theme description
Description

When uninstalling some default themes at a fresh 3.22.5 Limesurvey, the theme description is not parsed correctly, see screenshot.

Steps To Reproduce

Uninstall a few of the shipped themes and have a look at the list at the bottom of the theme list afterwards.

TagsNo tags attached.
Complete LimeSurvey version number (& build)Version 3.22.5
I will donate to the project if issue is resolvedNo
BrowserChrome
Database & DB-VersionMySQL 5
Server OS (if known)Ubuntu 18
Webserver software & version (if known)Apache 2
PHP Version7.2.26

Activities

Mazi

Mazi

2020-02-18 14:44

partner  

theme_overview.png (24,298 bytes)   
theme_overview.png (24,298 bytes)   
cdorin

cdorin

2020-02-21 00:22

manager   ~56123

Seems to have the issue only with the shipped themes. Thanks!

Mazi

Mazi

2020-02-21 11:08

partner   ~56134

Last edited: 2020-07-03 11:02

@cdorin, same issue at LS 4, see screenshot.

image.png (23,463 bytes)   
image.png (23,463 bytes)   
gabrieljenik

gabrieljenik

2020-06-29 22:23

partner   ~58566

Last edited: 2020-07-03 11:02

Is this allowed on config.xml? I don;t think so, right?

image-2.png (12,484 bytes)   
image-2.png (12,484 bytes)   
gabrieljenik

gabrieljenik

2020-07-02 00:17

partner   ~58624

Last edited: 2020-07-03 11:02

View 2 revisions

For uninstalled themes, the description was taken directly from the config metadata directly. No parsing done.

Added templateManifest::getDescription() method for parsing descriptions on XML file.
This is now used on the view.

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1464

sushmanadendla

sushmanadendla

2020-07-02 14:17

manager   ~58647

Last edited: 2020-07-03 11:02

Tested the issue by pulling the PR. The description of uninstalled themes is properly displayed.
Please refer the screenshot for more details

guest

guest

2020-07-03 10:59

viewer   ~58674

Last edited: 2020-07-03 11:02

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30247

Related Changesets

LimeSurvey: 3.x-LTS b5e43ff8

2020-07-03 10:59:21

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 15890: Overview of uninstalled themes shows incorrectly parsed theme description (#1464)

Dev: New templateManifest::getDescription() method for parsing descriptions on XML file. This is now used on the view.
Affected Issues
15890
mod - application/models/TemplateManifest.php Diff File
mod - application/views/admin/themeoptions/index.php Diff File

Issue History

Date Modified Username Field Change
2020-02-18 14:44 Mazi New Issue
2020-02-18 14:44 Mazi File Added: theme_overview.png
2020-02-21 00:22 cdorin Note Added: 56123
2020-02-21 00:22 cdorin Priority none => normal
2020-02-21 00:22 cdorin Status new => confirmed
2020-02-21 11:08 Mazi File Added: image.png
2020-02-21 11:08 Mazi Note Added: 56134
2020-06-29 22:23 gabrieljenik Note Added: 58566
2020-06-29 22:23 gabrieljenik File Added: image-2.png
2020-07-02 00:17 gabrieljenik Note Added: 58624
2020-07-02 00:22 gabrieljenik Note Edited: 58624 View Revisions
2020-07-02 14:17 sushmanadendla Note Added: 58647
2020-07-02 14:17 sushmanadendla File Added: 15890_Uninstalledthemes_parseddesription.png
2020-07-03 10:59 gabrieljenik Changeset attached => LimeSurvey 3.x-LTS b5e43ff8
2020-07-03 10:59 guest Note Added: 58674
2020-07-03 11:02 swendrich Status confirmed => resolved