 |
cdorin told me in IRC i should add him here, so this is my attempt @cdorin |
 |
@jonasdoerken : about config.xml files : it's to avoid to broke instance in such situation. Move for 3.X to 4. X : yes we upadte API numbre, then previous method didn'tb work. \QUestion::model are not inside API https://github.com/LimeSurvey/LimeSurvey/blob/master/application/libraries/PluginManager/LimesurveyApi.php Maybe you can create a `LimesurveyApi->getQuestion(…)` but it can not be in 3.12.1 for example … |
|
|
|
|
|
Hello Denis, thank you very much for your answer. If i understand you correctly, there is already a function at the LimsurveyAPI called getQuestions, which is working fine if i comment out the conditions line regarding the language. I attached you the function in the limesurveyAPI i'm talking about. In your Github link its the line https://github.com/LimeSurvey/LimeSurvey/blob/71898e9d27fbfe439ecd685cdf100f4d2118e908/application/libraries/PluginManager/LimesurveyApi.php#L400 Thank you very much for your time! |
|
|
> If i understand you correctly, there is already a function at the LimsurveyAPI called getQuestions, I never write or say that. Question are not in Plugin Api … then : you must rewriter your plugin using the same method than LimeSurvey. Please : better read > **Maybe you can create** a |
|
|
Hello, Denis, I think we're getting off on the wrong foot. I expressed myself wrong. The getQuestions function is already in the API, I linked it to you. But since the upgrade it doesn't work anymore because the column language is missing in the question table. Once again in short: getQuestions worked with 3.*, but does not work with 4.* anymore. So the Model Question is available in the API as return value. Sorry for the misunderstanding caused by my formulation. Of course I can't use the API in my plugin anymore and directly access the models, but that's what it's there for, isn't it? https://github.com/LimeSurvey/LimeSurvey/blob/71898e9d27fbfe439ecd685cdf100f4d2118e908/application/libraries/PluginManager/LimesurveyApi.php#L400 |
|
|
Arg, yes … sorry … You did good … bug in LimeSurvey LimesurveyApi.php file must be updated … Can you make a pull request ? Seems need `with('questionL10ns')` |
|
|
Yes i can, thank you for your time! |
 |
Please test on branch bug/15793-plugin-api-breaks. Also test with postgres. |
|
|
Direct link is so cooooooooooooooooooooooooooooooooooooooooool https://github.com/LimeSurvey/LimeSurvey/tree/bug/15793-plugin-api-breaks |
- Anonymous
