View Issue Details

IDProjectCategoryView StatusLast Update
15297Bug reportsSurvey editingpublic2019-09-18 15:10
Reporterollehar Assigned To 
PrioritynoneSeverityminor 
Status newResolutionopen 
Product Version4.0.0-RC3 
Target Version4.0.0-RC4 
Summary15297: Misc issues with question themes
Description
  • Folder name should be name + type from config, not name of zip file
  • Unique constraint name + type should be in db too (not only AR rules)
  • Proper OOP with survey themes, question themes, in controller (ThemeOptionsInterface?) instead of if-statements
  • Discuss proper indentation of PHP files
  • When using json_encode, always check json_last_error for errors
  • <type> in question theme config conflicts with <type> in limestore config: https://manual.limesurvey.org/LimeStore_extension_development
  • It would be good if reading XML from file was only used in ONE place in the code, to reduce the risk of forgetting libxml_disable_entity_loader
  • When uploading theme, don't branch on $_POST, but on config.xml <type> tag
  • Move all core question themes to one folder (now split between views/ and themes/)
TagsNo tags attached.
Complete LimeSurvey version number (& build)latest
I will donate to the project if issue is resolvedNo
Browser-
Database & DB-Version-
Server OS (if known)-
Webserver software & version (if known)-
PHP Version-

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2019-09-17 14:43 ollehar New Issue
2019-09-17 14:44 ollehar Description Updated View Revisions
2019-09-17 14:47 ollehar Description Updated View Revisions
2019-09-18 10:22 ollehar Description Updated View Revisions
2019-09-18 10:23 ollehar Description Updated View Revisions
2019-09-18 10:24 ollehar Description Updated View Revisions
2019-09-18 13:44 ollehar Description Updated View Revisions
2019-09-18 15:10 ollehar Description Updated View Revisions
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing