| Description |
- Folder name should be name + type from config, not name of zip file
- Unique constraint name + type should be in db too (not only AR rules)
- Proper OOP with survey themes, question themes, in controller (ThemeOptionsInterface?) instead of if-statements
- Discuss proper indentation of PHP files
- When using json_encode, always check json_last_error for errors
- <type> in question theme config conflicts with <type> in limestore config: https://manual.limesurvey.org/LimeStore_extension_development
- It would be good if reading XML from file was only used in ONE place in the code, to reduce the risk of forgetting libxml_disable_entity_loader
- When uploading theme, don't branch on $_POST, but on config.xml <type> tag
- Move all core question themes to one folder (now split between views/ and themes/)
|
|---|
