|
|
Before Capture d’écran du 2019-05-09 15-31-56.png i have ngynx 504 issue |
|
dominikvitt
2019-05-09 16:51
developer
~51857
|
I'm having PHP warning: Creating default object from empty value
I'll try to fix it.
PHP warning.html (5,028 bytes)
<script type="text/javascript" src="/assets/packages/bootstrap/plugins/switch/js/bootstrap-switch.js"></script>
<script type="text/javascript" src="/assets/packages/bootstrap/plugins/datetimepicker/build/js/bootstrap-datetimepicker.min.js"></script>
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" type="text/css" href="/third_party/jquery-ui/jquery-ui.structure.css" />
<link rel="stylesheet" type="text/css" href="/assets/fonts/font-src/fontawesome/css/font-awesome.css" />
<link rel="stylesheet" type="text/css" href="/assets/packages/bootstrap/bootstrap.css" />
<link rel="stylesheet" type="text/css" href="/assets/packages/bootstrap/yiistrap.css" />
<link rel="stylesheet" type="text/css" href="/assets/packages/bootstrap/plugins/switch/css/bootstrap-switch.css" />
<link rel="stylesheet" type="text/css" href="/assets/packages/bootstrap/plugins/select2/css/select2.css" />
<link rel="stylesheet" type="text/css" href="/assets/packages/bootstrap/plugins/select2/css/select2-bootstrap.css" />
<link rel="stylesheet" type="text/css" href="/assets/packages/bootstrap/plugins/datetimepicker/build/css/bootstrap-datetimepicker.css" />
<link rel="stylesheet" type="text/css" href="/assets/fonts/roboto.css" />
<link rel="stylesheet" type="text/css" href="/assets/fonts/icomoon.css" />
<link rel="stylesheet" type="text/css" href="/assets/packages/adminbasics/build/adminbasics.css" />
<link rel="stylesheet" type="text/css" href="/assets/packages/adminsidepanel/build.min/css/main.css" />
<link rel="stylesheet" type="text/css" href="/assets/packages/lstutorial/build/lstutorial.css" />
<link rel="stylesheet" type="text/css" href="/themes/admin/Sea_Green/css/lime-admin-colors.css" />
<link rel="stylesheet" type="text/css" href="/themes/admin/Sea_Green/css/statistics.css" />
<script type='text/javascript'>window.debugState = {frontend : (0 === 1), backend : (0 === 1)};</script><script type="text/javascript" src="/third_party/jquery/jquery-3.1.1.js" class="headScriptTag"></script>
<script type="text/javascript" src="/third_party/jquery/jquery-migrate-3.0.0.js" class="headScriptTag"></script>
<script type="text/javascript" src="/third_party/jquery-ui/jquery-ui.js" class="headScriptTag"></script>
<script type="text/javascript" src="/assets/packages/adminbasics/build/adminbasics.js" class="headScriptTag"></script>
<script type="text/javascript" src="/assets/packages/adminsidepanel/build/js/adminsidepanel.js" class="headScriptTag"></script>
<script type="text/javascript" src="/tmp/assets/bb276800/js.cookie.js" class="headScriptTag"></script>
<script type="text/javascript" src="/assets/packages/bootstrap/bootstrap.js" class="headScriptTag"></script>
<script type="text/javascript" src="/assets/packages/bootstrap/plugins/bootstrapconfirm/bootstrapconfirm.js" class="headScriptTag"></script>
<script type="text/javascript" src="/third_party/moment/moment-with-locales.js" class="headScriptTag"></script>
<script type="text/javascript" src="/assets/packages/bootstrap/plugins/select2/js/select2.full.js" class="headScriptTag"></script>
<script type="text/javascript" src="/assets/packages/lslog/build/lslog.js" class="headScriptTag"></script>
<script type="text/javascript" src="/assets/packages/pjax/pjax.js" class="headScriptTag"></script>
<script type="text/javascript" src="/assets/packages/pjax/loadPjax.js" class="headScriptTag"></script>
<script type="text/javascript">
/*<![CDATA[*/
LS.globalUserId = "";
/*]]>*/
</script>
<!-- BEGIN LAYOUT_MAIN --><div class="container-fluid">
<div class="row">
<div id="notif-container" class="col-sm-12 content-right" style="z-index: 999">
</div>
</div>
</div> <div id="pjax-file-load-container" class="ls-flex-row col-12"><div style="height:2px;width:0px;"></div></div><!-- Full page, started in Survey_Common_Action::render_wrapped_template() -->
<div class="container-fluid full-page-wrapper" id="in_survey_common_action">
</div><!-- END LAYOUT_MAIN --><script type="text/javascript" src="/assets/packages/lstutorial/build/lstutorial.js"></script>
<script type="text/javascript">
/*<![CDATA[*/
jQuery('body').popover({'selector':'a\x5Brel\x3Dpopover\x5D'});
jQuery('body').tooltip({'selector':'a\x5Brel\x3Dtooltip\x5D'});
jQuery(document).off('pjax:scriptsuccess.debugger').on('pjax:scriptsuccess.debugger',function(e) { console.ls.log('PJAX scriptsuccess', e); });
jQuery(document).off('pjax:scripterror.debugger').on('pjax:scripterror.debugger',function(e) { console.ls.log('PJAX scripterror', e); });
jQuery(document).off('pjax:scripttimeout.debugger').on('pjax:scripttimeout.debugger',function(e) { console.ls.log('PJAX scripttimeout', e); });
jQuery(document).off('pjax:success.debugger').on('pjax:success.debugger',function(e) { console.ls.log('PJAX success', e);});
jQuery(document).off('pjax:error.debugger').on('pjax:error.debugger',function(e) { console.ls.log('PJAX error', e);});
/*]]>*/
</script>
</body>
</html>
|
|
|
|
Not related to this issue but:
- How you have this issue ?
- How you do the html ? What browser (seems a partial HTML
|
|
dominikvitt
2019-05-10 13:48
developer
~51860
|
Upgrade errors are fixed:
https://github.com/LimeSurvey/LimeSurvey/commit/35b080c32d871938c187410923432f7dccda3859
@DenisChenu: Try again! |
|
|
|
Still have issue
No slow query
Have some warning
2019-05-11 12:01:00 0 [Warning] InnoDB: Table mysql/innodb_table_stats has length mismatch in the column name table_name. Please run mysql_upgrade
2019-05-11 12:01:00 0 [Warning] InnoDB: Table mysql/innodb_index_stats has length mismatch in the column name table_name. Please run mysql_upgrade
2019-05-11 12:01:00 0 [Warning] InnoDB: Table mysql/innodb_table_stats has length mismatch in the column name table_name. Please run mysql_upgrade
2019-05-11 12:01:00 0 [Warning] InnoDB: Table mysql/innodb_index_stats has length mismatch in the column name table_name. Please run mysql_upgrade
2019-05-11 12:01:00 0 [Warning] InnoDB: Table mysql/innodb_table_stats has length mismatch in the column name table_name. Please run mysql_upgrade
I try more log |
|
|
|
Due to time limit in conexion between ngynx and PHP : after 504 error : DB still updated …
I think we must cut in different part all DB update : all i10n update take a very long time
504 during INSERT answer_i10n … |
|
|
|
@dominikvitt : i think only step by step upgrade can be done
1 solutions
- Update to next link
- Update step by step in ajax
The 2 need updateing https://github.com/LimeSurvey/LimeSurvey/blob/35b080c32d871938c187410923432f7dccda3859/application/helpers/update/updatedb_helper.php#L29
db_upgrade_all($iOldDBVersion, $bSilent = false, $steps= null)
or
db_upgrade_all($iOldDBVersion, $bSilent = false, $toVersion= null)
You can give me (still i can't work on Survey curently)
The 1st is more easy (just a counter) |
|
|
|
Only 400 upgrade broke, due to a lot of foreach …
Maybe find another way than doinf a foreach ?
INSERT INTO answertemp (qid, code, scale_id)
SELECT answer.qid, answer.code, answer.scale_id
FROM answer (JOIN answer answerdouble WHERE …)
Or …
a dirty
echo ".";
ob_flush();
flush();
ob_flush();
flush();
And updat it via ajax ? |
|
|
|
Problem: Reaching max execution time will not do a transaction rollback.
Solutions:
1) Set max execution time to 0 (infinite) before db ugprade, restore after done.
2) Check how long the script has run, throw exception if too close to max execution time. |
|
|
|
A separate issue is the lack of feedback during upgrade. A solution would be flushing the buffer, as you say, Denis. |
|
|
|
Some different hacks are available in the comment section here: https://php.net/manual/en/function.set-time-limit.php |
|
|
|
I already use set_time_limit in a foreach instruction on one of my plugin : it's better than set to 0.
Here : i don't think it'a set_time_limit , since it's set as 1200 … via config.php : https://github.com/LimeSurvey/LimeSurvey/blob/9419b901de451fdef5c017a31611c434ba88711f/application/core/LSYii_Controller.php#L104
PS: PHP script still working after 504 : it's NOT a php issue …
Else : this commit : https://github.com/LimeSurvey/LimeSurvey/pull/1278 really improve 400 upgrade : it's OK on my server with thgis DB.
We still need a ajax/step system but don't use a foreach question/group/answers make it very quickest. |
|
|
|
Hm. |
|
|
|
For speed comparaison
~24s
simplescreenrecorder-2019-05-13_14.09.10
VS more than 4 minutes
https://framadrop.org/r/96zPJgI2K_#xyBwlCppuBIDUL34DegO+ypolcuqaK4/7bPLWL4EcqA=
With my local computer |
|
|
|
Broken lime_answers ( updating manually scale_id and sort_order on qid : 4599). since scale_id and sort_order are not in pk : can happen. |
|
|
|
All done https://github.com/LimeSurvey/LimeSurvey/pull/1282
The DB action (method) are done on https://github.com/Shnoulle/Test-LS-checkDbForUpgrade
Checked on PGSQL 9.1.24 (little DB but with multi language)
- [x] Questions update
- [x] Groups update
- [x] Answers update
- [x] Labels update
- [x] DefaultValues update
Checked on PGSQL 10 (little DB but with multi language)
- [x] Questions update
- [x] Groups update
- [x] Answers update
- [x] Labels update
- [x] DefaultValues update
Checked on OBDC 11 - MS SQLServer 12
- [x] Questions update
- [x] Groups update
- [x] Answers update
- [x] Labels update
- [x] DefaultValues update
On MariaDB 10.3.12
- [x] Questions update
- [x] Groups update
- [x] Answers update
- [x] Labels update
- [x] DefaultValues update
Checked on Mysql 5.6.39-1
- [x] Questions update
- [x] Groups update
- [x] Answers update
- [x] Labels update
- [x] DefaultValues update
|
|
|
|
https://github.com/LimeSurvey/LimeSurvey/commit/932542f82bf0fc32f99dfea139d485a742b25162 |
|
