View Issue Details

IDProjectCategoryView StatusLast Update
14402Bug reports[All Projects] Theme editorpublic2019-01-10 15:36
ReporterMaziAssigned ToLouisGac 
PrioritynoneSeverityminor 
Status assignedResolutionopen 
Product Version3.15.x 
Target Version3.16.xFixed in Version 
Summary14402: Welcome message is shown in all-in-one mode even though it was turned off at the survey settings
Description

If I am running a survey in all-in-one mode and I set "show welcome page" to NO, it is still shown on top of the screen at all-in-one mode. This was working fine at v2.73.1.

Steps To Reproduce

Run a survey in all in one mode with a default template and switch showing the welcome message off at the survey settings.

Additional Information

Attached related conversation from Limesurvey IRC, December 20th.

TagsNo tags attached.
Complete LimeSurvey version number (& build)3.15.5+181115
I will donate to the project if issue is resolvedNo
BrowserChrome
Database & DB-VersionMySQL 5
Server OS (if known)Ubuntu 14 TLS
Webserver software & version (if known)Apache 2
PHP Version7.0

Activities

Mazi

Mazi

2019-01-07 10:56

partner  

ICR-log.txt (4,008 bytes)
16:52:46 - Mazi: Hi LouisGac: If I am running a survey in all-in-one mode and I set "show welcome page" to NO, it is still shown on top of te screen at all-in-one mode.
16:52:50 - Mazi: Is that a known issue?
16:53:29 - LouisGac: not sure, if I think it was already the case in older version...
16:53:49 - ollehar: LouisGac: Please give Marcel your Telegram.
16:53:50 - LouisGac: can you test in on 2.73 or 2.06 ?
16:53:56 - LouisGac: already has
16:54:00 - ollehar: Ah. +1
16:54:37 - Mazi: work correct at 2.73.1, no text shown
16:55:24 - Mazi: LouisGac: would that theoretically be fixed at layout_global.twig or is it source code related?
16:57:40 - LouisGac: probably easy to fix in layout
16:57:45 - LouisGac: I'm about to release
16:57:48 - LouisGac: let's fix that first
16:58:17 - Mazi: so if a custom theme does not inherit that file from a shipped template, one would have to manually update this?
17:01:54 - LouisGac: nope, it's a minor change
17:02:09 - LouisGac: and maybe the problem is rather in controller
17:04:08 - Mazi: I see. so will this be fixed at the next release?
17:05:17 - LouisGac: sure
17:05:21 - LouisGac: so: https://github.com/LimeSurvey/LimeSurvey/blob/master/themes/survey/vanilla/views/subviews/content/main.twig#L32
17:05:35 - LouisGac: it was working at a point, I guess a commit broke it
17:06:32 - LouisGac: and to answer your question "will it break templates?"
17:06:33 - LouisGac: https://github.com/LimeSurvey/LimeSurvey/blob/master/themes/survey/vanilla/views/subviews/privacy/allinone_mode_welcome_privacy.twig#L16
17:06:50 - LouisGac: it seems that I thought about debuging those kind of logic when writing it
17:07:29 - LouisGac: and here the answer of your bug:
17:07:31 - LouisGac: https://github.com/LimeSurvey/LimeSurvey/blob/master/themes/survey/vanilla/views/subviews/privacy/allinone_mode_welcome_privacy.twig#L18
17:08:02 - LouisGac: When survey is in All In One mode, if welcome or privacy message are activated, they must be shown on the page.
17:08:02 - LouisGac: When survey is in All In One mode, if welcome or privacy message are activated, they must be shown on the page.
17:08:02 - LouisGac: "When survey is in All In One mode, if welcome or privacy message are activated, they must be shown on the page."
17:08:09 - LouisGac: arf sorry for the 3 lines...
17:08:20 - LouisGac: so I guess @markusfluer did that
17:08:41 - LouisGac: @markusfluer ?
17:09:44 - LouisGac: @Mazi ?
17:10:16 - LouisGac: so I guess that markus put the privacy modal in the welcome page, so if it's activated, then the welcome message is shown
17:10:19 - LouisGac: so not really a bug
17:10:34 - LouisGac: it's more about updating the admin interface to make it clear
17:11:29 - Mazi: at my test case the data protection details are also set to not be shown
17:12:11 - Mazi: @LouisGac so if both are deacivated, no details should be shown. in addition to that, the welcome text should only be shown if the setting is activated, else not.
17:12:54 - Mazi: This is a test survey: https://meinungswelt.raiffeisen-ooe.at/index.php/112233?newtest=Y&lang=de
17:14:49 - LouisGac: so I just confirmed with markus : not a bug
17:15:04 - LouisGac: oh data protection set to not be shown?
17:15:08 - LouisGac: let me check...
17:16:12 - LouisGac: yes I confirm, so bug...
17:36:02 - shnoulle: https://github.com/LimeSurvey/LimeSurvey/blob/master/themes/survey/vanilla/views/subviews/privacy/allinone_mode_welcome_privacy.twig#L16
17:36:25 - shnoulle: not aSurveyInfo.showwelcome != 'N' => gratte … :-/
17:37:28 - shnoulle: https://github.com/LimeSurvey/LimeSurvey/blob/73fe91e1b81657c2f5668ec551e2e6477a637cc1/themes/survey/vanilla/views/subviews/privacy/allinone_mode_welcome_privacy.twig#L22
17:37:49 - shnoulle: Replace by if (aSurveyInfo.showwelcome == "Y") and it's OK
17:37:59 - shnoulle: LouisGac Replace by if (aSurveyInfo.showwelcome == "Y") and it's OK
17:38:14 - shnoulle: no ?
17:38:52 - shnoulle: her : not + or + != …
ICR-log.txt (4,008 bytes)

Issue History

Date Modified Username Field Change
2019-01-07 10:56 Mazi New Issue
2019-01-07 10:56 Mazi Status new => assigned
2019-01-07 10:56 Mazi Assigned To => LouisGac
2019-01-07 10:56 Mazi File Added: ICR-log.txt