View Issue Details

IDProjectCategoryView StatusLast Update
13387User patchesTokenspublic2018-02-21 14:44
Reporterfdecicco Assigned Tomarkusfluer  
PrioritynoneSeverityminor 
Status assignedResolutionopen 
Product Version 
Target VersionFixed in Version 
Summary13387: 2.6.6 LTS Version: SURVEY URL GET format in invitation/reminder email
Description

2.6.6 LTS Version - Build 171111 substitute the keyword {SURVEYURL}
using the GET format instead Path format. i.e.:
http://mylimesurvey/index.php/658138?token=PP431&lang=it
instead of
http://mylimesurvey/index.php/658138/lang/it/token/PP431
I propose a solution in Further Information and in attached file

Steps To Reproduce

send a email invitation with a {SURVEYURL } in the message

Additional Information

/../application/controllers/admin/tokens.php /

/* function email($iSurveyId, $tokenids = null)

/ row 1419 SURVEYURL in 'get' format
$fieldsarray["{SURVEYURL}"] = $this->getController()->
createAbsoluteUrl("/survey/index",array("sid"=>$iSurveyId,"token"=>$emrow['token'],"lang"=>trim($emrow['language'])));
/

/* SURVEYURL in 'path' format
$fieldsarray["{SURVEYURL}"] = $this->getController() -> -createAbsoluteUrl("/survey/index/sid/{$iSurveyId}",array("lang"=>trim($emrow['language']),"token"=>$emrow['token']));

TagsNo tags attached.
Complete LimeSurvey version number (& build)Versione 2.6.6-lts Build 171111

Activities

fdecicco

fdecicco

2018-02-20 11:56

reporter  

tokens.php (128,196 bytes)
lfanfoni

lfanfoni

2018-02-20 13:41

reporter   ~46608

Same behavior in version 3.4

markusfluer

markusfluer

2018-02-20 17:03

administrator   ~46623

Last edited: 2018-02-20 17:04

View 3 revisions

Hello,
Thank you for participating, but we don't support the 2.6.6 anymore.
The current Version 3.X will be put into LTS mode soon.

The createAbsoluteUrl method should automatically parse the setting in the config file, therefore it is completely irrelevant if the sid is set via attributes or as part of the url.
Have you experienced any issues with the email invitaton?

fdecicco

fdecicco

2018-02-21 14:44

reporter   ~46683

Hello,
sorry but this not serious yet unwanted behavior concerns all versions starting from 2.6.6, can you verify, please?
The UrlManager is setted in the application configuration to create all the url in 'path' mode, but this creation is delegated to class UrlRule depending on the rules pattern-route in the file routes.php. The first parameter, the 'route' passed to 'createAbsoluteUrl' determines the rule that must be applied and in some case, it's a behavior a bit strange, can return a ulr in 'get' mode.
I recovered a previous version (limesurvey205plus-build141020) where things work well; here is the corresponding code:

/../application/controllers/admin/tokens.php /

/* function email($iSurveyId, $tokenids = null)
$fieldsarray["{SURVEYURL}"] = $this->getController()
->createAbsoluteUrl("/survey/index/sid/{$iSurveyId}/token/{$emrow['token']}/lang/" . trim($emrow['language']) . "/");

Issue History

Date Modified Username Field Change
2018-02-20 11:56 fdecicco New Issue
2018-02-20 11:56 fdecicco File Added: tokens.php
2018-02-20 13:41 lfanfoni Note Added: 46608
2018-02-20 17:03 markusfluer Note Added: 46623
2018-02-20 17:03 markusfluer Assigned To => markusfluer
2018-02-20 17:03 markusfluer Status new => feedback
2018-02-20 17:04 markusfluer Note Edited: 46623 View Revisions
2018-02-20 17:04 markusfluer Note Edited: 46623 View Revisions
2018-02-21 14:44 fdecicco Note Added: 46683
2018-02-21 14:44 fdecicco Status feedback => assigned