View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
12719Bug reportsSurvey takingpublic2017-09-27 08:562017-09-28 15:46
ReporterDenisChenu Assigned ToLouisGac 
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.70.x 
Fixed in Version2.7x.x 
Summary12719: RTL always loaded (and inverse ;) )
Description

RTL is loaded for survey in french if default language is ar.

Steps To Reproduce

Import included survey,
Launch it in french,
Move next

Additional Information

This is after 1st page : language is not set by post/get , but by $_SESSION['survey_xx']['s_lang'].

I think best is too really use App()->getLanguage BUT : always set this in controller before calling template or anything related.

Must do :

  • check if sid is set
  • check if sid exist (Survey::model()->findByPk())
  • check if language is set by POST/GET (or ?)
  • if sid and survey exist : check session survey
  • if sid is not set or don't exist : check in a global session (setState('defaultlanguage') (new feature))
  • get default survey language + default language
  • set the language according to all this params
    +option+opt
    Think this function can be in core/LSYii_Controller but call ONLY by public controller (at start) : survey+surveys+uploader+register+optin+optout+register+statistics + review for error page (but this one can take only 'global'+'default instance')
TagsNo tags attached.
Attached Files
limesurvey_survey_ar-fr.lss (19,697 bytes)
Capture du 2017-09-27 08-55-46.png (29,868 bytes)   
Capture du 2017-09-27 08-55-46.png (29,868 bytes)   
Bug heat4
Complete LimeSurvey version number (& build)d0d1a604f4e0dc8fa81a1a81a9233e5400191c4a
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2017-09-27 08:57

developer   ~44483

This is same issue than before, but with defaumlt survey language to ar (and not en ;) ).
LouisGac

LouisGac

2017-09-27 10:06

developer   ~44489

this commit should have fixed it right?
https://github.com/LimeSurvey/LimeSurvey/commit/ac585e7a8eeec4ec34f77a668feb7eee940d7045
DenisChenu

DenisChenu

2017-09-27 10:07

developer   ~44490

No : this commit fix it for 1st page or when user change language during survey (just after update language) but not when click on move next :)
LouisGac

LouisGac

2017-09-27 10:10

developer   ~44491

ok thx
LouisGac

LouisGac

2017-09-27 14:51

developer   ~44494

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=23952

Related Changesets

LimeSurvey: master 2238a599

2017-09-27 14:50:41

LouisGac

Details Diff 		Fixed issue 12719: RTL always loaded (and inverse ;) ) Affected Issues
12719
mod - application/models/Survey.php Diff File
mod - application/models/TemplateConfiguration.php Diff File

Issue History

Date Modified Username Field Change
2017-09-27 08:56 DenisChenu New Issue
2017-09-27 08:56 DenisChenu Status new => assigned
2017-09-27 08:56 DenisChenu Assigned To => LouisGac
2017-09-27 08:56 DenisChenu File Added: limesurvey_survey_ar-fr.lss
2017-09-27 08:56 DenisChenu File Added: Capture du 2017-09-27 08-55-46.png
2017-09-27 08:57 DenisChenu Note Added: 44483
2017-09-27 10:06 LouisGac Note Added: 44489
2017-09-27 10:07 DenisChenu Note Added: 44490
2017-09-27 10:10 LouisGac Note Added: 44491
2017-09-27 14:51 LouisGac Changeset attached => LimeSurvey master 2238a599
2017-09-27 14:51 LouisGac Note Added: 44494
2017-09-27 14:51 LouisGac Resolution open => fixed
2017-09-27 15:00 LouisGac Status assigned => resolved
2017-09-28 15:46 c_schmitz Status resolved => closed
2017-09-28 15:46 c_schmitz Fixed in Version => 2.7x.x