View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
12588 | Bug reports | Installation | public | 2017-08-11 09:52 | 2017-10-25 11:12 |
Reporter | fvanderstarre | Assigned To | c_schmitz | ||
Priority | none | Severity | block | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.0.0-beta.x | ||||
Fixed in Version | 3.0.0-beta.x | ||||
Summary | 12588: Upgrade from 3.0.0-beta.1 (or 2.6lts) to 3.0.0-beta.2 fails with db error | ||||
Description | When upgrading from 3.0.0-beta.1 (db version 263) to 3.0.0-beta.2 (db version 3) an error occurs: An non-recoverable error happened during the update. Error details: | ||||
Steps To Reproduce | Perform upgrade as mentioned above (on a ms-sql db) | ||||
Additional Information | Using dblib + freetds | ||||
Tags | data types, mssql, update | ||||
Attached Files | |||||
Bug heat | 12 | ||||
Complete LimeSurvey version number (& build) | 3.0.0-beta.2+170810 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Any | ||||
Database type & version | MS-SQL 2008 R2 OR MySQL | ||||
Server OS (if known) | Linux RHEL 7 | ||||
Webserver software & version (if known) | Apache 2.4.6 | ||||
PHP Version | 5.6.31 | ||||
has duplicate | 12799 | closed | Error when update from 2.6lts |
3.0.0-beta.2 : db version 309 |
|
I set up a SQL server profiler trace - the funny thing is no update statements are performed but somehow an exception is thrown resulting in a transaction rollback. See screen shot from profiler. |
|
I fixed it by rewriting lines 118-122 in updatedb_helper.php:
to:
Now I'm getting stuck in : function createSurveyMenuTable293($oDB): |
|
'MEDIUMTEXT' is not a valid ms-sql datatype (creating tables templates & template_configuration) ... |
|
I'd appreciate some developer feedback on the changes I made to updatedb.helper.php to get it working with ms-sql. See attachment... Thx! |
|
I don't like to use dbQuoteID (and here , it's a table name). Did you try with Or : PS : best is to offer the pull request directly on github :) |
|
Hi Denis, |
|
You're right about create-mssql.sql . I fix the specific issue with oSurvey, but unsure about the other update : Carsten already update some part. |
|
I can't even install the release versions of 3.00 beta 1-3 on MSSQL or Postgres so there will be no fix for these databases. |
|
@c_schmitz : i try (because i need one for testing) I think the Survey model call broke, but i make a test. Do you know the upgradeTemplateTables298 function , it seems really strange |
|
I did two fixes for MySQL (see changesets below) and tested the updates from beta1 to beta 3 now. Will test from stable to beta (latest develop) tomorrow. |
|
Update this morning from 2.6lts to last GIT : OK :) |
|
3.0.0-RC1 Build 171025 released |
|
LimeSurvey: develop f1347e8a 2017-10-17 17:46:21 Details Diff |
Fixed issue: Update from Beta 1 not possible Dev Partial fix |
Affected Issues 12588 |
|
mod - application/helpers/update/updatedb_helper.php | Diff File | ||
LimeSurvey: develop 52e7b7cf 2017-10-17 18:05:22 Details Diff |
Fixed issue: Update from Beta 1 not possible Dev MySQL tested |
Affected Issues 12588 |
|
mod - application/helpers/update/updatedb_helper.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2017-08-11 09:52 | fvanderstarre | New Issue | |
2017-08-11 13:48 | fvanderstarre | Note Added: 44292 | |
2017-08-11 14:48 | fvanderstarre | File Added: LStrace.jpg | |
2017-08-11 14:48 | fvanderstarre | Note Added: 44293 | |
2017-08-14 09:07 | fvanderstarre | Note Added: 44296 | |
2017-09-01 10:54 | fvanderstarre | Note Added: 44393 | |
2017-09-01 11:06 | fvanderstarre | Tag Attached: mssql | |
2017-09-01 11:06 | fvanderstarre | Tag Attached: data types | |
2017-09-01 11:07 | fvanderstarre | Tag Attached: update | |
2017-09-01 13:28 | fvanderstarre | File Added: updatedb_helper.php | |
2017-09-01 13:28 | fvanderstarre | Note Added: 44394 | |
2017-10-17 12:12 | DenisChenu | Relationship added | has duplicate 12799 |
2017-10-17 12:13 | DenisChenu | Summary | Upgrade from 3.0.0-beta.1 to 3.0.0-beta.2 fails with db error (mssql) => Upgrade from 3.0.0-beta.1 (or 2.6lts) to 3.0.0-beta.2 fails with db error |
2017-10-17 12:13 | DenisChenu | Database & DB-Version | MS-SQL 2008 R2 => MS-SQL 2008 R2 OR MySQL |
2017-10-17 12:26 | DenisChenu | Note Added: 44709 | |
2017-10-17 13:00 | fvanderstarre | Note Added: 44710 | |
2017-10-17 13:29 | DenisChenu | Note Added: 44711 | |
2017-10-17 18:28 | c_schmitz | Note Added: 44712 | |
2017-10-17 18:28 | c_schmitz | Assigned To | => c_schmitz |
2017-10-17 18:28 | c_schmitz | Status | new => assigned |
2017-10-17 18:32 | c_schmitz | Note Edited: 44712 | |
2017-10-17 18:40 | DenisChenu | Note Added: 44713 | |
2017-10-17 18:54 | c_schmitz | Changeset attached | => LimeSurvey develop f1347e8a |
2017-10-17 18:54 | c_schmitz | Changeset attached | => LimeSurvey develop 52e7b7cf |
2017-10-17 18:58 | c_schmitz | Note Added: 44714 | |
2017-10-19 11:03 | DenisChenu | Note Added: 44730 | |
2017-10-19 17:01 | c_schmitz | Status | assigned => resolved |
2017-10-19 17:01 | c_schmitz | Resolution | open => fixed |
2017-10-19 17:01 | c_schmitz | Fixed in Version | => 3.0.0-beta.x |
2017-10-25 11:12 | c_schmitz | Note Added: 44823 | |
2017-10-25 11:12 | c_schmitz | Status | resolved => closed |