View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 12560 | Feature requests | Security | public | 2017-08-01 16:11 | 2021-03-08 19:44 |
| Reporter | jackewitz | Assigned To | c_schmitz | ||
| Priority | none | Severity | feature | ||
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 3.0 | ||||
| Summary | 12560: enable video in spite of active xss filtering | ||||
| Description | Dear LS-Developer, xss filtering is mandatoryfor us, but videos (self uploaded - YouTube is a no-go) in questions and help texts is the most requested feature at our organization. LimeSurvey uses HtmlPurifier for xss filtering via yii-framework and the wrapper class CHhtmlPurifier.php. Unfortunately the wrapper class uses the old way to configure HtmlPurifier via an array. To enable video tag (HTML5) we must use the config-object of HtmlPurifier. The trick is:
My approach was to change classes from the yii-framework only minimal and add the maximum changes to the core code of LimeSurvey. I tried to add a branch "xss_enable_video" to LimeSurvey/LimeSurvey to create a pull request afterwards, but $ git push --set-upstream origin xss_enable_video Hope, you can think about und maybe integrate it in LimeSurvey. Best wishes .. Iver | ||||
| Additional Information | development infrastructure:
| ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Bug heat | 264 | ||||
| Story point estimate | |||||
| Users affected % | |||||
| related to | 16649 | closed | gabrieljenik | enable video in spite of active xss filtering - LSv4 |
|
Hi, you can't directly branch in our repo. Usually, you would clone the LimeSurvey repo, make the change and then do a PR. |
|
|
? |
|
|
Yeah, I am currently busy. Try it in the next 2 weeks. |
|
|
Has any progress been made on this? We are running in to the same issue. We have disabled xss filtering for now, but it's not ideal |
|
|
@c_schmitz, we just had the exact same support request at Limesurvey IRC, you helped that user a few days ago. Any way to improve this at LS 4? |
|
|
Integrated the code. |
|
|
After this is tested and accepted, I will continue with the LS4 implementation |
|
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30723 |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30724 |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30725 |
|
|
What's up with this one? It is already done. |
|
|
LimeSurvey: 3.x-LTS 8493b59c 2020-11-12 10:01 Committer: GitHub Details Diff |
New feature 12560: enable video in spite of active xss filtering (#1589) Dev Added new configuration to the HtmlPurifier. Dev Extended the standard HtmlPurifier so it exposes the config in a public method. |
Affected Issues 12560 |
|
| add - application/core/LSYii_HtmlPurifier.php | Diff File | ||
| mod - application/core/LSYii_Validators.php | Diff File | ||
|
LimeSurvey: master 499ddee6 2020-11-12 10:01 Committer: c_schmitz Details Diff |
New feature 12560: enable video in spite of active xss filtering (#1589) Dev Added new configuration to the HtmlPurifier. Dev Extended the standard HtmlPurifier so it exposes the config in a public method. |
Affected Issues 12560 |
|
| add - application/core/LSYii_HtmlPurifier.php | Diff File | ||
| mod - application/core/LSYii_Validators.php | Diff File | ||
|
LimeSurvey: master 98b3190f 2020-11-13 16:28 Details Diff |
Revert "New feature 12560: enable video in spite of active xss filtering (#1589)" This reverts commit 499ddee66bbe429364e9b481fa934f42ab1e0062. |
Affected Issues 12560 |
|
| rm - application/core/LSYii_HtmlPurifier.php | Diff | ||
| mod - application/core/LSYii_Validators.php | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-08-01 16:11 | jackewitz | New Issue | |
| 2017-08-01 16:11 | jackewitz | File Added: LSYii_Validators.php | |
| 2017-09-22 15:55 | c_schmitz | Assigned To | => c_schmitz |
| 2017-09-22 15:55 | c_schmitz | Status | new => feedback |
| 2017-09-22 15:55 | c_schmitz | Note Added: 44450 | |
| 2017-09-27 08:59 | c_schmitz | Note Added: 44485 | |
| 2017-09-27 09:03 | jackewitz | Note Added: 44486 | |
| 2017-09-27 09:03 | jackewitz | Status | feedback => assigned |
| 2019-03-13 10:36 | Jelle_S | Note Added: 50941 | |
| 2019-03-13 10:45 | Jelle_S | Issue Monitored: Jelle_S | |
| 2019-12-05 21:25 | Mazi | Note Added: 54959 | |
| 2020-09-09 15:47 | cdorin | Assigned To | c_schmitz => gabrieljenik |
| 2020-09-09 15:56 | gabrieljenik | Issue cloned: 16649 | |
| 2020-09-09 15:56 | gabrieljenik | Relationship added | related to 16649 |
| 2020-09-11 21:44 | gabrieljenik | Note Added: 59779 | |
| 2020-09-11 21:45 | gabrieljenik | Note Added: 59780 | |
| 2020-09-23 18:41 | arnaudj | Issue Monitored: arnaudj | |
| 2020-11-12 09:01 | gabrieljenik | Changeset attached | => LimeSurvey 3.x-LTS 8493b59c |
| 2020-11-12 09:01 | gabrieljenik | Note Added: 60622 | |
| 2020-11-12 09:01 | gabrieljenik | Resolution | open => fixed |
| 2020-11-12 09:03 | c_schmitz | Changeset attached | => LimeSurvey master 499ddee6 |
| 2020-11-12 09:03 | gabrieljenik | Note Added: 60623 | |
| 2020-11-13 15:28 | c_schmitz | Changeset attached | => LimeSurvey master 98b3190f |
| 2020-11-13 15:28 | c_schmitz | Note Added: 60636 | |
| 2020-11-13 15:28 | c_schmitz | Assigned To | gabrieljenik => c_schmitz |
| 2020-11-13 19:36 | gabrieljenik | Note Added: 60638 | |
| 2021-03-08 19:44 | c_schmitz | Status | assigned => closed |
| 2021-03-08 19:44 | c_schmitz | Fixed in Version | => 3.0 |
| 2021-08-02 17:09 | guest | Bug heat | 260 => 264 |