12412: File upload responses are not removed when deleting surveys with the API

ID	Project	Category	View Status	Date Submitted	Last Update

12412	Feature requests	[All Projects] RemoteControl	public	2017-05-18 16:16	2017-05-18 16:16

Reporter	brammeleman
Assigned To
Priority	none	Severity	feature
Status	new	Resolution	open
Product Version
Target Version		Fixed in Version

Summary	12412: File upload responses are not removed when deleting surveys with the API
Description	While file upload responses are deleted when deleting a survey from the survey admin interface, they aren't when surveys are deleted with an API call.
Additional Information	There's a little wrapper function in application/controllers/admin/surveyadmin.php (line 1553) that calls the Survey model with deleteSurvey, followed by an rmdirr call with the appropiate upload directory for the specified sid. The rmdirr call is not present in the delete_survey method of the remotecontrol_handle (line 174 of application/helpers/remotecontrol/remotecontrol_handle.php) I would suggest moving the rmdirr call to the deleteSurvey method of the Survey model. That would also eliminate the need for the _deleteSurvey wrapper in the SurveyAdmin. Bests, Bram Radboud University NL
Tags	No tags attached.