Just for your advice/idea here ?
I think i work on it for 2.7 or 3.0 : seems really needed. Maybe not for whole menu (each menu need a different input then own event) but .....

Alternative : construct an extension/menu but : this take really more time (and we don't have submenu event)

1. Do we want plugin devs to be able to put new menu entries anywhere, or should all plugin menus be put in a specific place?

2. Louis would scream about this idea, since he wants a menu system inspired from Joomla. Such a system would register menu entries in the database based on place holder number or such, and XML config. Personally, I feel like both systems - events or XML/database - have the same level of complexity.

3. It would probably be possible to use one event for all menus. The event listener must then check one of the input args to the event to know which menu is relevant for this specific event triggering. Edit: Oh, maybe that's what you're suggesting. ^^

For 1 : i really think allowing entry everywhere is a must have. If not : need : Token menu/Response menu/Statistics menu/Question view/Group view
For 2 : XML or event or DB : it's not the point. The point is 'did we need one' , and again : Yii extensions/modules is made in Yii event.
For 3 : yes, it's what i'm suggesting ...

OK, I agree with this design then.

Do we need it? Don't know. :) What's the use-case? Do we have any idea on what the plugin system should NOT be able to do? Well, it's the only way to extend LS, for now, so. :P

Use case : some example

• To be added in statistics menu : https://framagit.org/SondagePro-LimeSurvey-plugin/statsPivotTable and not in Survey/tool sub-menu
• To be added in statictics https://framagit.org/SondagePro-LimeSurvey-plugin/extendAdminStatitistics and not replace statitics
• To be added in browse reponses and view response : https://framagit.org/SondagePro-LimeSurvey-plugin/recomputeExpression (actually an hack to add it in 2.6 version)
• Best in token management : https://framagit.org/SondagePro-LimeSurvey-plugin/sendMailAjax
• Best in token management : https://framagit.org/SondagePro-LimeSurvey-plugin/updateTokenByResponse

PS : we need 2 things

• A way to add menu item
• A way to call 'specic admin part' : for example : call token view except content.

Wow, OK.

" - A way to call 'specic admin part' : for example : call token view except content. "

How is this different than to render a side-body?

sidebody add 'Survey menu' if surveyid is set, we need side body with 'token menu' or 'reponse menu' or .....

Bah. Those menus should be removed anyway... Or at least be collapsed into one bigger drop-down menu.

But OK, I get your point.

You mean this 2 menu (for example) ????

I didn't get it and don't remind of any discussion to remove this specific menu, and what replacement must done

Yeah, but that's just me, there's no discussion about it. See my screenshot in the IRC of the Yahoo user settings web site.

You think the side-body event can be modified to configure which menu to show?

Yes, maybe : what 'layout' must be used.

default
nothing : global page
surveyid set : survey page
surveyid + page set : page dependent : page can be token/response/ for starting, adding statitics or question ....

But if we remove all if this in 6 month : i didn't work on it ....

Hm, I don't know if we have any concrete plans for the admin interface at this point.

Personally, I'd prefer if LS 4 was Louis doing question object types, but that's only me.

Markus has expressed a wish to modify the admin interface. No idea if that will happen.

Maybe we should bring it up on the next team meeting, so we can guarantee some stability?

Example of usage (private plugin, based on https://framagit.org/SondagePro-LimeSurvey-plugin/statsPivotTable)

Another example

Adding via script
https://gitlab.com/SondagesPro/Authentification/AuthRemoteToken/-/blob/main/AuthRemoteToken.php#L339

Capture d’écran du 2022-06-07 11-46-42.png (13,236 bytes)   

Capture d’écran du 2022-06-07 11-46-42.png (13,236 bytes)   

Ye. Five years later... Louis wanted to do a database-based menu system, Markus did some menu database tables, but they're kind of weird and maybe bloated... Not sure now.

database-based menu system

Survey menu currently .
Already use it too …
https://gitlab.com/SondagesPro/TokenManagement/TokenUsersListAndManage/-/blob/master/TokenUsersListAndManage.php#L653

But hacking, doing it via my own way ;)

'addSurveyId' => true,
'addQuestionGroupId' => false,
'addQuestionId' => false,

I smell a security issue here, if it's possible to add all three of those in one URL.......

One problem with putting all menus in db is that every time we change a link or translation, we have to do a db update. A possible solution:

1) Add a new menu service provider, from which all menus come from, in form of classes like Menu and MenuItem
2) Add an event in the menu service provider that plugins can hook into
3) Possibly also add support for fetching menus from the database

NB, I'm using service locator pattern in the plugin update system

form of classes like Menu and MenuItem

This need to be improved (there are some TODO)

https://forums.limesurvey.org/forum/plugins/127587-how-to-add-custom-button-in-tool-bar-section#240133

Please do not fetch menu items from database. Always add and remove items via event
keep in mind that action buttons are kind of menus, too, eg Tools menu

Please do not fetch menu items from database. Always add and remove items via event

+1

As expressed in ticket 18654, I prefer a global registry class rather than multiple events. But maybe one global event could work too, actually.