View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
11977 | Feature requests | Theme editor | public | 2016-12-02 15:01 | 2018-04-06 11:48 |
Reporter | DenisChenu | Assigned To | DenisChenu | ||
Priority | none | Severity | feature | ||
Status | closed | Resolution | fixed | ||
Fixed in Version | 3.0 | ||||
Summary | 11977: Don't replace alert() javascript function | ||||
Description | Think it's a bad idea to replace alert() function (and it's broken currently : you can not do alert(1) + alert(2) : you see only the last one) | ||||
Additional Information | LS usage of a new function sendAlert Core package use alert here | ||||
Tags | answers_html | ||||
Bug heat | 2 | ||||
Story point estimate | |||||
Users affected % | |||||
related to | 11784 | closed | DenisChenu | Replace alert + confirm in core system (?) |
(12:58:52) Deusdeorum: who made the new default templates btw? did not know it is possible to style the javascript alert pop up. very nice |
|
Done in https://github.com/LimeSurvey/LimeSurvey/commit/ba5d184776451087a1eb6efef35f9e05c53e4451 Can easily reversed by uncomment https://github.com/LimeSurvey/LimeSurvey/commit/ba5d184776451087a1eb6efef35f9e05c53e4451#diff-7a51e41b79e5ef4131e9fc80819ff882R113 Still : have a alertSurveyDialog function to just replace 'limesurvey' alert seems to be good. |
|
Fixed + improved |
|
Javascript functions
https://github.com/LimeSurvey/LimeSurvey/blob/develop/application/core/packages/limesurvey/survey.js |
|
LimeSurvey: develop ba5d1847 2016-12-02 19:13 Details Diff |
Dev: 11977: Don't replace alert() javascript function |
Affected Issues 11977 |
|
mod - application/core/packages/limesurvey/survey.js | Diff File | ||
mod - application/core/packages/questions/ranking/ranking.js | Diff File | ||
mod - templates/default/scripts/template.js | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2016-12-02 15:01 | DenisChenu | New Issue | |
2016-12-02 15:01 | DenisChenu | Status | new => assigned |
2016-12-02 15:01 | DenisChenu | Assigned To | => DenisChenu |
2016-12-02 15:01 | DenisChenu | Tag Attached: answers_html | |
2016-12-02 18:02 | DenisChenu | Note Added: 42321 | |
2016-12-02 18:03 | DenisChenu | Note Edited: 42321 | |
2016-12-02 18:14 | DenisChenu | Changeset attached | => LimeSurvey develop ba5d1847 |
2016-12-02 18:16 | DenisChenu | Assigned To | DenisChenu => |
2016-12-02 18:16 | DenisChenu | Status | assigned => feedback |
2016-12-02 18:16 | DenisChenu | Note Added: 42322 | |
2016-12-06 08:35 | DenisChenu | Assigned To | => DenisChenu |
2016-12-06 08:35 | DenisChenu | Status | feedback => resolved |
2016-12-06 08:35 | DenisChenu | Resolution | open => fixed |
2016-12-06 08:35 | DenisChenu | Fixed in Version | => 3.0 |
2016-12-06 08:35 | DenisChenu | Note Added: 42385 | |
2016-12-06 08:37 | DenisChenu | Status | resolved => feedback |
2016-12-06 08:37 | DenisChenu | Resolution | fixed => reopened |
2016-12-06 08:37 | DenisChenu | Note Added: 42386 | |
2016-12-06 08:37 | DenisChenu | Status | feedback => resolved |
2016-12-06 08:37 | DenisChenu | Resolution | reopened => fixed |
2016-12-10 14:22 | DenisChenu | Relationship added | related to 11784 |
2018-04-06 11:48 |
|
Status | resolved => closed |