View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
11963Feature requestsOtherpublic2021-08-19 15:41
ReporterDenisChenu Assigned ToLouisGac 
PrioritynoneSeverityfeature 
Status closedResolutionreopened 
Summary11963: 404 better managed by view
Description

Actual 404 have 2 issue:

  • Debug: 0 : a "white+black" page
  • Debug : 1 : show complete error
Additional Information

1 : think template manager can be allowed to udate partially 404 : example : add "survey listing" if they want
2 : 401 can be in it too :

  1. Really don't know for 500 error with debug mode : "error" but with all information if debug is set ?
TagsNo tags attached.
Attached Files
404-debug0.png (52,757 bytes)   
404-debug0.png (52,757 bytes)   
404-debug1.png (67,550 bytes)   
404-debug1.png (67,550 bytes)   
404-fixed.png (53,845 bytes)   
404-fixed.png (53,845 bytes)   
Bug heat4
Story point estimate
Users affected %

Users monitoring this issue

Mazi

Activities

DenisChenu

DenisChenu

2016-11-29 16:00

developer   ~42258

I think 404-debug1.png is really un undesirable behaviour.

DenisChenu

DenisChenu

2016-11-29 16:25

developer   ~42259

See : https://github.com/LimeSurvey/LimeSurvey/pull/605

DenisChenu

DenisChenu

2017-10-30 16:53

developer   ~44904

404 exception not send : https://testing.sondages.pro/develop/12324 it's send 200 OK
Old behaviour come back : https://testing.sondages.pro/develop/none

It's fixed in Version 3.0.0 alpha (2.57.1 merged) : http://testing.sondages.pro/answershtml/dddd send a real 404 like https://testing.sondages.pro/answershtml/1234

We need use Throw:error and not another part …

DenisChenu

DenisChenu

2018-02-23 11:45

developer   ~46730

Last edited: 2018-02-23 11:46

404 still send 200 …

And this default layout are really really awfull

DenisChenu

DenisChenu

2018-06-29 00:48

developer   ~48383

Redoing it for 404 (and 401/403) is very easy since all code still here …

DenisChenu

DenisChenu

2018-06-29 10:51

developer   ~48390

Last edited: 2018-06-29 10:51

I don't know where to put feedback  …

https://github.com/LimeSurvey/LimeSurvey/pull/1089

Related Changesets

LimeSurvey: develop 03b406b7

2016-11-29 16:15:15

DenisChenu

Details Diff
Dev: issue 11963: 404 better managed by view
Dev: only 404 currently, use default template
Affected Issues
11963
mod - application/controllers/SurveysController.php Diff File
mod - application/core/LSYii_Application.php Diff File
mod - application/views/system/error404.php Diff File

Issue History

Date Modified Username Field Change
2016-11-29 15:56 DenisChenu New Issue
2016-11-29 15:56 DenisChenu File Added: Capture du 2016-11-29 15-48-05.png
2016-11-29 15:57 DenisChenu File Added: Capture du 2016-11-29 15-06-49.png
2016-11-29 15:57 DenisChenu File Deleted: Capture du 2016-11-29 15-06-49.png
2016-11-29 15:57 DenisChenu File Deleted: Capture du 2016-11-29 15-48-05.png
2016-11-29 15:58 DenisChenu File Added: 404-debug0.png
2016-11-29 15:58 DenisChenu File Added: 404-debug1.png
2016-11-29 16:00 DenisChenu Note Added: 42258
2016-11-29 16:25 DenisChenu Note Added: 42259
2016-11-29 16:25 DenisChenu File Added: 404-fixed.png
2016-11-30 11:08 Mazi Issue Monitored: Mazi
2016-12-02 17:56 DenisChenu Changeset attached => LimeSurvey develop 03b406b7
2016-12-02 19:05 DenisChenu Assigned To => DenisChenu
2016-12-02 19:05 DenisChenu Status new => resolved
2016-12-02 19:05 DenisChenu Resolution open => fixed
2016-12-02 19:05 DenisChenu Fixed in Version => 3.0
2017-10-30 16:51 DenisChenu Assigned To DenisChenu => LouisGac
2017-10-30 16:51 DenisChenu Status resolved => feedback
2017-10-30 16:51 DenisChenu Resolution fixed => reopened
2017-10-30 16:53 DenisChenu Note Added: 44904
2017-10-30 16:53 DenisChenu Status feedback => assigned
2018-02-23 11:45 DenisChenu Note Added: 46730
2018-02-23 11:46 DenisChenu Note Edited: 46730
2018-06-29 00:48 DenisChenu Note Added: 48383
2018-06-29 02:09 DenisChenu Assigned To LouisGac => DenisChenu
2018-06-29 10:51 DenisChenu Assigned To DenisChenu => LouisGac
2018-06-29 10:51 DenisChenu Status assigned => feedback
2018-06-29 10:51 DenisChenu Note Added: 48390
2018-06-29 10:51 DenisChenu Note Edited: 48390
2021-08-19 15:41 galads Status feedback => closed