LimeSurvey: 3.x-LTS e75d2f37

Author Committer Branch Timestamp Parent
gabrieljenik GitHub 3.x-LTS 2020-09-07 07:24:38 3.x-LTS 72f24a3e
Changeset

DEV 16488: Reviewing updateQuestionOrder usage (#1532)

  • Removed language from Question::updateQuestionOrder parameters.
    The method now uses the survey base language to work.
  • Changed how order is handled in actionUpdateQuestion (database.php)
  • Removed call to Question::updateQuestionOrder in actionInsertCopyQuestion() (database.php), because order was already handled.
  • Updated shiftOrderQuestions (common_helper.php) for not using language inside of it.
    This function is not used anymore in Limesurvey's codebase, but still it might be used by others, or in the future.
  • Calls to Question::updateSortOrder where replaced by Question::updateQuestionOrder for consistency.
    updateSortOrder is not removed from the codebase, just in case.
mod - application/controllers/admin/database.php Diff File
mod - application/controllers/admin/questions.php Diff File
mod - application/helpers/common_helper.php Diff File
mod - application/helpers/remotecontrol/remotecontrol_handle.php Diff File
mod - application/models/Question.php Diff File