View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|18460||Bug reports||Import/Export||public||2022-11-05 13:03||2022-11-30 15:42|
|Status||in code review||Resolution||open|
|Summary||18460: Assigned survey group is gone after survey export/import|
When exporting a survey which is assigned to survey group X and then importing that LSS file, the assignment to survey group X is gone.
|Steps To Reproduce|
Steps to reproduce
Assign a survey to a certain survey group.
Imported survey should still be assigned to the same survey group if exists.
Survey group assignment is missing.
|Tags||No tags attached.|
|Complete LimeSurvey version number (& build)||3.28.32|
|I will donate to the project if issue is resolved||No|
|Database type & version||MariaDB 10.1.48|
|Server OS (if known)|
|Webserver software & version (if known)|
|PHP Version||PHP 7.4|
It must be an option … same issue with Permission.
It must be different if you import on same instance or different one (group are not the same)
Then : when copy : we can copy Permission + Group
Hm yes, you can't uniquely identify a survey group between installations. So does it make sense to "guess" a survey group?
By name by option when import ? Same for Permission ?
@ollehar: I assume that at 90% of the cases you jst copy (or export/import) within the same system so checking for matchting IDs and similar names should be sufficient.
Maybe also show a short note "Survey assigned to survey group XYZ." after copy.
When you copy : it must be the case (like Permission in 3.X cuirrently).
I guess the same happens in many other situations:
Matching by name is fine I guess.
This didn't exist …
Yes : already written "same issue with Permission"
Oh yes : theme have number in export … but seems they use name : with core and extended.
I mean, there are other places where the linking by name is done for importing.
But only Permission and SurveyGroup are not seen quickly and can have some «security» issue :).
For theme : it shown when you test ;)
Master PR for Survey Groups: https://github.com/LimeSurvey/LimeSurvey/pull/2745
Created 18509 for handling permissions
I like to have a checkbox (unchecked by default)
Why should such a new checkbox be unchecked by default? If the same survey group exists, it should get mapped.
E.g. user permissions are copied along as well on export/import, why should this behave differently?
I think a checkbox is not needed. I see no real use case at which assigning the survey to the same group will cause any issues. In any way, you can always adjust the assignment later if needed.
If you use "restricted" name, and i use "restricted" name too on another instance.
If i put some secret survey inside with right to some people : i surely don't want to have this right auto assigned.
I don't think with import/export … see https://bugs.limesurvey.org/view.php?id=18509
Survey group can give right to survey inside the group
@DenisChenu, I understand the issue you mentioned. But to me the mentioned scenario of having the exact same survey group name on different instances is a rather theoretical issue. Of course, it can lead to security issues if permissions are assigned as mentioned on Github, but we deal with >250 Limesurvey projects every year and I can not imagine having ever faced such a use case.
If it helps, we can add the checkbox, but the default behavior should be to always assign the survey to the survey group. Because that will be the use case for 99% of the users.
What ???? I already seen it a lot of time !
Your experience are not all reality …
We don't have this feature since start and you are the 1st to ask … import/export != copy
Well, I am not against adding the checkbox. It makes sense when facing the scenario you mentioned. We should also add a warning as mentioned. But the default setting should fit the 90% of users which just want the survey to be assiged to the same survey group if exists.
"Why not copy?" -> Because customers often develop surveys at system A and then export the final version and import that at system B.
I can only speak of me, but me and my colleagues are facing this issue on a daily basis and keeping the survey group name on importing would save us a lot of time and avoid possible errors. As of now, we always need to edit the survey again after importing to set it to the desired survey group name, before we can continue. Having the optional checkbox to keep the survey group name on importing would be highly appreciated.
After the questoin is more by default or not.
After internal discussion here is the decision on the solution:
No checkbox on import is needed. Since the user has permission to modify the assignment to the survey group he can still change it, afterwards.
Need to check survey/import not just see surveygroup
|2022-11-05 13:03||Mazi||New Issue|
|2022-11-05 18:43||DenisChenu||Note Added: 72576|
|2022-11-05 18:43||DenisChenu||Bug heat||0 => 2|
|2022-11-07 11:49||ollehar||Note Added: 72596|
|2022-11-07 11:49||ollehar||Bug heat||2 => 4|
|2022-11-07 11:51||DenisChenu||Note Added: 72597|
|2022-11-07 11:51||DenisChenu||Note Edited: 72597|
|2022-11-07 12:10||Mazi||Note Added: 72600|
|2022-11-07 12:10||Mazi||Bug heat||4 => 6|
|2022-11-07 12:11||Mazi||Note Added: 72601|
|2022-11-07 13:31||DenisChenu||Note Added: 72604|
|2022-11-07 14:41||gabrieljenik||Note Added: 72614|
|2022-11-07 14:41||gabrieljenik||Bug heat||6 => 8|
|2022-11-07 14:41||gabrieljenik||Status||new => confirmed|
|2022-11-07 15:38||DenisChenu||Note Added: 72621|
|2022-11-07 15:44||gabrieljenik||Note Added: 72623|
|2022-11-07 16:49||DenisChenu||Note Added: 72626|
|2022-11-16 12:48||Mazi||Note Added: 72759|
|2022-11-16 13:55||gabrieljenik||Assigned To||=> gabrieljenik|
|2022-11-16 13:55||gabrieljenik||Status||confirmed => assigned|
|2022-11-23 20:42||gabrieljenik||Assigned To||gabrieljenik => DenisChenu|
|2022-11-23 20:42||gabrieljenik||Status||assigned => ready for code review|
|2022-11-23 20:42||gabrieljenik||Note Added: 72879|
|2022-11-23 20:45||gabrieljenik||Issue cloned: 18509|
|2022-11-23 20:45||gabrieljenik||Relationship added||related to 18509|
|2022-11-23 20:45||gabrieljenik||Note Added: 72880|
|2022-11-24 10:12||DenisChenu||Assigned To||DenisChenu =>|
|2022-11-24 10:12||DenisChenu||Assigned To||=> gabrieljenik|
|2022-11-24 10:12||DenisChenu||Note Added: 72881|
|2022-11-24 11:00||Mazi||Note Added: 72883|
|2022-11-24 12:07||DenisChenu||Note Added: 72884|
|2022-11-24 12:08||DenisChenu||Note Edited: 72884|
|2022-11-25 10:10||DenisChenu||Note Added: 72889|
|2022-11-25 10:12||DenisChenu||Status||ready for code review => in code review|
|2022-11-25 10:22||Mazi||Note Added: 72891|
|2022-11-25 10:25||DenisChenu||Note Added: 72892|
|2022-11-25 10:31||Mazi||Note Added: 72893|
|2022-11-25 12:50||maknase||Note Added: 72894|
|2022-11-25 12:50||maknase||Bug heat||8 => 10|
|2022-11-25 14:57||DenisChenu||Note Added: 72896|
|2022-11-25 15:05||c_schmitz||Note Added: 72899|
|2022-11-25 15:05||c_schmitz||Bug heat||10 => 12|
|2022-11-25 15:06||c_schmitz||Status||in code review => assigned|
|2022-11-25 15:08||c_schmitz||Note Edited: 72899|
|2022-11-25 15:08||c_schmitz||Note Edited: 72899|
|2022-11-30 15:20||gabrieljenik||Assigned To||gabrieljenik => DenisChenu|
|2022-11-30 15:20||gabrieljenik||Status||assigned => ready for code review|
|2022-11-30 15:21||gabrieljenik||Note Added: 72942|
|2022-11-30 15:24||gabrieljenik||Issue cloned: 18530|
|2022-11-30 15:42||DenisChenu||Assigned To||DenisChenu => gabrieljenik|
|2022-11-30 15:42||DenisChenu||Status||ready for code review => in code review|
|2022-11-30 15:42||DenisChenu||Note Added: 72943|