Dependency Graph

Dependency Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
18436Bug reportsSurvey participants (Tokens)public2023-08-07 17:06
Reportercolnect Assigned ToDenisChenu  
PrioritynormalSeverityblock 
Status assignedResolutionreopened 
Product Version5.4.x 
Fixed in Version5.4.x 
Summary18436: Remote control API : Inviting members with invalid language sends them an email but they're not marked as invited
Description

This happens in 5.4.8+221024 but didn't happen in 5.0.10+210723. Via the API, inviting all tokenized users to the survey marks only some as invited and others not, EVEN THOUGH an email is sent to them.
When trying to mass edit these users to change their statis as invited, the error "language: Language code is invalid in this survey" is given and the operation fails. However, manually editing each user is possible.
This blocks the use of the invitation feature as people kept getting the same emails repeatedly and reported them.

More details are in https://forums.limesurvey.org/forum/plugins/128560-survey-invitations-keeps-getting-resent

Steps To Reproduce

Steps to reproduce

Create some tokens for users in different languages, including a language that the specific survey doesn't have. Send invitations to all.

Expected result

All those who get an email are marked as invited

Actual result

The ones with an invalid language code are not marked as invited and so additional invitation emails will be sent to them on every launch

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)5.4.8+221024
I will donate to the project if issue is resolvedYes
Browser
Database type & versionMariaDB
Server OS (if known)
Webserver software & version (if known)
PHP Version8.0

Relationships

duplicate of 18034 closedDenisChenu Date from token with invalid language show error and date not saved 

Activities

gabrieljenik

gabrieljenik

2022-10-31 14:06

manager   ~72482

Via the API, inviting all tokenized users to the survey marks only some as invited and others not, EVEN THOUGH an email is sent to them.

The error happens only via API invitations?

colnect

colnect

2022-10-31 14:12

reporter   ~72484

As clarified, I can't do mass-edit either. I don't dare to click invite all from the admin because I don't want to spam hundreds of people again. They all got 4 of the same emails already

gabrieljenik

gabrieljenik

2022-10-31 14:19

manager   ~72485

Please, can I ask you to create a new ticket for the mass-edit part?
Thanks

DenisChenu

DenisChenu

2022-10-31 14:56

developer   ~72487

The error happens only via API invitations?

For admin GUI : https://bugs.limesurvey.org/view.php?id=18034

Fix are in https://github.com/LimeSurvey/LimeSurvey/pull/2352
since April the 14 …

colnect

colnect

2022-11-01 00:10

reporter   ~72498

DenisChenu - if fixe is marked as closed, doesn't it mean it's been merged and should have been on the latest version, which is the version I have?

gabrieljenik - I think it's all around the same token issue so I don't believe there's a need for various issues here but feel free to, I'm not familiar with the codebase.

colnect

colnect

2022-11-01 00:32

reporter   ~72499

Until it's possible to use a fixed version, could any of you indicate for me how to mark tokens as 'invited' in the database? Some sort of SQL would be great as I'm not sure if only one table is affects and I don't wanna dive so deeply into the code and end up messing the DB. Thanks

DenisChenu

DenisChenu

2022-11-01 02:20

developer   ~72501

DenisChenu - if fixe is marked as closed, doesn't it mean it's been merged and should have been on the latest version, which is the version I have?

reopen because system to create PR are updated

https://github.com/LimeSurvey/LimeSurvey/pull/2691

gabrieljenik

gabrieljenik

2022-11-10 14:15

manager   ~72699

PR 2691 tested OK towards this bug

colnect

colnect

2022-12-21 04:03

reporter   ~73217

I've upgraded to Version 5.4.15+221212 and the bug still exists. Reminders were repeatedly sent (using $limeAPI->remind_participants() ) to the same people over and over, yet they haven't been marked. Obviously this is causing a big wave of complaints and reduces our reputation as a non-spammer. Also $limeAPI->invite_participants() keeps showing the same people over and over again

DenisChenu

DenisChenu

2022-12-21 08:18

developer   ~73220

$limeAPI->remind_participants() don't seem related ?

$limeAPI->invite_participants() argl, related issue are for GUI, not API, i update the title.

colnect

colnect

2022-12-21 12:08

reporter   ~73230

From the creation of the issue it was about the API. There are still problems and they don't seem solved in the newest version.

gabrieljenik

gabrieljenik

2022-12-21 15:24

manager   ~73246

PR 2691 tested OK towards this bug

Yes, sorry. That was from the Admin GUI

DenisChenu

DenisChenu

2022-12-21 16:28

developer   ~73247

https://github.com/LimeSurvey/LimeSurvey/pull/2810

colnect

colnect

2023-01-14 12:13

reporter   ~73465

I've previously deployed the patch and things seemed better with it. I now upgraded to Version 5.5.2+230109 and it seems the patch isn't there either. So should I apply it again?

gabrieljenik

gabrieljenik

2023-01-16 13:51

manager   ~73471

Yes, please. The patch is not yet released.

gabrieljenik

gabrieljenik

2023-03-17 15:14

manager   ~74171

@DenisChenu Please find below some tests added for remote control invitation process.
Can be attached to this PR maybe :)
https://github.com/LimeSurvey/LimeSurvey/tree/bug/18436_API_sendmail_invalidlang_tests

Issue History

Date Modified Username Field Change
2022-10-30 21:43 colnect New Issue
2022-10-31 09:05 DenisChenu Issue Monitored: DenisChenu
2022-10-31 09:05 DenisChenu Bug heat 0 => 2
2022-10-31 14:06 gabrieljenik Status new => acknowledged
2022-10-31 14:06 gabrieljenik Note Added: 72482
2022-10-31 14:06 gabrieljenik Bug heat 2 => 4
2022-10-31 14:12 colnect Note Added: 72484
2022-10-31 14:12 colnect Bug heat 4 => 6
2022-10-31 14:19 gabrieljenik Note Added: 72485
2022-10-31 14:55 DenisChenu Relationship added duplicate of 18034
2022-10-31 14:56 DenisChenu Note Added: 72487
2022-10-31 14:56 DenisChenu Bug heat 6 => 8
2022-11-01 00:10 colnect Note Added: 72498
2022-11-01 00:32 colnect Note Added: 72499
2022-11-01 02:20 DenisChenu Note Added: 72501
2022-11-01 02:20 DenisChenu Assigned To => DenisChenu
2022-11-01 02:20 DenisChenu Status acknowledged => assigned
2022-11-01 09:24 ollehar Priority none => normal
2022-11-03 16:43 DenisChenu Assigned To DenisChenu => ollehar
2022-11-03 16:43 DenisChenu Status assigned => ready for testing
2022-11-03 16:43 DenisChenu Category Central participant database => Survey participants (Tokens)
2022-11-10 14:15 gabrieljenik Note Added: 72699
2022-11-10 15:48 DenisChenu Status ready for testing => ready for merge
2022-11-22 14:18 DenisChenu Status ready for merge => resolved
2022-11-22 14:18 DenisChenu Resolution open => duplicate
2022-11-22 14:18 DenisChenu Fixed in Version => 5.4.x
2022-12-15 08:44 DenisChenu Assigned To ollehar => DenisChenu
2022-12-15 08:44 DenisChenu Status resolved => closed
2022-12-21 04:03 colnect Status closed => feedback
2022-12-21 04:03 colnect Resolution duplicate => reopened
2022-12-21 04:03 colnect Note Added: 73217
2022-12-21 08:18 DenisChenu Note Added: 73220
2022-12-21 08:18 DenisChenu Summary Inviting members with invalid language sends them an email but they're not marked as invited => Remote control API : Inviting members with invalid language sends them an email but they're not marked as invited
2022-12-21 12:08 colnect Note Added: 73230
2022-12-21 12:08 colnect Status feedback => assigned
2022-12-21 15:24 gabrieljenik Note Added: 73246
2022-12-21 16:28 DenisChenu Note Added: 73247
2022-12-21 16:28 DenisChenu Assigned To DenisChenu =>
2022-12-21 16:28 DenisChenu Status assigned => ready for code review
2023-01-14 12:13 colnect Note Added: 73465
2023-01-16 13:51 gabrieljenik Note Added: 73471
2023-03-17 15:14 gabrieljenik Note Added: 74171
2023-08-07 17:06 gabrieljenik Assigned To => DenisChenu
2023-08-07 17:06 gabrieljenik Status ready for code review => assigned