Relationship Graph

Relationship Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
17312Bug reportsSurvey editingpublic2021-07-21 16:47
ReporterDenisChenu Assigned Topstelling  
PriorityhighSeverityblock 
Status resolvedResolutionfixed 
Product Version4.5.x 
Summary17312: Question type can be updated after activation
DescriptionWhen set Question type selector to Simple : user can update Question type.
This can broke survey
Steps To Reproduce1. My account / My personal settings
2. Question type selector: to Simple
3. Create a survey with a single choice
4. Activate survey
5. Launch :OK it's a signgle choice
6. Update question : set to single choice with comment
7. Launch : set a comment : No error are shown
8. look at data : no comment column **data lost**
9. Update question again
10. Set to array
11. Receive error
12. Launch survey : no way to move
Additional InformationThe are 4 issue here .

1. dropdown is not disabled : this is not a big issue (minor)
2. The question type are update when save : this is a *Broke* issue
3. Some data are lost without information to user (the comment) *Broke* issue #2
4. Invalid survey can be launched
TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)4.6.3
I will donate to the project if issue is resolvedNo
Browsernot relevant ?
Database & DB-Versionnot relevant?
Server OS (if known)not relevant ?
Webserver software & version (if known)not relevant ?
PHP Versionnot relevant ?

Relationships

related to 17310 confirmedgabrieljenik Simple question type selector didn't open with the current question type 

Activities

DenisChenu

DenisChenu

2021-05-18 19:49

developer  

Peek 18-05-2021 19-40.gif (765,240 bytes)
Peek 18-05-2021 19-41.gif (1,077,403 bytes)
DenisChenu

DenisChenu

2021-05-18 19:49

developer   ~64471

@ollehar : broke issue … no ?

I think i already reported about dropdown, didn't find …
ollehar

ollehar

2021-05-19 11:49

administrator   ~64476

Thanks, assigned it to Patricia.
DenisChenu

DenisChenu

2021-05-19 12:15

developer   ~64477

Did need 4 separated issue ?

1. Admin GUI must show disable
2. Model or controller must disable update
3. Must have a way to send error if DB as out of date (i can check what happen in 3.X, but think admin have an email)
4. Must check what happen if question didn't have subquestion (3.X seems to have same issue, but i didn't activate survey), i think we must send and error like when there are no question …
DenisChenu

DenisChenu

2021-05-27 08:58

developer   ~64587

I don't see any update on Version 5.0.0 :

1. Dropdown still not disabled
2. Question type still can be updated
3. And still broken when save
ollehar

ollehar

2021-05-27 12:07

administrator   ~64592

It's not merged yet, I guess.
ollehar

ollehar

2021-05-27 12:07

administrator   ~64593

This is the branch if you wanna check it: task/zoho-L41-T726-question-type-after-activation
pstelling

pstelling

2021-05-28 11:19

developer   ~64617

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31910
DenisChenu

DenisChenu

2021-07-06 13:59

developer   ~65235

@pstelling : MAybe need a PHP control when save ?

See « 2. Model or controller must disable update»
ollehar

ollehar

2021-07-21 16:27

administrator   ~65540

Missing logic on server side?
DenisChenu

DenisChenu

2021-07-21 16:30

developer   ~65541

Yes : seems there are no server side control : on model seems the best ?
ollehar

ollehar

2021-07-21 16:41

administrator   ~65543

The server check is in Question model, beforeSave(). Marking this as fixed.
DenisChenu

DenisChenu

2021-07-21 16:47

developer   ~65544

related commit : https://github.com/LimeSurvey/LimeSurvey/commit/53773e4ff281a144812697059345b88eaee6e8d0

Related Changesets

LimeSurvey: master 956090d0

2021-05-25 08:31:18

pstelling


Committer: ollehar Details Diff
Fixed issue 17312: question type can be be updated after activation (selector simple) Affected Issues
17312
mod - application/extensions/admin/PreviewModalWidget/views/simple_grouped_select.php Diff File
mod - application/extensions/admin/PreviewModalWidget/views/simple_select.php Diff File

Issue History

Date Modified Username Field Change
2021-05-18 19:49 DenisChenu New Issue
2021-05-18 19:49 DenisChenu File Added: Peek 18-05-2021 19-40.gif
2021-05-18 19:49 DenisChenu File Added: Peek 18-05-2021 19-41.gif
2021-05-18 19:49 DenisChenu Note Added: 64471
2021-05-18 19:50 DenisChenu Relationship added related to 17310
2021-05-19 11:49 ollehar Assigned To => pstelling
2021-05-19 11:49 ollehar Status new => assigned
2021-05-19 11:49 ollehar Note Added: 64476
2021-05-19 12:15 DenisChenu Note Added: 64477
2021-05-19 12:42 ollehar Priority none => high
2021-05-19 17:40 ollehar Summary Question type can be updated after activatiin => Question type can be updated after activation
2021-05-26 14:36 ollehar Status assigned => resolved
2021-05-26 14:36 ollehar Resolution open => fixed
2021-05-27 08:58 DenisChenu Note Added: 64587
2021-05-27 08:58 DenisChenu Status resolved => feedback
2021-05-27 08:58 DenisChenu Resolution fixed => reopened
2021-05-27 12:07 ollehar Note Added: 64592
2021-05-27 12:07 ollehar Note Added: 64593
2021-05-28 11:19 ollehar Changeset attached => LimeSurvey master 956090d0
2021-05-28 11:19 pstelling Note Added: 64617
2021-05-28 11:19 pstelling Resolution reopened => fixed
2021-07-06 13:59 DenisChenu Note Added: 65235
2021-07-06 13:59 DenisChenu Status feedback => assigned
2021-07-21 16:27 ollehar Note Added: 65540
2021-07-21 16:30 DenisChenu Note Added: 65541
2021-07-21 16:41 ollehar Note Added: 65543
2021-07-21 16:41 ollehar Status assigned => resolved
2021-07-21 16:47 DenisChenu Note Added: 65544