Relationship Graph

Relationship Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

IDProjectCategoryView StatusLast Update
16504Bug reportsLabel setspublic2020-08-19 09:47
Reporteriqmalik Assigned To 
PrioritynoneSeverityminor 
Status resolvedResolutionopen 
Product Version4.3.3 
Summary16504: Lable Sets Assessment Value Not Copied to Answer options I have created a label set comprising 5 options with assessment value
Description

Lable Sets Assessment Value Not Copied to Answer options

I have created a label set comprising 5 options with assessment values 1, 2, 3, 4, 5.

When I add a question of List (Radio) Type L, select Answer options, predefined label sets, the code and answeroptions rightly appear on the screen. But the assessment value against each entry is displayed as 0. It should display 1, 2, 3, 4, 5 respectively.

I believe it's a bug.

Steps To Reproduce

Mentioned above

TagsNo tags attached.
Complete LimeSurvey version number (& build)I'm using version Version 4.3.3+200707.
I will donate to the project if issue is resolvedNo
BrowserFirefox
Database & DB-VersionMySql
Server OS (if known)
Webserver software & version (if known)
PHP Version7.0.33

Relationships

related to 08529 new Feature requests Using a predefined label set on an array question sets all assessment values to 0 

Activities

iqmalik

iqmalik

2020-07-19 20:59

reporter  

Create Question.png (12,376 bytes)   
Create Question.png (12,376 bytes)   
Label Set Editor.png (26,576 bytes)   
Label Set Editor.png (26,576 bytes)   

user225042

2020-07-20 12:15

  ~58999

Tested, issue exist. Moving it to confirmed

gabrieljenik

gabrieljenik

2020-08-11 23:17

developer   ~59418

Last edited: 2020-08-19 09:47

https://github.com/LimeSurvey/LimeSurvey/pull/1549

In LabelSets.vue, assessment_value was ignored while copying. Now it's copying that value when both the source and target have the assessment_value property.

rjohnson84

rjohnson84

2020-08-12 00:31

reporter   ~59419

Last edited: 2020-08-19 09:47

It appears that sort order is also affected and not copied over.

image.png (6,530 bytes)   
image.png (6,530 bytes)   
rjohnson84

rjohnson84

2020-08-12 00:39

reporter   ~59420

Last edited: 2020-08-19 09:47

Note this seems to only affect export of the survey. Used label sets on my dev environment exported theen imported to production scrambled any question that used label sets.

user225042

2020-08-12 17:02

  ~59448

Last edited: 2020-08-19 09:47

Tested the issue before pulling the PR, Issue exist. Tested the issue after pulling the PR, below are my findings:
Screenshot 1: Before pulling PR the values of assessment code are not copied
Screenshot 2: After pulling PR Assessment code values are copied
Please refer the attachment for more details, working as expected

16504_BeforePR.png (185,029 bytes)
16504_AfterPR.png (67,555 bytes)   
16504_AfterPR.png (67,555 bytes)   
ollehar1

ollehar1

2020-08-18 16:46

reporter   ~59508

Last edited: 2020-08-19 09:47

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30385

Related Changesets

LimeSurvey: master 3c8df805

2020-08-18 16:33:45

ollehar1

Details Diff
Fix issue 16504: Lable Sets Assessment Value Not Copied to Answer options Affected Issues
16504
mod - assets/packages/questioneditor/build.min/js/questionedit.js Diff File
mod - assets/packages/questioneditor/build.min/js/questionedit.js.map Diff File
mod - assets/packages/questioneditor/build/js/questionedit.js Diff File
mod - assets/packages/questioneditor/build/js/questionedit.js.map Diff File
mod - assets/packages/questioneditor/src/helperComponents/LabelSets.vue Diff File

Issue History

Date Modified Username Field Change
2020-07-19 20:59 iqmalik New Issue
2020-07-19 20:59 iqmalik File Added: Create Question.png
2020-07-19 20:59 iqmalik File Added: Label Set Editor.png
2020-07-20 12:13 user225042 Relationship added related to 08529
2020-07-20 12:15 user225042 Note Added: 58999
2020-07-20 12:16 user225042 Status new => confirmed
2020-08-11 23:17 gabrieljenik Note Added: 59418
2020-08-12 00:31 rjohnson84 Note Added: 59419
2020-08-12 00:31 rjohnson84 File Added: image.png
2020-08-12 00:39 rjohnson84 Note Added: 59420
2020-08-12 17:02 user225042 Note Added: 59448
2020-08-12 17:02 user225042 File Added: 16504_BeforePR.png
2020-08-12 17:02 user225042 File Added: 16504_AfterPR.png
2020-08-18 16:46 ollehar1 Changeset attached => LimeSurvey master 3c8df805
2020-08-18 16:46 ollehar1 Note Added: 59508
2020-08-19 09:47 swendrich Status confirmed => resolved