3.0.0-beta.2 : db version 309

I set up a SQL server profiler trace - the funny thing is no update statements are performed but somehow an exception is thrown resulting in a transaction rollback. See screen shot from profiler.

I fixed it by rewriting lines 118-122 in updatedb_helper.php:
if ($iOldDBVersion < 290) {

        $oTransaction = $oDB->beginTransaction();

        // Loop all surveys
        $surveys = Survey::model()->findAll();
        foreach ($surveys as $survey)
        {
            $prefix = Yii::app()->getDb()->tablePrefix;
            $tableName = $prefix . 'survey_' . $survey->sid;
        .... etc.   

to:

    if ($iOldDBVersion < 290) {

        $oTransaction = $oDB->beginTransaction();

        // Loop all surveys
                $surveyquery = "SELECT sid FROM ".dbQuoteID('{{surveys}}');
                $surveyids = Yii::app()->db->createCommand($surveyquery)->queryAll();
                foreach ( $surveyids as $surv )
         {
            $prefix = Yii::app()->getDb()->tablePrefix;
            $tableName = $prefix . 'survey_' . $surv['sid'];
          etc.........

Now I'm getting stuck in : function createSurveyMenuTable293($oDB):
$oDB->createCommand()->createTable('{{surveymenu}}', array(
"id" => "int NOT NULL AUTO_INCREMENT",
"parent_id" => "int DEFAULT NULL",
"survey_id" => "int DEFAULT NULL",
"order" => "int DEFAULT '0'",
"level" => "int DEFAULT '0'",
"title" => "character varying(255) NOT NULL DEFAULT ''",
"description" => "text ",
"changed_at" => "timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP",
.........
"AUTO_INCREMENT" is not valid in ms-sql, IDENTITY should be used.
"timestamp" is not a valid data type in ms-sql - I think datetime should be used.
"ON UPDATE " can not be used this way in ms-sql, a separate trigger has to be defined for this functionality. See: https://stackoverflow.com/questions/22594567/sql-server-on-update-set-current-timestamp.

'MEDIUMTEXT' is not a valid ms-sql datatype (creating tables templates & template_configuration) ...

I'd appreciate some developer feedback on the changes I made to updatedb.helper.php to get it working with ms-sql. See attachment... Thx!

I don't like to use dbQuoteID (and here , it's a table name).

Did you try with
$surveyids = Yii::app()->db->createCommand("SELECT sid FROM {{surveys}}")->queryAll();

Or :
$aSurveyId=Yii::app()->db->createCommand()
->select('sid')
->from('{{surveys}}')
->queryAll();

PS : best is to offer the pull request directly on github :)

Hi Denis,
I'm not a developer, just trying to find out what's happening (and what should be happening maybe...).
But thanks for looking into this.
I think the create-mssql.sql script should be updated as well to get rid of the errors.

You're right about create-mssql.sql .
For “I'm not a developer” : with FOSS : everyione can be a developper ;).

I fix the specific issue with oSurvey, but unsure about the other update : Carsten already update some part.

I can't even install the release versions of 3.00 beta 1-3 on MSSQL or Postgres so there will be no fix for these databases.

@c_schmitz : i try (because i need one for testing)
2.6lts to 2.71
2.71 to 3.0RC.

I think the Survey model call broke, but i make a test. Do you know the upgradeTemplateTables298 function , it seems really strange

I did two fixes for MySQL (see changesets below) and tested the updates from beta1 to beta 3 now. Will test from stable to beta (latest develop) tomorrow.

Update this morning from 2.6lts to last GIT : OK :)

3.0.0-RC1 Build 171025 released