View Issue Details

Jump to NotesJump to History
This issue affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
09939Bug reportsSurvey editingpublic2015-10-02 12:262015-12-15 14:28
ReporterDenisChenu Assigned Toollehar  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary09939: Admin can submit invalid question
Description

User can submit invalid question, even with HTML5 in form

Steps To Reproduce

Update a question :

  • set title to [empty] (for example), but same with : only number or existing code.
  • Update text

Click on Save :
Return back : with : nothing was updated + error:
"La question n'a pas pu être mise à jour suite à l'erreur de title: Title ne peut être vide. "

Additional Information

The question title have 'required' and pattern attribute : then "submit" the form show HTML5 validation error.
But Save button is out of form, not submit the form. But doing submit in js.

To fix this bug you can : create a submit button, and simulated a click.
But think it's better to have a real submit button and simulate a click on it.

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)021115
I will donate to the project if issue is resolvedNo
Browserfirefox
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

Relationship GraphDependency Graph
related to 09935 closedLouisGac Save/Save and return : must be after the form 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2015-10-02 12:29

developer   ~33299

Last edited: 2015-10-02 12:32

See https://github.com/LimeSurvey/LimeSurvey/commit/da2becb35db51d1dfffae56e3e1de124f0a0f1b8
and
https://github.com/LimeSurvey/LimeSurvey/commit/2c0a176e9e801b7bc4b620e1d2c1b9175519ef9e

We have a lot of forum post for this issues when update to 2.05
ollehar

ollehar

2015-12-14 16:48

administrator   ~33912

Is this 2.5 or 2.05?
ollehar

ollehar

2015-12-14 16:49

administrator   ~33913

Need info.
DenisChenu

DenisChenu

2015-12-14 17:11

developer   ~33916

Last edited: 2015-12-14 17:13

2.50

Update a question :

  • set title to [empty] (for example) or 1234 but same with : only number or existing code.
  • Update text

Click on "Save at top" : HTML5 validity don't happen because form is submitted without button.
HTML5 validity happen only : if a submit button is clicked or if javascript check the validity before submit.

The form is shown (or not) again with:

  • Old title : OK
  • Old text : NOT ok.
DenisChenu

DenisChenu

2015-12-15 14:28

developer   ~33956

OK fixed

Issue History

Date Modified Username Field Change
2015-10-02 12:26 DenisChenu New Issue
2015-10-02 12:26 DenisChenu Relationship added related to 09935
2015-10-02 12:27 DenisChenu Steps to Reproduce Updated
2015-10-02 12:29 DenisChenu Note Added: 33299
2015-10-02 12:32 DenisChenu Note Edited: 33299
2015-12-11 16:47 c_schmitz Status new => assigned
2015-12-11 16:47 c_schmitz Assigned To => LouisGac
2015-12-14 16:45 ollehar Assigned To LouisGac => ollehar
2015-12-14 16:48 ollehar Note Added: 33912
2015-12-14 16:49 ollehar Note Added: 33913
2015-12-14 16:49 ollehar Status assigned => feedback
2015-12-14 17:11 DenisChenu Note Added: 33916
2015-12-14 17:11 DenisChenu Status feedback => assigned
2015-12-14 17:13 DenisChenu Note Edited: 33916
2015-12-15 14:28 DenisChenu Note Added: 33956
2015-12-15 14:28 DenisChenu Status assigned => closed
2015-12-15 14:28 DenisChenu Resolution open => fixed
2015-12-15 14:28 DenisChenu Fixed in Version => 2.5
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing