View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
09845Bug reportsSurvey takingpublic2015-08-27 09:572015-09-30 11:01
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.06+ 
Fixed in Version2.06+ 
Summary09845: Map question with OSM + combineJs error
Description

With a Map question with OSM and combineJs at true (debug=0) : there are a javascript error. Breaking clic on map and search town.

Steps To Reproduce

Import included lss,
Test with debug=2 (or combineJs to false) : OK
Test with debug=0 (or combineJs to true) : KO

Concole.log :
Error: Couldn't autodetect L.Icon.Default.imagePath, set it manually.
http://limesurvey.sondages.pro/tmp/assets/5f723cf9/c_14a0329813fba746f2d157171f01cb2b.js
Line 27

Additional Information

combineJs can be forced with :
'clientScript'=>array(
'combineJs'=>true,
),

I think we need to try with combineCss/compressJs and compressCss when we found times ;)

It's after jquery-ui touch, something with comment broken ? I try with a newline at end of touch-puch : broken too .

Then adding 2 newlines at start of survey-runtime : broken too ....

No other idea actually ....

TagsNo tags attached.
Attached Files
limesurvey_survey_cartoOsm.lss (12,290 bytes)
Bug heat4
Complete LimeSurvey version number (& build)150827
I will donate to the project if issue is resolvedNo
Browserfirefox
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant ?

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2015-08-27 10:19

developer   ~33017

Last edited: 2015-08-27 15:00

Tested with:

    'clientScript'=>array(
        'combineJs'=>true,
        'compressJs'=>false,
        'excludeFiles'=>array(
          '/third_party/leaflet/leaflet.js',
          '/scripts/map.js',
        ),
    ),

It's OK , bust must review if we need sub directory or not in exclude files .
MAP is not used a lot : then excluding it is a good idea.

Maybe exclude specific files (for some question type etc ...)

PS : Broken with subdirectory
DenisChenu

DenisChenu

2015-08-27 15:46

developer   ~33021

https://github.com/LimeSurvey/LimeSurvey/pull/362 To be tested (quick test, particuallary for IIS and nginx)
DenisChenu

DenisChenu

2015-08-29 10:51

developer   ~33032

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15822
DenisChenu

DenisChenu

2015-08-29 10:56

developer   ~33033

To be reworked for 3.0 (Question object) : move map to Plugin ?
c_schmitz

c_schmitz

2015-09-30 11:01

administrator   ~33233

Version 2.06+ Build 150930 released

Related Changesets

LimeSurvey: master 5dea80a5

2015-08-29 10:51

DenisChenu


Details Diff		 Fixed issue 09845: Map question with OSM + combineJs error
Dev: leaflet don't like compression, don't know why
Dev: leaflet/map.js are used only one time in each survey, then can be removed from compression
Dev: Need a generic function ?		 Affected Issues
09845
mod - application/config/internal.php Diff File
mod - application/helpers/qanda_helper.php Diff File

Issue History

Date Modified Username Field Change
2015-08-27 09:57 DenisChenu New Issue
2015-08-27 09:57 DenisChenu File Added: limesurvey_survey_cartoOsm.lss
2015-08-27 09:59 DenisChenu Steps to Reproduce Updated
2015-08-27 10:13 DenisChenu Additional Information Updated
2015-08-27 10:19 DenisChenu Note Added: 33017
2015-08-27 15:00 DenisChenu Note Edited: 33017
2015-08-27 15:46 DenisChenu Note Added: 33021
2015-08-29 10:46 DenisChenu Assigned To => DenisChenu
2015-08-29 10:46 DenisChenu Status new => confirmed
2015-08-29 10:51 DenisChenu Changeset attached => LimeSurvey master 5dea80a5
2015-08-29 10:51 DenisChenu Note Added: 33032
2015-08-29 10:51 DenisChenu Resolution open => fixed
2015-08-29 10:56 DenisChenu Note Added: 33033
2015-08-29 10:56 DenisChenu Status confirmed => resolved
2015-08-29 10:56 DenisChenu Fixed in Version => 2.06+
2015-09-30 11:01 c_schmitz Note Added: 33233
2015-09-30 11:01 c_schmitz Status resolved => closed