View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
09413Bug reportsPrint Viewpublic2014-12-16 15:002014-12-29 15:33
Reportergabrieljenik Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Target Version2.50.x 
Summary09413: Answer printing code tight dependency with survey setting "Participant may print answers"
Description

The code at PrintanswersController.php have a tight dependency with the "Participant may print answers" setting at survey level.

That dependency doesn't encourage code resuability.

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)14052014
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL 5
Server OS (if known)Ubunut
Webserver software & version (if known)Apache
PHP VersionPHP Version 5.4.4

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2014-12-16 15:21

manager   ~31265

Master branch >>

Commit: https://github.com/gabrieljenik/LimeSurvey/commit/52828bb9515299814aa83679dbff8d82b8fa30e1

Pull request: https://github.com/LimeSurvey/LimeSurvey/pull/261

V2.06 branch >>

Commit: https://github.com/gabrieljenik/LimeSurvey/commit/2d354631f5e1f324f786e1c413e9ac428bb7b061

Pull request: https://github.com/LimeSurvey/LimeSurvey/pull/262
gabrieljenik

gabrieljenik

2014-12-16 15:21

manager   ~31266

Do not exit controller if user has read permissions over responses.
As so allow to print if setting "Participant may print answers" is set to true or if user has read permission over responses.
c_schmitz

c_schmitz

2014-12-19 09:11

administrator   ~31307

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14761
c_schmitz

c_schmitz

2014-12-19 09:11

administrator   ~31308

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14764
c_schmitz

c_schmitz

2014-12-29 15:33

administrator   ~31372

Version 2.05 Build 141229 released

Related Changesets

LimeSurvey: master e7eae64c

2014-12-19 09:11

c_schmitz


Details Diff		 Merge pull request #261 from gabrieljenik/patch-6

Fixed issue 09413 - Let print answer if user can read responses.		 Affected Issues
09413
mod - application/controllers/PrintanswersController.php Diff File

LimeSurvey: 2.06 7956ca9c

2014-12-19 09:11

c_schmitz


Details Diff		 Merge pull request #262 from gabrieljenik/patch-7

Fixed issue 09413 - Let print answer if user can read responses.		 Affected Issues
09413
mod - application/controllers/PrintanswersController.php Diff File

Issue History

Date Modified Username Field Change
2014-12-16 15:00 gabrieljenik New Issue
2014-12-16 15:00 gabrieljenik Status new => assigned
2014-12-16 15:00 gabrieljenik Assigned To => gabrieljenik
2014-12-16 15:21 gabrieljenik Note Added: 31265
2014-12-16 15:21 gabrieljenik Note Added: 31266
2014-12-16 15:22 gabrieljenik Status assigned => resolved
2014-12-16 15:22 gabrieljenik Resolution open => fixed
2014-12-19 09:11 c_schmitz Changeset attached => LimeSurvey master e7eae64c
2014-12-19 09:11 c_schmitz Note Added: 31307
2014-12-19 09:11 c_schmitz Assigned To gabrieljenik => c_schmitz
2014-12-19 09:11 c_schmitz Changeset attached => LimeSurvey 2.06 7956ca9c
2014-12-19 09:11 c_schmitz Note Added: 31308
2014-12-29 15:33 c_schmitz Note Added: 31372
2014-12-29 15:33 c_schmitz Status resolved => closed