View Issue Details

IDProjectCategoryView StatusLast Update
08931DevelopmentExpression Managerpublic2026-11-20 18:15
ReporterDenisChenu Assigned To 
PrioritynormalSeverityminor 
Status acknowledgedResolutionopen 
Summary08931: Use 'view' in Expression Manager file (survey logic file)
Description

Survey Logic File use 'hard encoded HTML'.

THink it's best for future evolution to use view

Additional Information

Think we need:

  • header view (for all survey logic file)

  • footer view

  • Survey start

  • Here maybe a view for all line ( can be extended after ?)

  • Group start

  • question

  • group end

  • survey end

And surely a lot more ....

TagsNo tags attached.

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2026-11-20 18:15

administrator   ~87861

Current state (master, November 2026): Still valid. The survey logic file is still built as hard-coded HTML strings.

  • LimeExpressionManager::ShowSurveyLogicFile() in application/helpers/expressions/em_manager_helper.php is about 700 lines long. It concatenates all the markup itself: page title and table, survey text rows, group rows, question rows, subquestion rows, answer rows and the nested question attribute table.
  • Only the status alerts at the top are rendered through a widget (AlertWidget).
  • The view application/views/admin/expressions/test/survey_logic_file.php exists, but it only wraps the finished HTML string.

A refactoring has to keep these things stable:

  • REST API: application/libraries/Api/Command/V1/SurveyLogic.php returns the same HTML to the new editor, which styles it in editor/src/themes/survey-logic/survey-logic-modal.scss.
  • CSS classes: LEMgroup, LEMquestion, LEMsubq, LEManswer, logicfiletable and logicfileattributetable are used by the Sea_Green admin theme and by assets/styles-public/expressionlogicfile.css.
  • Tests: seven unit tests in tests/unit/helpers/SurveyLogicFile*Test.php and the functional test ExpressionWarningsOnLogicTest check the output.
  • Rendering context: the function is static and is called from the admin controller (Expressions) and from the REST command.

This changes no behaviour, so it is a refactoring task and was moved to the Development project.

Issue History

Date Modified Username Field Change
2014-04-02 10:38 DenisChenu New Issue
2026-11-19 22:50 c_schmitz Status new => acknowledged
2026-11-20 18:15 c_schmitz Project Bug reports => Development
2026-11-20 18:15 c_schmitz Product Version 2.05 =>
2026-11-20 18:15 c_schmitz Note Added: 87861