View Issue Details

This issue affects 1 person(s).
 2
IDProjectCategoryView StatusLast Update
08811Bug reportsSurvey editingpublic2026-11-20 18:18
ReporterDenisChenu Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status resolvedResolutionfixed 
Summary08811: Add a file name validation by extension in some 'choose file' input
Description

Just an idea : but some file input must be restricted by file name extension. We can d it in javascript.

Steps To Reproduce

When importing question (.lsq/.csv) : the actual javascript only test if file is empty or not.

Additional Information

Actual js is easiliy replaced by HTML5/required.

HTML5 accept too accept attribute : http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-input-accept
But this one don't work good with extension (tested on FF27/linux : no control).
But we can validate extension in javascript and send an error before submit.

some .on test : if $("input:file[accept]"){
//do the test
// return true/false
}

TagsNo tags attached.
Bug heat2
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version
Git branch / Pull Request URL

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2026-11-20 18:18

administrator   ~87862

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=41396

Related Changesets

LimeSurvey: master c3d93291

2014-03-05 12:35

DenisChenu


Details Diff
Fixed issue 08810: When importing a question entering a question code is required which doesn't make sense
Dev: better jquery selector : restrict to submit on frmeditquestion ...
Dev: add required to the_file : uneeded script validatefilename but leave it for dumb browser
Dev: add HTML5/accept : not really used actually : but idea for a new global script
Affected Issues
08810, 08811
mod - application/views/admin/survey/Question/editQuestion_view.php Diff File
mod - scripts/admin/questions.js Diff File

LimeSurvey: master 63a0c6ff

2026-11-20 18:18

c_schmitz


Details Diff
Fixed issue 08811: Importing without choosing a file did nothing and showed no message, and some import dialogs offered files of every type
Dev LS.validatefilename now shows its message at the file input through the browser's form validation
Dev Added accept and required to the file inputs for survey resources, label set resources, role import and the theme upload form
Affected Issues
08811
mod - application/views/admin/labels/_labelviewrightcontent_view.php Diff File
mod - application/views/admin/survey/subview/import_ressources_modal.php Diff File
mod - application/views/admin/themes/importform_view.php Diff File
mod - application/views/surveyAdministration/tabImport_view.php Diff File
mod - application/views/userRole/partials/_import.php Diff File
mod - assets/packages/adminbasics/build/adminbasics.js Diff File
mod - assets/packages/adminbasics/build/adminbasics.min.js Diff File
mod - assets/packages/adminbasics/src/parts/globalMethods.js Diff File

Issue History

Date Modified Username Field Change
2014-03-05 12:41 DenisChenu New Issue
2014-03-05 12:42 DenisChenu Changeset attached => LimeSurvey master c3d93291
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing
2026-11-19 22:50 c_schmitz Status new => acknowledged
2026-11-20 18:18 c_schmitz Changeset attached => LimeSurvey master 63a0c6ff
2026-11-20 18:18 c_schmitz Note Added: 87862
2026-11-20 18:18 c_schmitz Assigned To => c_schmitz
2026-11-20 18:18 c_schmitz Status acknowledged => resolved
2026-11-20 18:18 c_schmitz Resolution open => fixed
2026-11-20 18:18 c_schmitz Bug heat 0 => 2