View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
08362Bug reportsImport/Exportpublic2013-11-24 19:05
Reportermfaber Assigned Toadamzammit  
PrioritynormalSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.05 RC 
Target Version2.05+Fixed in Version2.00+ 
Summary08362: quexf-pdf export: text ends abruptly after &-sign
Description

When the "&"-character is used in an answer category, the text ends there in the quexml-pdf.

Example: "Banana & Cherry" becomes "Banana" in the pdf.

Steps To Reproduce

quexf-pdf export the attached lss-file
have a look at the answer categories in the pdf

TagsNo tags attached.
Attached Files
exportbug.lss (18,126 bytes)
Bug heat8
Complete LimeSurvey version number (& build)131112
I will donate to the project if issue is resolvedNo
BrowserFF
Database type & versionMySQL 5.0.10
Server OS (if known)Win7
Webserver software & version (if known)Apache/2.4.3 (Win32)
PHP VersionPhP 5.4.7

Users monitoring this issue

adamzammit

Activities

mfaber

mfaber

2013-11-12 19:58

reporter   ~27179

When switching on debug mode in limesurvey, the following warning appears:

PHP warning

DOMDocument::createElement(): unterminated entity reference Banana

E:\survey\htdocs\github\LimeSurvey\application\helpers\export_helper.php(1113)

1101 {
1102 global $dom;
1103 global $quexmllang ;
1104
1105 if ($use_answers)
1106 $Query = "SELECT answer as question, code as title FROM {{answers}} WHERE qid = $qid AND language='$quexmllang' ORDER BY sortorder ASC";
1107 else
1108 $Query = "SELECT * FROM {{questions}} WHERE parent_qid = $qid and scale_id = 0 AND language='$quexmllang' ORDER BY questionorder ASC";
1109 $QueryResult = Yii::app()->db->createCommand($Query)->query();
1110 foreach($QueryResult->readAll() as $Row)
1111 {
1112 $subQuestion = $dom->createElement("subQuestion");
1113 $text = $dom->createElement("text",QueXMLCleanup($Row['question'],''));
1114 $subQuestion->appendChild($text);
1115 $subQuestion->setAttribute("varName",$varname .'
'. QueXMLCleanup($Row['title']));
1116 $question->appendChild($subQuestion);
1117 }
1118
1119 return;
1120 }
1121
1122 /*
1123
Export quexml survey.
1124 */
1125 function quexml_export($surveyi, $quexmllan)

Stack Trace
#0

E:\survey\htdocs\github\LimeSurvey\application\helpers\export_helper.php(1113): DOMDocument->createElement("text", "Cherry & Banana")

1108 $Query = "SELECT * FROM {{questions}} WHERE parent_qid = $qid and scale_id = 0 AND language='$quexmllang' ORDER BY questionorder ASC";
1109 $QueryResult = Yii::app()->db->createCommand($Query)->query();
1110 foreach($QueryResult->readAll() as $Row)
1111 {
1112 $subQuestion = $dom->createElement("subQuestion");
1113 $text = $dom->createElement("text",QueXMLCleanup($Row['question'],''));
1114 $subQuestion->appendChild($text);
1115 $subQuestion->setAttribute("varName",$varname .'
'. QueXMLCleanup($Row['title']));
1116 $question->appendChild($subQuestion);
1117 }
1118

#1

E:\survey\htdocs\github\LimeSurvey\application\helpers\export_helper.php(1412): quexml_create_subQuestions(DOMElement, "9028", "arrayquestion")

1407 $response->appendChild(QueXMLFixedArray(array($qlang->gT("Increase") => 'I',$qlang->gT("Same") => 'S',$qlang->gT("Decrease") => 'D')));
1408 $question->appendChild($response);
1409 break;
1410 case "F": //ARRAY (Flexible) - Row Format
1411 //select subQuestions from answers table where QID
1412 quexml_create_subQuestions($question,$qid,$sgq);
1413 $response->appendChild(QueXMLCreateFixed($qid,false,false,0,$other,$sgq));
1414 $question->appendChild($response);
1415 //select fixed responses from
1416 break;
1417 case "H": //ARRAY (Flexible) - Column Format

#2

E:\survey\htdocs\github\LimeSurvey\application\controllers\admin\export.php(794): quexml_export("324882", "en")

789
790 set_time_limit(120);
791
792 $noheader = TRUE;
793
794 $quexml = quexml_export($iSurveyID, $surveyprintlang);
795
796 $quexmlpdf->create($quexmlpdf->createqueXML($quexml));
797
798 //NEED TO GET QID from $quexmlpdf
799 $qid = intval($quexmlpdf->getQuestionnaireId());

adamzammit

adamzammit

2013-11-22 03:02

developer   ~27306

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13486

mfaber

mfaber

2013-11-22 23:25

reporter   ~27336

works! thanks, Adam!

mfaber

mfaber

2013-11-22 23:29

reporter   ~27337

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13498

mfaber

mfaber

2013-11-22 23:30

reporter   ~27338

cherry-picked this fix to 2.00+

c_schmitz

c_schmitz

2013-11-24 19:05

administrator   ~27343

2.00+ Build 131122 released

Related Changesets

LimeSurvey: 2.05 b4673af5

2013-11-22 02:00:17

adamzammit

Details Diff
Fixed issue 08362: quexf-pdf export: text ends abruptly after &-sign Affected Issues
08362
mod - application/helpers/export_helper.php Diff File

LimeSurvey: master 04e5965f

2013-11-22 02:00:17

mfaber


Committer: mfaber Details Diff
Fixed issue 08362: quexf-pdf export: text ends abruptly after &-sign Affected Issues
08362
mod - application/helpers/export_helper.php Diff File

Issue History

Date Modified Username Field Change
2013-11-12 19:54 mfaber New Issue
2013-11-12 19:55 mfaber Issue Monitored: adamzammit
2013-11-12 19:55 mfaber File Added: exportbug.lss
2013-11-12 19:58 mfaber Note Added: 27179
2013-11-21 00:11 c_schmitz Assigned To => adamzammit
2013-11-21 00:11 c_schmitz Status new => assigned
2013-11-22 03:02 adamzammit Changeset attached => LimeSurvey 2.05 b4673af5
2013-11-22 03:02 adamzammit Note Added: 27306
2013-11-22 03:02 adamzammit Resolution open => fixed
2013-11-22 11:28 c_schmitz Target Version 2.05 RC => 2.05+
2013-11-22 23:25 mfaber Note Added: 27336
2013-11-22 23:29 mfaber Changeset attached => LimeSurvey master 04e5965f
2013-11-22 23:29 mfaber Note Added: 27337
2013-11-22 23:29 mfaber Assigned To adamzammit => mfaber
2013-11-22 23:30 mfaber Note Added: 27338
2013-11-22 23:30 mfaber Status assigned => resolved
2013-11-22 23:30 mfaber Fixed in Version => 2.00+
2013-11-22 23:30 mfaber Assigned To mfaber => adamzammit
2013-11-24 19:05 c_schmitz Note Added: 27343
2013-11-24 19:05 c_schmitz Status resolved => closed
2021-08-03 18:20 guest Bug heat 6 => 8