View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
08107Bug reportsOtherpublic2013-10-22 15:33
ReporterDeveloperChris Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Fixed in Version2.00+ 
Summary08107: poor error message when user loads previously saved survey
Description

If a user attempts to load a previously saved survey and enters the wron information the get a curt message

"There is no matching saved survey" on a blank white page

Version 1.9+ seems to work correctly with the error message displayed on the resume form

Steps To Reproduce

using the latest version 2+ enter invalid credentials when loading a saved survey

Additional Information

git patch to fix this issue

diff --git a/public_html/application/controllers/survey/index.php b/public_html/application/controllers/survey/index.php
index 11daa67..2165beb 100644
--- a/public_html/application/controllers/survey/index.php
+++ b/public_html/application/controllers/survey/index.php
@@ -431,8 +431,13 @@ class index extends CAction {
$SESSION['survey'.$surveyid]['holdname'] = $param['loadname']; //Session variable used to load answers every page.
$SESSION['survey'.$surveyid]['holdpass'] = $param['loadpass']; //Session variable used to load answers every page.

  • if ($errormsg == "") loadanswers();
  • $move = "movenext";
  • if ($errormsg == "") {
  • if (loadanswers()){
  • $move = "movenext";
  • } else {
  • $errormsg .= $clang->gT("There is no matching saved survey");
  • }
  • }

         if ($errormsg)
         {

    diff --git a/public_html/application/helpers/frontend_helper.php b/public_html/application/helpers/frontend_helper.php
    index 558f529..b94045e 100644
    --- a/public_html/application/helpers/frontend_helper.php
    +++ b/public_html/application/helpers/frontend_helper.php
    @@ -52,7 +52,7 @@
    $aRow = Yii::app()->db->createCommand($query)->queryRow();
    if (!$aRow)
    {

  • safeDie($clang->gT("There is no matching saved survey")."<br />\n");
  • //safeDie($clang->gT("There is no matching saved survey")."<br />\n");
    return false;
    }
    else
TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version

Users monitoring this issue

There are no users monitoring this issue.

Activities

mdekker

mdekker

2013-09-03 09:58

reporter   ~26133

You you please do a pull request for this?

c_schmitz

c_schmitz

2013-10-11 12:23

administrator   ~26719

Pretty please?

c_schmitz

c_schmitz

2013-10-20 01:08

administrator   ~26844

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=13275

c_schmitz

c_schmitz

2013-10-20 01:11

administrator   ~26845

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=13276

DeveloperChris

DeveloperChris

2013-10-20 23:58

reporter   ~26856

Hi

Good to see you were able to implement the fix. Sorry I haven't been very responsive. I tend to shift project to project very quickly and find it difficult to revisit finished work.

Although I have visited github on occasion I haven't used it in anger. I now see I need to fork the project to create a pull request. at first I thought you meant to pull it from my repo which I can't do due to firewalls.

I'll try to do better in the future.
Chris

c_schmitz

c_schmitz

2013-10-22 15:33

administrator   ~26910

Version 2.00+ Build 131022 released.

Related Changesets

LimeSurvey: master a5e11ee1

2013-10-19 23:07:30

c_schmitz

Details Diff
Fixed issue 08107: Poor error message when user loads previously saved survey Affected Issues
08107
mod - application/controllers/survey/index.php Diff File
mod - application/helpers/frontend_helper.php Diff File

LimeSurvey: 2.05 f382b4b2

2013-10-19 23:10:49

c_schmitz

Details Diff
Fixed issue 08107: Poor error message when user loads previously saved survey Affected Issues
08107
mod - application/controllers/survey/index.php Diff File
mod - application/helpers/frontend_helper.php Diff File

Issue History

Date Modified Username Field Change
2013-08-22 04:08 DeveloperChris New Issue
2013-09-03 09:57 mdekker Project Development => Bug reports
2013-09-03 09:57 mdekker Category Usability => Other issues
2013-09-03 09:58 mdekker Note Added: 26133
2013-10-11 12:23 c_schmitz Note Added: 26719
2013-10-11 12:23 c_schmitz Assigned To => c_schmitz
2013-10-11 12:23 c_schmitz Status new => feedback
2013-10-20 01:08 c_schmitz Status feedback => resolved
2013-10-20 01:08 c_schmitz Fixed in Version => 2.00+
2013-10-20 01:08 c_schmitz Resolution open => fixed
2013-10-20 01:08 c_schmitz Changeset attached => LimeSurvey master a5e11ee1
2013-10-20 01:08 c_schmitz Note Added: 26844
2013-10-20 01:11 c_schmitz Changeset attached => LimeSurvey 2.05 f382b4b2
2013-10-20 01:11 c_schmitz Note Added: 26845
2013-10-20 23:58 DeveloperChris Note Added: 26856
2013-10-22 15:33 c_schmitz Note Added: 26910
2013-10-22 15:33 c_schmitz Status resolved => closed