View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
08059Bug reportsTheme editorpublic2013-11-25 15:40
ReporterDenisChenu Assigned Tosammousa  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05 RC 
Target Version2.05+Fixed in Version2.05+ 
Summary08059: Template editor register js and css file from template
Description

Public template register js and css file, it's shown in iframe then must be without problem. But Yii put template.css and template.js in admin part

Steps To Reproduce

It's for all template but some citronade use #wrapper in template.css then it's very clear.

All other have same issue :

Additional Information

seems to have bootstrap.js in iframe too: public survey take js and css from admin too.

TagsNo tags attached.
Attached Files
Capture.png (73,825 bytes)   
Capture.png (73,825 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)130731
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

parent of 08189 closedc_schmitz .dialog is not a function in template editor 
parent of 08378 closedDenisChenu Copying a template does nothing 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2013-08-22 11:39

developer   ~26046

Uploaded 2 screenshot :
1st : citronade: clearly broken
2nd : No js for button (and some style are broken too)

And look at "iframe source" you find admin_core.js

sammousa

sammousa

2013-09-25 10:29

reporter   ~26359

The error is caused by line 619 in templates.php:
App()->getClientScript()->render($myoutput);

In AdminController.php we incorrectly register the javascript in the init function. This should instead be done in the view or layout.

DenisChenu

DenisChenu

2013-09-25 10:36

developer   ~26360

Myabe we have to do some "wiki" for all of this specificty ;).

ACtually : it's better to register script in view ? Right ?

DenisChenu

DenisChenu

2013-10-11 14:38

developer   ~26727

Hi sammousa : even with removing this line , i have same problem.

Doing it like this:
//@$fnew = fopen("$tempdir/templatetemp$time.html", "w+");
$fnew=false;

Attch the new screen capture.

Seems to be rendering on public survey ?

DenisChenu

DenisChenu

2013-10-13 21:45

developer   ~26768

PS: and try with replace all render by renderPartial for quick fix too ( the $fnew=false + renderPartial).

No fix

sammousa

sammousa

2013-11-13 11:48

reporter   ~27181

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13444

DenisChenu

DenisChenu

2013-11-13 12:02

developer   ~27182

Arrggg ...don't know reset !

Great, thanks !

c_schmitz

c_schmitz

2013-11-25 15:40

administrator   ~27391

2.05RC7 released

Related Changesets

LimeSurvey: 2.05 d8fdf83e

2013-11-13 10:47:26

sammousa

Details Diff
Fixed issue 08059: Template editor register js and css file from template Affected Issues
08059
mod - application/controllers/admin/templates.php Diff File

Issue History

Date Modified Username Field Change
2013-07-31 00:22 DenisChenu New Issue
2013-08-22 11:36 DenisChenu File Added: Capture du 2013-08-22 11:35:44.png
2013-08-22 11:37 DenisChenu File Added: Capture du 2013-08-22 11:36:15.png
2013-08-22 11:37 DenisChenu Assigned To => sammousa
2013-08-22 11:37 DenisChenu Status new => assigned
2013-08-22 11:39 DenisChenu Note Added: 26046
2013-09-25 10:05 DenisChenu Relationship added parent of 08189
2013-09-25 10:29 sammousa Note Added: 26359
2013-09-25 10:36 DenisChenu Note Added: 26360
2013-10-11 14:38 DenisChenu Note Added: 26727
2013-10-11 14:41 DenisChenu File Added: Capture.png
2013-10-13 21:45 DenisChenu Note Added: 26768
2013-11-13 11:48 sammousa Changeset attached => LimeSurvey 2.05 d8fdf83e
2013-11-13 11:48 sammousa Note Added: 27181
2013-11-13 11:48 sammousa Resolution open => fixed
2013-11-13 11:48 sammousa Status assigned => resolved
2013-11-13 12:02 DenisChenu Note Added: 27182
2013-11-17 12:17 DenisChenu Relationship added parent of 08378
2013-11-22 11:28 c_schmitz Target Version 2.05 RC => 2.05+
2013-11-25 15:40 c_schmitz Fixed in Version => 2.05+
2013-11-25 15:40 c_schmitz Note Added: 27391
2013-11-25 15:40 c_schmitz Status resolved => closed
2015-12-11 14:40 c_schmitz Category Templates => Theme editor