View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
08056Bug reportsConditionspublic2013-09-23 13:27
Reporterjonsen Assigned ToDenisChenu  
PrioritynormalSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.00+ 
Fixed in Version2.00+ 
Summary08056: "Other" text entry does not trigger filter
Description

This also applies for 2.00+ Build 20130611

When filtereing based on an "other" entry, the filter is only applied when clicking the radio button, not when directly entering a text in the "other" text input.

(The workaround is to make an additional question where the information that used to be in the "other" field is collected.)

Steps To Reproduce

a) Import the attached survey

OR

b)

  1. Make a question a01 with an "other" option
  2. Make a question a02 with a filter "show only if question 1 == 'other'"
  3. Enter something into the "other" field of a01 without clicking the radio button and/or its label
  4. Observe that question a02 is not displayed
TagsNo tags attached.
Attached Files
Bug heat8
Complete LimeSurvey version number (& build)130708
I will donate to the project if issue is resolvedNo
BrowserMozilla Firefox 22.0
Database type & versionMySQL 5.1
Server OS (if known)Debian, Kernel 2.6.32-5-amd64
Webserver software & version (if known)Apache 2.x
PHP Version5.3.3-7+squeeze16

Users monitoring this issue

There are no users monitoring this issue.

Activities

sammousa

sammousa

2013-07-30 14:42

reporter   ~25889

Shouldn't you instead be checking for: !empty(q1other)

As far as I know that's the proper way to check.

jonsen

jonsen

2013-07-30 15:07

reporter   ~25891

Last edited: 2013-07-30 15:36

@sammousa
Sorry, I wasn't precise here. I am talking about the condition automatically set by the condition designer, which is: ((a03.NAOK == "-oth-"))

If I was to set the condition equation myself, I would check for both variables -> another possible workaround, using (a03.NAOK == "-oth-" OR !is_empty(a03_other.NAOK)) in a04

DenisChenu

DenisChenu

2013-08-22 19:55

developer   ~26049

Think javascript check the radio but don't trigger change/click on radio.

jonsen

jonsen

2013-08-22 21:05

reporter   ~26052

You probably meant to say "but doesn't trigger change/click on the text input for the other option"?

DenisChenu

DenisChenu

2013-08-23 10:14

developer   ~26053

No,

When you update the text input, there are a javascript checking the radio button. GUI condition editor test the "radio state". But need "change" or "click" (don't remind).
But the actual javascript don't trigger : http://api.jquery.com/trigger/

DenisChenu

DenisChenu

2013-08-23 11:48

developer   ~26058

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12905

DenisChenu

DenisChenu

2013-08-23 11:53

developer   ~26059

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12906

c_schmitz

c_schmitz

2013-09-23 13:27

administrator   ~26324

Version 2.00+ Build 130923 released

Related Changesets

LimeSurvey: master b2a3be44

2013-08-23 09:48:44

DenisChenu

Details Diff
Fixed issue 08056: "Other" text entry does not trigger filter
Dev: use .click trigger click on radio. And click a radio check it.
Affected Issues
08056
mod - application/helpers/qanda_helper.php Diff File

LimeSurvey: 2.05 866e66dd

2013-08-23 09:53:02

DenisChenu

Details Diff
Fixed issue 08056: "Other" text entry does not trigger filter
Dev: use .click trigger click on radio. And click a radio check it.
Dev: don't work more, but todo for 2.1 : a external js function for all other radio/checkbox
Dev: in core.js or other.js : depend on js system
Affected Issues
08056
mod - application/helpers/qanda_helper.php Diff File

Issue History

Date Modified Username Field Change
2013-07-29 16:46 jonsen New Issue
2013-07-29 16:46 jonsen File Added: limesurvey_survey_223529.lss
2013-07-30 14:42 sammousa Note Added: 25889
2013-07-30 15:07 jonsen Note Added: 25891
2013-07-30 15:36 jonsen Note Edited: 25891
2013-08-22 19:54 DenisChenu Product Version 2.05 RC => 2.00+
2013-08-22 19:55 DenisChenu Note Added: 26049
2013-08-22 19:55 DenisChenu Assigned To => DenisChenu
2013-08-22 19:55 DenisChenu Status new => assigned
2013-08-22 21:05 jonsen Note Added: 26052
2013-08-23 10:14 DenisChenu Note Added: 26053
2013-08-23 11:48 DenisChenu Changeset attached => LimeSurvey master b2a3be44
2013-08-23 11:48 DenisChenu Note Added: 26058
2013-08-23 11:48 DenisChenu Resolution open => fixed
2013-08-23 11:53 DenisChenu Changeset attached => LimeSurvey 2.05 866e66dd
2013-08-23 11:53 DenisChenu Note Added: 26059
2013-08-23 11:53 DenisChenu Status assigned => resolved
2013-08-23 11:53 DenisChenu Fixed in Version => 2.00+
2013-09-23 13:27 c_schmitz Note Added: 26324
2013-09-23 13:27 c_schmitz Status resolved => closed