View Issue Details

Related ChangesetsJump to NotesJump to History
This issue affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
07912Bug reportsExpression Managerpublic2013-06-07 15:252013-07-30 11:47
Reportermfaber Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05 RC 
Fixed in Version2.05 RC 
Summary07912: Expression Manager test page broken in 2.05beta3
Description

When accessing the Expression manager test page "Unit Tests of Isolated Expressions" (http://localhost/limesurvey/index.php/admin/expressions/sa/unit), the table is broken.
Some infomation is missing, some is in the wrong column.
Happens with Chrome and FF.
2.0+ works fine.

Steps To Reproduce

Open any survey
Choose expression manager from the tools menu
Click on "Unit Tests of Isolated Expressions"

TagsNo tags attached.
Attached Files
205_2013-6-12 14 25 36.png (794,871 bytes)
205.PNG (94,144 bytes)   
205.PNG (94,144 bytes)   
master.PNG (100,357 bytes)
Bug heat8
Complete LimeSurvey version number (& build)130607
I will donate to the project if issue is resolvedNo
BrowserFF or IE
Database type & versionMySQL (recent XAMP)
Server OS (if known)Win7
Webserver software & version (if known)Apache (recent XAMP)
PHP VersionPHP (recent XAMP)
Git branch / Pull Request URL

Users monitoring this issue

mfaber

Activities

DenisChenu

DenisChenu

2013-06-12 14:29

developer   ~25502

Seems OK with the last GIT version
mfaber

mfaber

2013-06-12 15:48

reporter   ~25509

Tried again and it looks still messed up.
I attached two screenshots. One with git-master "master.png" and one with git-2.05 "205.png".
In master it looks ok.
In 205, for example the column "JavaScript Result" is always empty.
DenisChenu

DenisChenu

2013-06-13 11:09

developer   ~25511

Ok,

Not really mess up then (Ithink, i'm not sure of the prupose of this part).

But NO javascript result: it's empty. Surely some js file not included :).
mfaber

mfaber

2013-06-13 12:03

reporter   ~25513

you are right. messed up was too strong. just this column is empty. but it's an important one if you want to add or test expression manager functionality ;-)

as for the purpose: it's for testing implemented expression manager functions. Left column shows the test expressions (from em_core_help.php). The other columns show what the php function (implemented in em_core_helper.php) and the same function in javascript returns (implemented in em_javascript.js). These results are compared to each other and to the expected value (also in em_core_helper.php).
mfaber

mfaber

2013-06-13 22:43

reporter   ~25517

think I found the problem. see pull request: https://github.com/LimeSurvey/LimeSurvey/pull/91
mfaber

mfaber

2013-06-14 10:03

reporter   ~25519

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12583
c_schmitz

c_schmitz

2013-06-14 10:03

administrator   ~25520

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12584

Related Changesets

LimeSurvey: 2.05 3a44cb25

2013-06-13 22:39

mfaber


Details Diff		 fixed issue 07912: EM test page broken in 2.05

dev: column with JS result were missing from EM test page
dev:
http://localhost/github/limesurvey/index.php/admin/expressions/sa/unit		 Affected Issues
07912
mod - application/controllers/admin/expressions.php Diff File

LimeSurvey: 2.05 f51767d3

2013-06-14 10:03

c_schmitz


Details Diff		 Merge pull request #91 from mfaber/fix_EMtest

Fixed issue 07912: EM test page broken in 2.05		 Affected Issues
07912
mod - application/controllers/admin/expressions.php Diff File

Issue History

Date Modified Username Field Change
2013-06-07 15:25 mfaber New Issue
2013-06-12 00:33 mfaber Issue Monitored: mfaber
2013-06-12 14:29 DenisChenu Note Added: 25502
2013-06-12 14:29 DenisChenu File Added: 205_2013-6-12 14 25 36.png
2013-06-12 15:47 mfaber File Added: 205.PNG
2013-06-12 15:48 mfaber Note Added: 25509
2013-06-12 15:50 mfaber File Added: master.PNG
2013-06-13 11:09 DenisChenu Note Added: 25511
2013-06-13 12:03 mfaber Note Added: 25513
2013-06-13 22:43 mfaber Note Added: 25517
2013-06-14 10:03 mfaber Changeset attached => LimeSurvey 2.05 3a44cb25
2013-06-14 10:03 c_schmitz Changeset attached => LimeSurvey 2.05 f51767d3
2013-06-14 10:03 mfaber Note Added: 25519
2013-06-14 10:03 mfaber Assigned To => mfaber
2013-06-14 10:03 mfaber Resolution open => fixed
2013-06-14 10:03 c_schmitz Note Added: 25520
2013-06-14 10:03 c_schmitz Assigned To mfaber => c_schmitz
2013-06-14 12:21 c_schmitz Status new => resolved
2013-06-14 12:21 c_schmitz Fixed in Version => 2.05 RC
2013-07-30 11:47 c_schmitz Status resolved => closed
2021-08-04 07:25 guest Bug heat 6 => 8