07772: Useless icons appear on the IHM - LimeSurvey bugs and feature requests

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

07772	Bug reports	Survey editing	public	2013-04-18 11:19	2013-04-29 11:51

Reporter	kharec	Assigned To	tpartner
Priority	normal	Severity	minor
Status	closed	Resolution	fixed
Product Version	2.00+
Fixed in Version	2.00+

Summary	07772: Useless icons appear on the IHM
Description	On the IHM, a user with no general right who's connecting to limesurvey see icons that are inactive. It's easy to hide them. I add a patch here :)
Steps To Reproduce	You create a survey with restricted access, and five dummy token. After that, you create a new user with no general rights. Then, you login with this new user, and you see the survey and also the global icons for actions on survey, whose are inactive.
Tags	No tags attached.
Attached Files	hide_useless_icons.patch (347 bytes) --- superfish.css.old 2013-04-17 17:58:26.000000000 +0200 +++ superfish.css 2013-04-17 17:58:40.000000000 +0200 @@ -86,7 +86,8 @@ /* arrows / .sf-menu a.sf-with-ul { - padding-right: 1.7em; + display: none; + padding-right: 1.7em; min-width: 1px; /* trigger IE7 hasLayout so spans position accurately */ } .sf-sub-indicator { hide_useless_icons.patch (347 bytes)

Bug heat	6
Complete LimeSurvey version number (& build)	130406
I will donate to the project if issue is resolved	No
Browser	Firefox 20
Database type & version	Postrgresql 9.1
Server OS (if known)	Debian 6.0.6
Webserver software & version (if known)	Apache 2.2
PHP Version	5.3.3-7+squeeze15

User List	There are no users monitoring this issue.

kharec 2013-04-18 11:33 reporter ~24980	Also, this patch is applied in ./styles/gringegreen/ on the superfish.css file.

c_schmitz 2013-04-21 22:51 administrator ~25018	So you solution is to generally remove the icons? That does not seem right.

kharec 2013-04-22 10:13 reporter ~25025	what do you advocate?

c_schmitz 2013-04-23 11:58 administrator ~25068	Check if the menu entry has any submenu items, if not completely hide it. This might even be doable by some CSS.

c_schmitz 2013-04-23 11:59 administrator ~25069	Tony, any ideas?

kharec 2013-04-23 13:17 reporter ~25075	No any submenu items on the IHM, let's check in the CSS.

tpartner 2013-04-23 13:49 partner ~25080	Wouldn't it be better to fix it in the view (survey_view.php) rather that adding more CSS or JS?

kharec 2013-04-23 13:59 reporter ~25081	Oh yes, should be better :)

tpartner 2013-04-24 17:12 partner ~25117	Fixed in 2.0 and 2.05. I'm not sure why the commits don't show here but they are: https://github.com/LimeSurvey/LimeSurvey/commit/0d77a9284462a58121966ab96062735f90cbb34b https://github.com/LimeSurvey/LimeSurvey/commit/f8e3e14e69daa9b5eaac77e0e0e04b0ad94d8982

tpartner 2013-04-25 23:57 partner ~25133	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12352

tpartner 2013-04-29 11:51 partner ~25155	Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12359

LimeSurvey: master 0d77a928 2013-04-24 15:03:09 tpartner Details Diff	Fixed issue 07772: Useless icons appear on the IHM Removed unused icons in survey bar (when user doesn't have permissions)	Affected Issues 07772
	mod - application/views/admin/survey/surveybar_view.php	Diff File
LimeSurvey: 2.05 f8e3e14e 2013-04-24 15:03:36 tpartner Details Diff	Fixed issue 07772: Useless icons appear on the IHM Removed unused icons in survey bar (when user doesn't have permissions)	Affected Issues 07772
	mod - application/views/admin/survey/surveybar_view.php	Diff File

Date Modified	Username	Field	Change
2013-04-18 11:19	kharec	New Issue
2013-04-18 11:19	kharec	File Added: hide_useless_icons.patch
2013-04-18 11:33	kharec	Note Added: 24980
2013-04-21 22:50	c_schmitz	Assigned To	=> c_schmitz
2013-04-21 22:50	c_schmitz	Status	new => assigned
2013-04-21 22:51	c_schmitz	Note Added: 25018
2013-04-22 10:13	kharec	Note Added: 25025
2013-04-23 11:58	c_schmitz	Note Added: 25068
2013-04-23 11:59	c_schmitz	Assigned To	c_schmitz => tpartner
2013-04-23 11:59	c_schmitz	Note Added: 25069
2013-04-23 13:17	kharec	Note Added: 25075
2013-04-23 13:49	tpartner	Note Added: 25080
2013-04-23 13:59	kharec	Note Added: 25081
2013-04-24 17:12	tpartner	Note Added: 25117
2013-04-24 17:12	tpartner	Status	assigned => resolved
2013-04-24 17:12	tpartner	Resolution	open => fixed
2013-04-25 23:57	tpartner	Changeset attached	=> LimeSurvey master 0d77a928
2013-04-25 23:57	tpartner	Note Added: 25133
2013-04-29 08:29	c_schmitz	Fixed in Version	=> 2.00+
2013-04-29 08:30	c_schmitz	Status	resolved => closed
2013-04-29 11:51	tpartner	Changeset attached	=> LimeSurvey 2.05 f8e3e14e
2013-04-29 11:51	tpartner	Note Added: 25155
2019-11-01 17:25	c_schmitz	Category	Survey design => Survey editing