07009: Label set quick add function broken - LimeSurvey bugs and feature requests

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

07009	Bug reports	Survey editing	public	2012-12-04 11:29	2012-12-07 09:58

Reporter	DenisChenu	Assigned To	tpartner
Priority	normal	Severity	minor
Status	closed	Resolution	fixed
Product Version	2.00+

Summary	07009: Label set quick add function broken
Description	Adding one label with quickadd is OK, but replace or adding 2 is broken
Steps To Reproduce	Try to use "Quick add" function on label set editor
Tags	No tags attached.

Bug heat	8
Complete LimeSurvey version number (& build)	121204
I will donate to the project if issue is resolved	No
Browser	FF16
Database type & version	not relevant
Server OS (if known)	debian/linux
Webserver software & version (if known)	apache
PHP Version	PHP Version 5.3

User List	tpartner

DenisChenu 2012-12-04 15:14 developer ~22880	Reminder sent to: tpartner Tony, you know best quickadd functionnality. Can you review it for label set ?

DenisChenu 2012-12-04 15:46 developer ~22882 Last edited: 2012-12-04 15:47	Thank you :) I rework HTML this morning, just some id etc ...

tpartner 2012-12-04 22:06 partner ~22887	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10720

tpartner 2012-12-04 22:15 partner ~22888	Fix committed to 2.1 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10721

tpartner 2012-12-04 22:17 partner ~22889	Fixed in 2.0 and 2.1

DenisChenu 2012-12-05 10:16 developer ~22890	Great thanks. Did you think we can use same javascript for subquestion/answer and label ? Replace subquestion.js/answers.js/label.js by one js file with some parameters ? Maybe it's more easy to debug one file . Denis PS: i look that for 2.1

tpartner 2012-12-05 12:45 partner ~22897	Sure it makes sense to centralize the code but I didn't have time for that so I just patched existing code.

DenisChenu 2012-12-05 13:34 developer ~22898 Last edited: 2012-12-05 13:34	Oh yes, i understand. But if you think it can be done, i have a look when i found some time for 2.1 (or 2.2 .....)

c_schmitz 2012-12-07 09:58 administrator ~23013	2.00+ build 121207 released.

LimeSurvey: master 8c543bd4 2012-12-04 21:06:18 tpartner Details Diff	Fixed issue 07009: Label set quick add function broken Dev Cleaned up invalid selectors and vars	Affected Issues 07009
	mod - scripts/admin/labels.js	Diff File
LimeSurvey: 2.1 697fe65b 2012-12-04 21:14:36 tpartner Details Diff	Fixed issue 07009: Label set quick add function broken Dev Cleaned up invalid selectors and vars	Affected Issues 07009
	mod - scripts/admin/labels.js	Diff File

Date Modified	Username	Field	Change
2012-12-04 11:29	DenisChenu	New Issue
2012-12-04 15:14	DenisChenu	Issue Monitored: tpartner
2012-12-04 15:14	DenisChenu	Note Added: 22880
2012-12-04 15:22	tpartner	Assigned To	=> tpartner
2012-12-04 15:22	tpartner	Status	new => assigned
2012-12-04 15:46	DenisChenu	Note Added: 22882
2012-12-04 15:47	DenisChenu	Note Edited: 22882
2012-12-04 22:06	tpartner	Changeset attached	=> LimeSurvey master 8c543bd4
2012-12-04 22:06	tpartner	Note Added: 22887
2012-12-04 22:06	tpartner	Resolution	open => fixed
2012-12-04 22:15	tpartner	Changeset attached	=> LimeSurvey 2.1 697fe65b
2012-12-04 22:15	tpartner	Note Added: 22888
2012-12-04 22:17	tpartner	Note Added: 22889
2012-12-04 22:17	tpartner	Status	assigned => resolved
2012-12-05 10:16	DenisChenu	Note Added: 22890
2012-12-05 12:45	tpartner	Note Added: 22897
2012-12-05 13:34	DenisChenu	Note Added: 22898
2012-12-05 13:34	DenisChenu	Note Edited: 22898
2012-12-07 09:58	c_schmitz	Note Added: 23013
2012-12-07 09:58	c_schmitz	Status	resolved => closed
2019-11-01 17:25	c_schmitz	Category	Survey design => Survey editing
2021-08-03 07:20	guest	Bug heat	6 => 8