View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 06519 | Bug reports | Other | public | 2012-08-26 05:43 | 2021-12-30 11:52 |
| Reporter | TMSWhite | Assigned To | |||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | unable to reproduce | ||
| Summary | 06519: problems with Question_Objects branch | ||||
| Description | this is a placeholder 'bug' to discuss the Question_Objects branch | ||||
| Tags | No tags attached. | ||||
| Bug heat | 8 | ||||
| Complete LimeSurvey version number (& build) | |||||
| I will donate to the project if issue is resolved | |||||
| Browser | |||||
| Database type & version | |||||
| Server OS (if known) | |||||
| Webserver software & version (if known) | |||||
| PHP Version | |||||
| Git branch / Pull Request URL | |||||
|
Aaron- |
|
|
With regards to 2, |
|
|
(3) It's worth moving the $this->sgqaNaming code to Question_Objects. It is a fairly static parameter. So, LimeExpressionManager can use $q->varname (or something like that) to get the sgqa or qcode name, as appropriate. |
|
|
(2) was a clean install (I cloned your repo and did a fresh install). The survey is ls2_array_filter_tests.lss in the docs/demosurveys folder. |
|
|
Aaron, some more comments: |
|
|
(6)(c) ->getAnswerHTML() - should not query database for answers or 'other' status. Furthermore, if you are trying to randomize questions or answers, rather using SQL to do the randomization, first load all of the answers (at question creation time) and use PHP randomization functions to randomize them. |
|
|
(7) ->getAnswerHTML(). This is a good start, but all of these should be refactored into views or .pstpl templates so that people wanting to extend question functionality can do so via the addition of new views without needing to modify the core code. |
|
|
I'll be working on these things. Many of the database queries were copied out of the original code and I'm still working on optimization for those. Other than the array-filters thing, did you find any broken features? |
|
|
Ok. I think I resolved the import issue. I fixed at least one major bug with the filtering, but it appears to be very much broken still. I'll be working on it. |
|
|
I fixed another couple bugs with array filtering. As far as I can tell, it now works as expected compared to 2.0. I assume you're at your new job now, but when it's convenient if you have time to look for any more fatal (i.e. non-performance-related) bugs that would be great. |
|
|
Aaron- Although page 1 of ls2_array_filter_tests.lss works OK, I can't get to page 2. I just see a blank page. Also, I can't Show Logic File for page 2, or for the whole survey. In both cases, I get a blank page. I did a fresh database install and re-imported the survey, so that can't be the problem. However, you're comparing to 2.0, not 1.92; and 2.0 may not work either. I just don't know. So, when you do your feature regression tests, please compare against 1.92, since I'm sure that works properly. |
|
|
Ok. I'm officially an idiot some days. While fixing the first page, I actually managed to introduce a new bug in the second page. That should be resolved now. |
|
|
Aaron- That fixed that issue. However, you (I'd say we, but I don't have much time), really need to regression test all of the survey in docs/demosurveys/*, comparing them to the 1.92 functionality. I only loaded one additional survey to start testing (ls2_cascading_array_filter.lss), and already see two severe problems: So, the fact that you're doing this refactoring is wonderful; but with any such refactoring, there is a need for rigorous testing. The surveys in docs/demosurveys/* are specifically designed to test all of the LimeSurvey functionality, so I recommend getting familiar with them in 1.92 and confirming that you can get the same behavior in your branch. Good luck! |
|
|
Fix me! ;) |
|
|
Hello TMSWhite, galads |
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-08-26 05:43 | TMSWhite | New Issue | |
| 2012-08-26 05:43 | TMSWhite | Status | new => assigned |
| 2012-08-26 05:43 | TMSWhite | Assigned To | => user16774 |
| 2012-08-26 05:55 | TMSWhite | Note Added: 20582 | |
| 2012-08-26 06:00 |
|
Note Added: 20583 | |
| 2012-08-26 06:15 | TMSWhite | Note Added: 20584 | |
| 2012-08-26 06:27 | TMSWhite | Note Added: 20585 | |
| 2012-08-26 14:46 | TMSWhite | Note Added: 20586 | |
| 2012-08-26 15:19 | TMSWhite | Note Added: 20587 | |
| 2012-08-26 15:28 | TMSWhite | Note Added: 20588 | |
| 2012-08-27 21:07 |
|
Note Added: 20590 | |
| 2012-08-29 09:00 |
|
Note Added: 20593 | |
| 2012-08-30 02:13 |
|
Note Added: 20594 | |
| 2012-08-30 02:49 | TMSWhite | Note Added: 20595 | |
| 2012-08-30 04:02 |
|
Note Added: 20596 | |
| 2012-08-30 06:31 | TMSWhite | Note Added: 20597 | |
| 2012-11-26 22:25 | c_schmitz | Note Added: 22565 | |
| 2021-12-30 11:52 | galads | Status | assigned => closed |
| 2021-12-30 11:52 | galads | Resolution | open => unable to reproduce |
| 2021-12-30 11:52 | galads | Note Added: 67884 |