View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
06271Bug reportsSurvey takingpublic2012-06-24 15:282012-12-13 19:19
ReporterTMSWhite Assigned ToTMSWhite  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.92+ 
Fixed in Version1.92+ 
Summary06271: text entry fields use onchange instead of onkeyup events to propagate changes
Description

1.91+ used onkeyup for most text entry fields. 1.92 uses onchange. That means that users must TAB off of a field or click on a new entry box (or question) to see conditional questions / tailoring appear/disappear, which can be disruptive.

Steps To Reproduce

Attached survey tests all combinations.

Additional Information

This change was made in 1.92 (I think in late 2011) because of slow performance due to excessive JavaScript processing when running checkconditions() on all questions whenever there was a onkeyup event.

Now that EM is optimized to only show/hide questions/tailoring when a question upon which they depend changes, the slow performance issue may no longer hold true.

1.91+ used onkeyup for most text entry fields, including:

multiple choice
multiple choice with comment
multiple short text
multiple numeric
short text
long text
huge text

It did not (but probably should have) also used onkeyup for the following:

numeric
array texts
array numbers (when using the text entry option)

TagsNo tags attached.
Attached Files
limesurvey_survey_16958.lss (125,264 bytes)
Bug heat4
Complete LimeSurvey version number (& build)120624
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMysql 5.3
Server OS (if known)Windows XP
Webserver software & version (if known)XAMPP
PHP Version5.3

Users monitoring this issue

There are no users monitoring this issue.

Activities

TMSWhite

TMSWhite

2012-06-24 15:44

reporter   ~19537

Carsten - assigning this to you to get your feedback.

This is a simple change in qanda.php if you want me to do it - just want your thoughts first.
TMSWhite

TMSWhite

2012-06-27 07:41

reporter   ~19578

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8866
TMSWhite

TMSWhite

2012-06-27 07:43

reporter   ~19579

Note, with this change to using onkeyup, can still paste into all non-numeric fields.

So, it appears that the keypress=goodchars() function that is preventing numbers from being pasted into the fields.
TMSWhite

TMSWhite

2012-06-27 22:53

reporter   ~19582

Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8868
c_schmitz

c_schmitz

2012-07-05 22:16

administrator   ~19626

New 1.92+ version released.

Related Changesets

LimeSurvey: master 6abc4311

2012-06-26 22:40:33

TMSWhite

Details Diff 		Fixed issue 06271: text entry fields use onchange instead of onkeyup events to propagate changes
Dev Now consistently use onkeyup for all text entry fields, including comments and array text; and call checkconditions() on keyup, so get immediate change
Dev Ensured can enter negative numbers and/or decimal numbers in the number entry fields
Dev Validated that does not cause performance degradation, even in IE
Fixed issue Unchecking entries in multiple choice checkbox did not clear associated comment
Fixed issue Clearing "other" value in multiple choice checkbox did not clear associated comment
Fixed issue Changes to comments in multiple choice checkbox could not trigger changes in tailoring		 Affected Issues
06271
mod - group.php Diff File
mod - qanda.php Diff File
mod - scripts/survey_runtime.js Diff File

LimeSurvey: Yii 0737f18b

2012-06-27 13:44:52

TMSWhite

Details Diff 		Fixed issue 06271: text entry fields use onchange instead of onkeyup events to propagate changes
Dev Now consistently use onkeyup for all text entry fields, including comments and array text; and call checkconditions() on keyup, so get immediate change
Dev Ensured can enter negative numbers and/or decimal numbers in the number entry fields
Dev Validated that does not cause performance degradation, even in IE
Fixed issue Unchecking entries in multiple choice checkbox did not clear associated comment
Fixed issue Clearing "other" value in multiple choice checkbox did not clear associated comment
Fixed issue Changes to comments in multiple choice checkbox could not trigger changes in tailoring		 Affected Issues
06271
mod - application/helpers/SurveyRuntimeHelper.php Diff File
mod - application/helpers/qanda_helper.php Diff File
mod - scripts/survey_runtime.js Diff File

Issue History

Date Modified Username Field Change
2012-06-24 15:28 TMSWhite New Issue
2012-06-24 15:28 TMSWhite File Added: limesurvey_survey_16958.lss
2012-06-24 15:44 TMSWhite Note Added: 19537
2012-06-24 15:45 TMSWhite Assigned To => c_schmitz
2012-06-24 15:45 TMSWhite Status new => assigned
2012-06-26 22:16 TMSWhite Assigned To c_schmitz => TMSWhite
2012-06-27 07:41 TMSWhite Changeset attached => LimeSurvey master 6abc4311
2012-06-27 07:41 TMSWhite Note Added: 19578
2012-06-27 07:41 TMSWhite Resolution open => fixed
2012-06-27 07:43 TMSWhite Note Added: 19579
2012-06-27 07:44 TMSWhite Status assigned => resolved
2012-06-27 07:44 TMSWhite Fixed in Version => 1.92+
2012-06-27 22:53 TMSWhite Changeset attached => LimeSurvey Yii 0737f18b
2012-06-27 22:53 TMSWhite Note Added: 19582
2012-07-05 22:16 c_schmitz Note Added: 19626
2012-07-05 22:16 c_schmitz Status resolved => closed