View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 04963 | Bug reports | Security | public | 2011-02-18 16:07 | 2011-03-10 12:28 |
| Reporter | limech | Assigned To | DenisChenu | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 1.91RC4 | ||||
| Fixed in Version | 1.91RC5 | ||||
| Summary | 04963: SuperAdmin cannot set group permissions on surveys owned by others | ||||
| Description | Because of what I understand as a lapsus i admin/html.php, an attempt from a SuperAdmin to set survey group permissions on a survey not owned by him results in a crash due to an incomplete SQL statement. | ||||
| Additional Information | Suggested patch enclosed. | ||||
| Tags | No tags attached. | ||||
| Attached Files | postusergroupid.patch (639 bytes)
Index: admin/html.php
===================================================================
--- admin/html.php (revision 9809)
+++ admin/html.php (working copy)
@@ -1891,7 +1891,11 @@
}
}
else{
- $sQuery = "SELECT owner_id FROM ".db_table_name('surveys')." WHERE sid = {$surveyid} AND owner_id = ".$_SESSION['loginID'];
+ $sQuery = "SELECT owner_id FROM ".db_table_name('surveys')." WHERE sid = {$surveyid} ";
+ if ($_SESSION['USER_RIGHT_SUPERADMIN'] != 1)
+ {
+ $sQuery.=" AND owner_id = ".$_SESSION['loginID'];
+ }
$iOwnerID=$connect->GetOne($sQuery);
}
| ||||
| Bug heat | 256 | ||||
| Complete LimeSurvey version number (& build) | 9809 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | any | ||||
| Database type & version | any | ||||
| Server OS (if known) | any | ||||
| Webserver software & version (if known) | any | ||||
| PHP Version | any | ||||
| Git branch / Pull Request URL | |||||
|
Fixed in Thanks a lot |
|
|
1.91RC5 released. |
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-02-18 16:07 | limech | New Issue | |
| 2011-02-18 16:07 | limech | File Added: postusergroupid.patch | |
| 2011-02-18 16:08 | limech | Issue Monitored: limech | |
| 2011-02-19 13:29 | DenisChenu | Assigned To | => DenisChenu |
| 2011-02-19 13:29 | DenisChenu | Status | new => assigned |
| 2011-02-23 16:08 | DenisChenu | Note Added: 14270 | |
| 2011-02-23 16:08 | DenisChenu | Status | assigned => resolved |
| 2011-02-23 16:08 | DenisChenu | Fixed in Version | => 1.91RC5 |
| 2011-02-23 16:08 | DenisChenu | Resolution | open => fixed |
| 2011-03-10 12:28 | c_schmitz | Note Added: 14387 | |
| 2011-03-10 12:28 | c_schmitz | Status | resolved => closed |
| 2021-08-12 02:58 | guest | Bug heat | 254 => 256 |