View Issue Details

This issue affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
04954Bug reportsSurvey participants (Tokens)public2011-03-19 18:08
ReporterMinstrel72 Assigned Tolemeur  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.90+ 
Fixed in Version1.91RC5 
Summary04954: Attributes list not correctly retrieved in survey Welcome texts editor panel
Description

Hi all.

When you edit the welcome text and try to add a field from the tokens, the attributes list is not correctly retrieved and shown. How could this be ?

Everything in the code looks correct.
It worked fine in previous versions.

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)9642
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL
Server OS (if known)FreeBSD
Webserver software & version (if known)Apache
PHP Version5.2.17
Git branch / Pull Request URL

Users monitoring this issue

There are no users monitoring this issue.

Activities

Mazi

Mazi

2011-02-15 16:56

updater   ~14185

Do you manually add the placeholder or do you use the editor to selct the placeholdr and insert it?

Minstrel72

Minstrel72

2011-02-17 13:42

reporter   ~14208

Since I cannot add it from the editor anymore I had to add it manually.

I checked the code and everything looks right (lines 114-132 of the file
fck_limereplacementfields.php)

it simply does not generate the array with the attributes field list

Mazi

Mazi

2011-02-17 14:02

updater   ~14209

I think the issue is that it is not listed at the editor because it's not completely implemented!?

Maybe you can provide a patch so we can solve this?

Minstrel72

Minstrel72

2011-02-17 18:06

reporter   ~14211

I found the problem, but dunno know why this happens.

In fck_limereplacement.php, in the cases:

case 'survey-desc':
case 'survey-welc':
case 'survey-endtext':

$surveyid is null. But it should be a global variable and dunno know why it gets lost...

it's very strange. Could it be a session problem ?

Mazi

Mazi

2011-02-17 18:54

updater   ~14246

Thibault, what does the expert say...?

Minstrel72

Minstrel72

2011-02-24 10:39

reporter   ~14284

Hi!

Any feedback about this issue ?

Thanks,
Minstrel

lemeur

lemeur

2011-03-08 18:43

reporter   ~14346

Fixed in rev 9866 and 9867

c_schmitz

c_schmitz

2011-03-10 12:28

administrator   ~14372

1.91RC5 released.

Minstrel72

Minstrel72

2011-03-11 10:47

reporter   ~14397

Thank you.

Which files are involved ? I'd like to apply a patch for this in my 1.90 stable production installation.

Thanks,
Minstrel

lemeur

lemeur

2011-03-11 10:51

reporter   ~14398

Modified: source/limesurvey/admin/editsurveytextelements.php

--- source/limesurvey/admin/editsurveytextelements.php 2011-03-08 17:23:59 UTC (rev 9865)
+++ source/limesurvey/admin/editsurveytextelements.php 2011-03-08 17:42:45 UTC (rev 9866)
@@ -48,15 +48,15 @@
. "<input type='text' size='80' name='shorttitle".$esrow['surveyls_language']."' value=\"{$esrow['surveylstitle']}\" />\n"
. "

  • <label for=''>".$clang->gT("Description:")."</label>\n"
    . "<textarea cols='80' rows='15' name='description
    ".$esrow['surveyls_language']."'>{$esrow['surveyls_description']}</textarea>\n"

    • . getEditor("survey-desc","description_".$esrow['surveyls_language'], "".$clang->gT("Description:", "js")."",'','','',$action)
    • . getEditor("survey-desc","description_".$esrow['surveyls_language'], "".$clang->gT("Description:", "js")."",$surveyid,'','',$action)
      . "
    • \n"
      . "
    • <label for=''>".$clang->gT("Welcome message:")."</label>\n"
      . "<textarea cols='80' rows='15' name='welcome_".$esrow['surveyls_language']."'>{$esrow['surveyls_welcometext']}</textarea>\n"
    • . getEditor("survey-welc","welcome_".$esrow['surveyls_language'], "".$clang->gT("Welcome:", "js")."",'','','',$action)
    • . getEditor("survey-welc","welcome_".$esrow['surveyls_language'], "".$clang->gT("Welcome:", "js")."",$surveyid,'','',$action)
      . "
    • \n"
      . "
    • <label for=''>".$clang->gT("End message:")."</label>\n"
      . "<textarea cols='80' rows='15' name='endtext_".$esrow['surveyls_language']."'>{$esrow['surveyls_endtext']}</textarea>\n"
    • . getEditor("survey-endtext","endtext_".$esrow['surveyls_language'], "".$clang->gT("End message:", "js")."",'','','',$action)
    • . getEditor("survey-endtext","endtext_".$esrow['surveyls_language'], "".$clang->gT("End message:", "js")."",$surveyid,'','',$action)
      . "
    • \n"
      . "
    • <label for=''>".$clang->gT("End URL:")."</label>\n"
      . "<input type='text' size='80' name='url_".$esrow['surveyls_language']."' value=\"{$esrow['surveyls_url']}\" />\n"
  • Minstrel72

    Minstrel72

    2011-03-15 08:53

    reporter   ~14436

    I guess that applying a patch to my installation (build 9642) is not possible as I cannot file a file named editsurveytextelements.php

    I think I'll have to wait the next stable 1.91 to update.

    Thanks again.

    lemeur

    lemeur

    2011-03-19 18:08

    reporter   ~14465

    Yes, you'll have to wait for the upcoming 1.91 release (shouldn't be long now).

    Issue History

    Date Modified Username Field Change
    2011-02-14 10:46 Minstrel72 New Issue
    2011-02-15 16:56 Mazi Note Added: 14185
    2011-02-15 16:56 Mazi Assigned To => Mazi
    2011-02-15 16:56 Mazi Status new => feedback
    2011-02-17 13:42 Minstrel72 Note Added: 14208
    2011-02-17 13:42 Minstrel72 Status feedback => assigned
    2011-02-17 14:02 Mazi Note Added: 14209
    2011-02-17 14:02 Mazi Status assigned => feedback
    2011-02-17 18:06 Minstrel72 Note Added: 14211
    2011-02-17 18:06 Minstrel72 Status feedback => assigned
    2011-02-17 18:54 Mazi Assigned To Mazi => lemeur
    2011-02-17 18:54 Mazi Note Added: 14246
    2011-02-24 10:39 Minstrel72 Note Added: 14284
    2011-03-08 18:43 lemeur Note Added: 14346
    2011-03-08 18:43 lemeur Status assigned => resolved
    2011-03-08 18:43 lemeur Fixed in Version => 1.91RC5
    2011-03-08 18:43 lemeur Resolution open => fixed
    2011-03-10 12:28 c_schmitz Note Added: 14372
    2011-03-10 12:28 c_schmitz Status resolved => closed
    2011-03-11 10:47 Minstrel72 Note Added: 14397
    2011-03-11 10:47 Minstrel72 Status closed => feedback
    2011-03-11 10:47 Minstrel72 Resolution fixed => reopened
    2011-03-11 10:51 lemeur Note Added: 14398
    2011-03-11 10:51 lemeur Status feedback => closed
    2011-03-11 10:51 lemeur Resolution reopened => fixed
    2011-03-15 08:53 Minstrel72 Note Added: 14436
    2011-03-15 08:53 Minstrel72 Status closed => feedback
    2011-03-15 08:53 Minstrel72 Resolution fixed => reopened
    2011-03-19 18:08 lemeur Note Added: 14465
    2011-03-19 18:08 lemeur Status feedback => resolved
    2011-03-19 18:08 lemeur Resolution reopened => fixed
    2011-03-19 18:08 lemeur Status resolved => closed
    2016-12-08 10:39 c_schmitz Category Tokens => Survey participants (Tokens)