View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 04601 | Bug reports | Theme editor | public | 2010-09-15 11:55 | 2010-10-19 21:12 |
| Reporter | ronvdburg | Assigned To | tpartner | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 1.90+ | ||||
| Summary | 04601: ie_fix_8 not included in all the templates startpage.pstpl | ||||
| Description | Some templates have only included ie_fix_6 and ie_fix_7. | ||||
| Steps To Reproduce | Look at templates/*/startpage.pstpl | ||||
| Additional Information | I included a diff file if you deem it proper and necessary to make the startpage templates consistent. Furthermore, I noticed that the order of the tests for IE <= 6; IE = 7 and IE = 8 differ amongst the templates. If you want a patch from me to reorder them consistently, please ask me and tell me the proper order. | ||||
| Tags | No tags attached. | ||||
| Attached Files | ie_fix_8.diff (3,633 bytes)
Index: limesurvey/templates/business_grey/ie_fix_8.css
===================================================================
--- limesurvey/templates/business_grey/ie_fix_8.css (revision 9131)
+++ limesurvey/templates/business_grey/ie_fix_8.css (working copy)
@@ -1,3 +1,4 @@
+/* The following styles are for IE 8 only*/
.numeric-multi ul.multiplenumerichelp li span input {
background-color: #e1e1e1;
-}
\ No newline at end of file
+}
Index: limesurvey/templates/sherpa/startpage.pstpl
===================================================================
--- limesurvey/templates/sherpa/startpage.pstpl (revision 9131)
+++ limesurvey/templates/sherpa/startpage.pstpl (working copy)
@@ -13,6 +13,9 @@
<!--[if lte IE 6]>
<link rel="stylesheet" type="text/css" href="{TEMPLATEURL}ie_fix_6.css" />
<![endif]-->
+<!--[if IE 8]>
+ <link rel="stylesheet" type="text/css" href="{TEMPLATEURL}ie_fix_8.css" />
+<![endif]-->
<!-- The following CSS hides visual elements of the progress bar from screen readers. -->
<style type="text/css" media="aural tty">
Index: limesurvey/templates/clear_logo/startpage.pstpl
===================================================================
--- limesurvey/templates/clear_logo/startpage.pstpl (revision 9131)
+++ limesurvey/templates/clear_logo/startpage.pstpl (working copy)
@@ -10,6 +10,9 @@
<!--[if lte IE 6]>
<link rel="stylesheet" type="text/css" href="{TEMPLATEURL}ie_fix_6.css" />
<![endif]-->
+<!--[if IE 8]>
+ <link rel="stylesheet" type="text/css" href="{TEMPLATEURL}ie_fix_8.css" />
+<![endif]-->
<!-- The following CSS hides visual elements of the progress bar from screen readers. -->
<style type="text/css" media="aural tty">
Index: limesurvey/templates/vallendar/startpage.pstpl
===================================================================
--- limesurvey/templates/vallendar/startpage.pstpl (revision 9131)
+++ limesurvey/templates/vallendar/startpage.pstpl (working copy)
@@ -11,6 +11,9 @@
<!--[if lte IE 6]>
<link rel="stylesheet" type="text/css" href="{TEMPLATEURL}ie_fix_6.css" />
<![endif]-->
+<!--[if IE 8]>
+ <link rel="stylesheet" type="text/css" href="{TEMPLATEURL}ie_fix_8.css" />
+<![endif]-->
<!-- The following CSS hides visual elements of the progress bar from screen readers. -->
<style type="text/css" media="aural tty">
Index: limesurvey/templates/mint_idea/startpage.pstpl
===================================================================
--- limesurvey/templates/mint_idea/startpage.pstpl (revision 9131)
+++ limesurvey/templates/mint_idea/startpage.pstpl (working copy)
@@ -11,6 +11,9 @@
<!--[if lte IE 6]>
<link rel="stylesheet" type="text/css" href="{TEMPLATEURL}ie_fix_6.css" />
<![endif]-->
+<!--[if IE 8]>
+ <link rel="stylesheet" type="text/css" href="{TEMPLATEURL}ie_fix_8.css" />
+<![endif]-->
<!-- The following CSS hides visual elements of the progress bar from screen readers. -->
<style type="text/css" media="aural tty">
Index: limesurvey/templates/eirenicon/startpage.pstpl
===================================================================
--- limesurvey/templates/eirenicon/startpage.pstpl (revision 9131)
+++ limesurvey/templates/eirenicon/startpage.pstpl (working copy)
@@ -11,6 +11,9 @@
<!--[if lte IE 6]>
<link rel="stylesheet" type="text/css" href="{TEMPLATEURL}ie_fix_6.css" />
<![endif]-->
+<!--[if IE 8]>
+ <link rel="stylesheet" type="text/css" href="{TEMPLATEURL}ie_fix_8.css" />
+<![endif]-->
<!-- The following CSS hides visual elements of the progress bar from screen readers. -->
<style type="text/css" media="aural tty">
| ||||
| Bug heat | 6 | ||||
| Complete LimeSurvey version number (& build) | 9129 | ||||
| I will donate to the project if issue is resolved | |||||
| Browser | |||||
| Database type & version | mysql 5.0.77 | ||||
| Server OS (if known) | Centos 5.3 / Linux 2.6.18 | ||||
| Webserver software & version (if known) | apache 2.2.3 | ||||
| PHP Version | 5.1.6 | ||||
| Git branch / Pull Request URL | |||||
|
Carsten, I'm not sure who is our best man for CSS and templates to assign him this ticket. |
|
|
If they are not included they are not needed. |
|
|
I agree with Carsten that it's an unnecessary call to the server but for consistency's sake I'll put 'em in and fix up the order of the calls. |
|
|
Thank you ;) |
|
|
I've standardized the CSS file inclusions across all shipped templates. Fixed in revision 9239. Thanks for the report Ron. |
|
|
great work, thanks Tony! |
|
|
Released in 1.90 plus release. |
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-09-15 11:55 | ronvdburg | New Issue | |
| 2010-09-15 11:56 | ronvdburg | File Added: ie_fix_8.diff | |
| 2010-09-20 12:27 | Mazi | Assigned To | => lemeur |
| 2010-09-20 12:27 | Mazi | Status | new => assigned |
| 2010-10-02 21:10 | lemeur | Assigned To | lemeur => c_schmitz |
| 2010-10-02 21:10 | lemeur | Note Added: 12979 | |
| 2010-10-07 21:45 | c_schmitz | Assigned To | c_schmitz => tpartner |
| 2010-10-07 21:47 | c_schmitz | Note Added: 13034 | |
| 2010-10-07 22:11 | tpartner | Note Added: 13035 | |
| 2010-10-13 23:07 | c_schmitz | Note Added: 13160 | |
| 2010-10-14 03:38 | tpartner | Note Added: 13162 | |
| 2010-10-14 03:38 | tpartner | Status | assigned => resolved |
| 2010-10-14 03:38 | tpartner | Resolution | open => fixed |
| 2010-10-14 22:54 | c_schmitz | Note Added: 13195 | |
| 2010-10-19 21:12 | c_schmitz | Note Added: 13270 | |
| 2010-10-19 21:12 | c_schmitz | Status | resolved => closed |
| 2015-12-11 14:40 | c_schmitz | Category | Templates => Theme editor |