View Issue Details

Jump to NotesJump to History
This issue affects 1 person(s).
 10
IDProjectCategoryView StatusDate SubmittedLast Update
04579Bug reportsTheme editorpublic2010-09-06 11:382010-09-08 17:27
ReporterDenisChenu Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.90+ 
Fixed in Version1.90+ 
Summary04579: template preview url for personal template is bad
Description

When select a personal template in survey edit / presentation & navigation, url of preview is bad.

waiting url $publicurl/upload/templates/templatename/preview.png
url $publicurl/templates/templatename/preview.png

Steps To Reproduce

Select a personal template in presentation & navigation

Additional Information

Patch for survey url and default limesurvey instalation url : use of sGetTemplateURL function.

TagsNo tags attached.
Attached Files
patch.diff (1,083 bytes)    
--- html_orig.php	2010-09-06 11:23:38.000000000 +0200
+++ html.php	2010-09-06 11:32:28.000000000 +0200
@@ -2625,7 +2625,7 @@
             . "</li>\n";
 
             $editsurvey .= "<li><label for='preview'>".$clang->gT("Template Preview:")."</label>\n"
-            . "<img alt='".$clang->gT("Template preview image")."' id='preview' src='$publicurl/templates/{$esrow['template']}/preview.png' />\n"
+            . "<img alt='".$clang->gT("Template preview image")."' id='preview' src='".sGetTemplateURL($esrow['template'])."/preview.png' />\n"
             . "</li>\n" ;
 
             //ALLOW SAVES
@@ -3247,7 +3247,7 @@
         $newsurvey .= "</select>\n"
         . "</li>\n"
         . "<li><label for='preview'>".$clang->gT("Template Preview:")."</label>\n"
-        . "<img alt='".$clang->gT("Template Preview:")."' id='preview' src='$publicurl/templates/{$defaulttemplate}/preview.png' />\n"
+        . "<img alt='".$clang->gT("Template Preview:")."' id='preview' src='".sGetTemplateURL($defaulttemplate)."/preview.png' />\n"
         . "</li>\n";
 
         //ALLOW SAVES
patch.diff (1,083 bytes)   
Bug heat10
Complete LimeSurvey version number (& build)9089
I will donate to the project if issue is resolved
Browserall
Database type & versionMySQL 5.1.44
Server OS (if known)Linux
Webserver software & version (if known)apache
PHP VersionPHH 5.2

Relationships

Relationship GraphDependency Graph
has duplicate 04569 closedc_schmitz template preview image doesn't updates properly 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2010-09-06 11:40

developer   ~12764

Maybe bug 4569 is for same think
http://bugs.limesurvey.org/view.php?id=4569
c_schmitz

c_schmitz

2010-09-07 14:29

administrator   ~12774

Thank you! Next time don't hesitate to commit it yourself!
DenisChenu

DenisChenu

2010-09-07 15:58

developer   ~12775

I can't Carlsten, i don't have write acces on svn (i think).

I don't hesitate for this little patch. only for big modification :)
c_schmitz

c_schmitz

2010-09-08 17:27

administrator   ~12782

Fix was released in 1.90+ version.

Issue History

Date Modified Username Field Change
2010-09-06 11:38 DenisChenu New Issue
2010-09-06 11:38 DenisChenu File Added: patch.diff
2010-09-06 11:39 DenisChenu Issue Monitored: DenisChenu
2010-09-06 11:40 DenisChenu Note Added: 12764
2010-09-07 14:27 c_schmitz Assigned To => c_schmitz
2010-09-07 14:27 c_schmitz Status new => assigned
2010-09-07 14:27 c_schmitz Status assigned => resolved
2010-09-07 14:27 c_schmitz Fixed in Version => 1.90+
2010-09-07 14:27 c_schmitz Resolution open => fixed
2010-09-07 14:28 c_schmitz Relationship added has duplicate 04569
2010-09-07 14:29 c_schmitz Note Added: 12774
2010-09-07 15:58 DenisChenu Note Added: 12775
2010-09-08 10:34 DenisChenu Issue End Monitor: DenisChenu
2010-09-08 17:27 c_schmitz Note Added: 12782
2010-09-08 17:27 c_schmitz Status resolved => closed
2015-12-11 14:40 c_schmitz Category Templates => Theme editor