View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 04393 | Bug reports | Other | public | 2010-06-06 02:54 | 2010-06-16 22:22 |
| Reporter | jdalegonzalez | Assigned To | c_schmitz | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 1.87+ | ||||
| Fixed in Version | 1.90RC2 | ||||
| Summary | 04393: getQuestions in common.php declares globals it never uses. | ||||
| Description | The first line in getQuestions is global $dbprefix, $scriptname, $connect, $clang; Of these, only $scriptname is referenced in the function. $dbprefix is declared as a global quite a bit in common.php and almost never used. I have a feeling a new function was created to return the name of a table but the person that created it didn't clean up the global declarations. | ||||
| Steps To Reproduce | search for global $ in common.php and verify that the variables declared as global are actually used by the functions that declare them. | ||||
| Additional Information | I doubt it hurts anything to leave the globals in. So, feel free to ignore this bug if you like. | ||||
| Tags | No tags attached. | ||||
| Bug heat | 2 | ||||
| Complete LimeSurvey version number (& build) | 8513 | ||||
| I will donate to the project if issue is resolved | |||||
| Browser | All | ||||
| Database type & version | All | ||||
| Server OS (if known) | All | ||||
| Webserver software & version (if known) | All | ||||
| PHP Version | All | ||||
| Git branch / Pull Request URL | |||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-06-06 02:54 | jdalegonzalez | New Issue | |
| 2010-06-06 02:54 | jdalegonzalez | Status | new => assigned |
| 2010-06-06 02:54 | jdalegonzalez | Assigned To | => user372 |
| 2010-06-06 17:02 |
|
Assigned To | user372 => c_schmitz |
| 2010-06-16 22:21 | c_schmitz | Note Added: 12232 | |
| 2010-06-16 22:21 | c_schmitz | Status | assigned => resolved |
| 2010-06-16 22:21 | c_schmitz | Fixed in Version | => 1.90RC2 |
| 2010-06-16 22:21 | c_schmitz | Resolution | open => fixed |
| 2010-06-16 22:22 | c_schmitz | Status | resolved => closed |