View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 2 person(s).
 16
IDProjectCategoryView StatusDate SubmittedLast Update
19805Bug reportsSurvey editingpublic2024-10-15 18:272024-11-18 15:49
ReporterDenisChenu Assigned Totibor.pacalat  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version6.6.x 
Summary19805: Preview group throw PHP warning
Description

When preview group : have Undefined array key "hiddenSteps"

Steps To Reproduce

Steps to reproduce

  1. set debug=2
  2. Import ./docs/demosurveys/ls6_sample_survey_multilingual_fr_de_en_it_ru.lss
  3. Go to Single choice question
  4. Click preview group

Expected result

Have the group

Actual result

PHP Warning

TagsNo tags attached.
Attached Files
PHP warning.html (19,229 bytes)    
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en" data-lt-installed="true"><head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>PHP warning</title>

<style type="text/css">
/*<![CDATA[*/
html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;}
body{line-height:1;}
ol,ul{list-style:none;}
blockquote,q{quotes:none;}
blockquote:before,blockquote:after,q:before,q:after{content:none;}
:focus{outline:0;}
ins{text-decoration:none;}
del{text-decoration:line-through;}
table{border-collapse:collapse;border-spacing:0;}

body {
	font: normal 9pt "Verdana";
	color: #000;
	background: #fff;
}

h1 {
	font: normal 18pt "Verdana";
	color: #f00;
	margin-bottom: .5em;
}

h2 {
	font: normal 14pt "Verdana";
	color: #800000;
	margin-bottom: .5em;
}

h3 {
	font: bold 11pt "Verdana";
}

pre {
	font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace;
}

pre span.error {
	display: block;
	background: #fce3e3;
}

pre span.ln {
	color: #999;
	padding-right: 0.5em;
	border-right: 1px solid #ccc;
}

pre span.error-ln {
	font-weight: bold;
}

.container {
	margin: 1em 4em;
}

.version {
	color: gray;
	font-size: 8pt;
	border-top: 1px solid #aaa;
	padding-top: 1em;
	margin-bottom: 1em;
}

.message {
	color: #000;
	padding: 1em;
	font-size: 11pt;
	background: #f3f3f3;
	-webkit-border-radius: 10px;
	-moz-border-radius: 10px;
	border-radius: 10px;
	margin-bottom: 1em;
	line-height: 160%;
}

.source {
	margin-bottom: 1em;
}

.code pre {
	background-color: #ffe;
	margin: 0.5em 0;
	padding: 0.5em;
	line-height: 125%;
	border: 1px solid #eee;
}

.source .file {
	margin-bottom: 1em;
	font-weight: bold;
}

.traces {
	margin: 2em 0;
}

.trace {
	margin: 0.5em 0;
	padding: 0.5em;
}

.trace.app {
	border: 1px dashed #c00;
}

.trace .number {
	text-align: right;
	width: 2em;
	padding: 0.5em;
}

.trace .content {
	padding: 0.5em;
}

.trace .plus,
.trace .minus {
	display:inline;
	vertical-align:middle;
	text-align:center;
	border:1px solid #000;
	color:#000;
	font-size:10px;
	line-height:10px;
	margin:0;
	padding:0 1px;
	width:10px;
	height:10px;
}

.trace.collapsed .minus,
.trace.expanded .plus,
.trace.collapsed pre {
	display: none;
}

.trace-file {
	cursor: pointer;
	padding: 0.2em;
}

.trace-file:hover {
	background: #f0ffff;
}
/*]]>*/
</style>
</head>

<body>
<div class="container">
	<h1>PHP warning</h1>

	<p class="message">
		Undefined array key "hiddenSteps"	</p>

	<div class="source">
		<p class="file">/media/shnoulle/data/webdev/master/application/helpers/SurveyRuntimeHelper.php(1797)</p>
		<div class="code"><pre><span class="ln">1785</span>             if ($gseq == -1) {
<span class="ln">1786</span>                 $sMessage = gT('Invalid group number for this survey: ') . $_gid;
<span class="ln">1787</span>                 renderError('', $sMessage, $this-&gt;aSurveyInfo, $this-&gt;sTemplateViewPath);
<span class="ln">1788</span>             }
<span class="ln">1789</span> 
<span class="ln">1790</span>             $this-&gt;aMoveResult = LimeExpressionManager::JumpTo($gseq + 1, 'group', false, true);
<span class="ln">1791</span>             if (is_null($this-&gt;aMoveResult)) {
<span class="ln">1792</span>                 $sMessage = gT('This group contains no questions.  You must add questions to this group before you can preview it');
<span class="ln">1793</span>                 renderError('', $sMessage, $this-&gt;aSurveyInfo, $this-&gt;sTemplateViewPath);
<span class="ln">1794</span>             }
<span class="ln">1795</span> 
<span class="ln">1796</span>             $_SESSION[$this-&gt;LEMsessid]['step'] = $this-&gt;aMoveResult['seq'] + 1; // step is index base 1?
<span class="error"><span class="ln error-ln">1797</span>             $_SESSION[$this-&gt;LEMsessid]['hiddenSteps'] = $this-&gt;aMoveResult['hiddenSteps'];
</span><span class="ln">1798</span> 
<span class="ln">1799</span>             $this-&gt;aStepInfo = LimeExpressionManager::GetStepIndexInfo($this-&gt;aMoveResult['seq']);
<span class="ln">1800</span> 
<span class="ln">1801</span>             // #14595
<span class="ln">1802</span>             if (empty($this-&gt;aStepInfo)) {
<span class="ln">1803</span>                 $sMessage = gT('This group is empty');
<span class="ln">1804</span>                 renderError('', $sMessage, $this-&gt;aSurveyInfo, $this-&gt;sTemplateViewPath);
<span class="ln">1805</span>             }
<span class="ln">1806</span>         } elseif ($this-&gt;previewquestion) {
<span class="ln">1807</span>             $_qid       = sanitize_int($this-&gt;param['qid']);
<span class="ln">1808</span>             LimeExpressionManager::StartSurvey($this-&gt;iSurveyid, $this-&gt;sSurveyMode, $this-&gt;aSurveyOptions, true, $this-&gt;LEMdebugLevel);
<span class="ln">1809</span>             $qSec = LimeExpressionManager::GetQuestionSeq($_qid);
</pre></div>	</div>

	<div class="traces">
		<h2>Stack Trace</h2>
				<table style="width:100%;">
						<tbody><tr class="trace app expanded">
			<td class="number">
				#0			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/media/shnoulle/data/webdev/master/application/helpers/SurveyRuntimeHelper.php(217): <strong>SurveyRuntimeHelper</strong>-&gt;<strong>setPreview</strong>()				</div>

				<div class="code"><pre><span class="ln">212</span>             $this-&gt;saveAllIfNeeded();
<span class="ln">213</span>             $this-&gt;saveSubmitIfNeeded();
<span class="ln">214</span>             // TODO: move somewhere else
<span class="ln">215</span>             $this-&gt;setNotAnsweredAndNotValidated();
<span class="ln">216</span>         } else {
<span class="error"><span class="ln error-ln">217</span>             $this-&gt;setPreview();
</span><span class="ln">218</span>         }
<span class="ln">219</span>         $this-&gt;moveSubmitIfNeeded();
<span class="ln">220</span>         $this-&gt;setGroup();
<span class="ln">221</span>         $this-&gt;fixMaxStep();
<span class="ln">222</span> 
</pre></div>			</td>
		</tr>
						<tr class="trace app expanded">
			<td class="number">
				#1			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/media/shnoulle/data/webdev/master/application/controllers/survey/SurveyIndex.php(662): <strong>SurveyRuntimeHelper</strong>-&gt;<strong>run</strong>(948651,
 array("surveyid" =&gt; 948651, "thissurvey" =&gt; array("sid" =&gt; 
948651, "owner_id" =&gt; 1, "gsid" =&gt; 1, "admin" =&gt; 
"Amministratore OpenSurvey.it", ...), "thisstep" =&gt; 0, "tokensexist" 
=&gt; 0, ...))				</div>

				<div class="code"><pre><span class="ln">657</span>         unset($redata);
<span class="ln">658</span>         $redata = compact(array_keys(get_defined_vars()));
<span class="ln">659</span>         Yii::import('application.helpers.SurveyRuntimeHelper');
<span class="ln">660</span>         $tmp = new SurveyRuntimeHelper();
<span class="ln">661</span>         // try {
<span class="error"><span class="ln error-ln">662</span>             $tmp-&gt;run($surveyid, $redata);
</span><span class="ln">663</span>         // } catch (WrongTemplateVersionException $ex) {
<span class="ln">664</span>         //     echo $ex-&gt;getMessage();
<span class="ln">665</span>         // }
<span class="ln">666</span>     }
<span class="ln">667</span> 
</pre></div>			</td>
		</tr>
						<tr class="trace app expanded">
			<td class="number">
				#2			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/media/shnoulle/data/webdev/master/application/controllers/survey/SurveyIndex.php(22): <strong>SurveyIndex</strong>-&gt;<strong>action</strong>()				</div>

				<div class="code"><pre><span class="ln">17</span>     public $oTemplate;
<span class="ln">18</span> 
<span class="ln">19</span>     public function run()
<span class="ln">20</span>     {
<span class="ln">21</span>         useFirebug();
<span class="error"><span class="ln error-ln">22</span>         $this-&gt;action();
</span><span class="ln">23</span>     }
<span class="ln">24</span> 
<span class="ln">25</span>     /**
<span class="ln">26</span>      *
<span class="ln">27</span>      * todo: this function is toooo long, to many things happening here. Should be refactored asap!
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#3			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/media/shnoulle/data/webdev/master/vendor/yiisoft/yii/framework/web/actions/CAction.php(76): <strong>SurveyIndex</strong>-&gt;<strong>run</strong>()				</div>

				<div class="code"><pre><span class="ln">71</span>     {
<span class="ln">72</span>         $method=new ReflectionMethod($this, 'run');
<span class="ln">73</span>         if($method-&gt;getNumberOfParameters()&gt;0)
<span class="ln">74</span>             return $this-&gt;runWithParamsInternal($this, $method, $params);
<span class="ln">75</span> 
<span class="error"><span class="ln error-ln">76</span>         $this-&gt;run();
</span><span class="ln">77</span>         return true;
<span class="ln">78</span>     }
<span class="ln">79</span> 
<span class="ln">80</span>     /**
<span class="ln">81</span>      * Executes a method of an object with the supplied named parameters.
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#4			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/media/shnoulle/data/webdev/master/vendor/yiisoft/yii/framework/web/CController.php(308): <strong>CAction</strong>-&gt;<strong>runWithParams</strong>(array("r"
 =&gt; "survey/index/action/previewgroup/sid/948651/gid/248/lang/en", 
"action" =&gt; "previewgroup", "sid" =&gt; "948651", "gid" =&gt; "248", 
...))				</div>

				<div class="code"><pre><span class="ln">303</span>     {
<span class="ln">304</span>         $priorAction=$this-&gt;_action;
<span class="ln">305</span>         $this-&gt;_action=$action;
<span class="ln">306</span>         if($this-&gt;beforeAction($action))
<span class="ln">307</span>         {
<span class="error"><span class="ln error-ln">308</span>             if($action-&gt;runWithParams($this-&gt;getActionParams())===false)
</span><span class="ln">309</span>                 $this-&gt;invalidActionParams($action);
<span class="ln">310</span>             else
<span class="ln">311</span>                 $this-&gt;afterAction($action);
<span class="ln">312</span>         }
<span class="ln">313</span>         $this-&gt;_action=$priorAction;
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#5			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/media/shnoulle/data/webdev/master/vendor/yiisoft/yii/framework/web/CController.php(286): <strong>CController</strong>-&gt;<strong>runAction</strong>(SurveyIndex)				</div>

				<div class="code"><pre><span class="ln">281</span>      * @see runAction
<span class="ln">282</span>      */
<span class="ln">283</span>     public function runActionWithFilters($action,$filters)
<span class="ln">284</span>     {
<span class="ln">285</span>         if(empty($filters))
<span class="error"><span class="ln error-ln">286</span>             $this-&gt;runAction($action);
</span><span class="ln">287</span>         else
<span class="ln">288</span>         {
<span class="ln">289</span>             $priorAction=$this-&gt;_action;
<span class="ln">290</span>             $this-&gt;_action=$action;
<span class="ln">291</span>             CFilterChain::create($this,$action,$filters)-&gt;run();
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#6			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/media/shnoulle/data/webdev/master/vendor/yiisoft/yii/framework/web/CController.php(265): <strong>CController</strong>-&gt;<strong>runActionWithFilters</strong>(SurveyIndex, array())				</div>

				<div class="code"><pre><span class="ln">260</span>         {
<span class="ln">261</span>             if(($parent=$this-&gt;getModule())===null)
<span class="ln">262</span>                 $parent=Yii::app();
<span class="ln">263</span>             if($parent-&gt;beforeControllerAction($this,$action))
<span class="ln">264</span>             {
<span class="error"><span class="ln error-ln">265</span>                 $this-&gt;runActionWithFilters($action,$this-&gt;filters());
</span><span class="ln">266</span>                 $parent-&gt;afterControllerAction($this,$action);
<span class="ln">267</span>             }
<span class="ln">268</span>         }
<span class="ln">269</span>         else
<span class="ln">270</span>             $this-&gt;missingAction($actionID);
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#7			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/media/shnoulle/data/webdev/master/vendor/yiisoft/yii/framework/web/CWebApplication.php(282): <strong>CController</strong>-&gt;<strong>run</strong>("index")				</div>

				<div class="code"><pre><span class="ln">277</span>         {
<span class="ln">278</span>             list($controller,$actionID)=$ca;
<span class="ln">279</span>             $oldController=$this-&gt;_controller;
<span class="ln">280</span>             $this-&gt;_controller=$controller;
<span class="ln">281</span>             $controller-&gt;init();
<span class="error"><span class="ln error-ln">282</span>             $controller-&gt;run($actionID);
</span><span class="ln">283</span>             $this-&gt;_controller=$oldController;
<span class="ln">284</span>         }
<span class="ln">285</span>         else
<span class="ln">286</span>             throw new CHttpException(404,Yii::t('yii','Unable to resolve the request "{route}".',
<span class="ln">287</span>                 array('{route}'=&gt;$route===''?$this-&gt;defaultController:$route)));
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#8			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/media/shnoulle/data/webdev/master/vendor/yiisoft/yii/framework/web/CWebApplication.php(141): <strong>CWebApplication</strong>-&gt;<strong>runController</strong>("survey/index/action/previewgroup/sid/948651/gid/248/lang/en")				</div>

				<div class="code"><pre><span class="ln">136</span>             foreach(array_splice($this-&gt;catchAllRequest,1) as $name=&gt;$value)
<span class="ln">137</span>                 $_GET[$name]=$value;
<span class="ln">138</span>         }
<span class="ln">139</span>         else
<span class="ln">140</span>             $route=$this-&gt;getUrlManager()-&gt;parseUrl($this-&gt;getRequest());
<span class="error"><span class="ln error-ln">141</span>         $this-&gt;runController($route);
</span><span class="ln">142</span>     }
<span class="ln">143</span> 
<span class="ln">144</span>     /**
<span class="ln">145</span>      * Registers the core application components.
<span class="ln">146</span>      * This method overrides the parent implementation by registering additional core components.
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#9			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/media/shnoulle/data/webdev/master/vendor/yiisoft/yii/framework/base/CApplication.php(185): <strong>CWebApplication</strong>-&gt;<strong>processRequest</strong>()				</div>

				<div class="code"><pre><span class="ln">180</span>     public function run()
<span class="ln">181</span>     {
<span class="ln">182</span>         if($this-&gt;hasEventHandler('onBeginRequest'))
<span class="ln">183</span>             $this-&gt;onBeginRequest(new CEvent($this));
<span class="ln">184</span>         register_shutdown_function(array($this,'end'),0,false);
<span class="error"><span class="ln error-ln">185</span>         $this-&gt;processRequest();
</span><span class="ln">186</span>         if($this-&gt;hasEventHandler('onEndRequest'))
<span class="ln">187</span>             $this-&gt;onEndRequest(new CEvent($this));
<span class="ln">188</span>     }
<span class="ln">189</span> 
<span class="ln">190</span>     /**
</pre></div>			</td>
		</tr>
						<tr class="trace app collapsed">
			<td class="number">
				#10			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/media/shnoulle/data/webdev/master/index.php(161): <strong>CApplication</strong>-&gt;<strong>run</strong>()				</div>

				<div class="code"><pre><span class="ln">156</span> require_once APPPATH . 'core/LSYii_Application' . EXT;
<span class="ln">157</span> 
<span class="ln">158</span> $config = require_once(APPPATH . 'config/internal' . EXT);
<span class="ln">159</span> 
<span class="ln">160</span> Yii::$enableIncludePath = false;
<span class="error"><span class="ln error-ln">161</span> Yii::createApplication('LSYii_Application', $config)-&gt;run();
</span><span class="ln">162</span> 
<span class="ln">163</span> /* End of file index.php */
<span class="ln">164</span> /* Location: ./index.php */
</pre></div>			</td>
		</tr>
				</tbody></table>
	</div>

	<div class="version">
		2024-10-15 16:24:01 nginx/1.22.1 <a href="https://www.yiiframework.com/">Yii Framework</a>/1.1.29	</div>
</div>

<script type="text/javascript">
/*<![CDATA[*/
var traceReg = new RegExp("(^|\\s)trace-file(\\s|$)");
var collapsedReg = new RegExp("(^|\\s)collapsed(\\s|$)");

var e = document.getElementsByTagName("div");
for(var j=0,len=e.length;j<len;j++){
	if(traceReg.test(e[j].className)){
		e[j].onclick = function(){
			var trace = this.parentNode.parentNode;
			if(collapsedReg.test(trace.className))
				trace.className = trace.className.replace("collapsed", "expanded");
			else
				trace.className = trace.className.replace("expanded", "collapsed");
		}
	}
}
/*]]>*/
</script>



<div id="grammalecte_menu_main_button_shadow_host" style="width: 0px; height: 0px;"></div></body><script src="PHP%20warning_fichiers/api.js"></script></html>
PHP warning.html (19,229 bytes)   
Bug heat16
Complete LimeSurvey version number (& build)6.6.6
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2024-10-21 14:36

manager   ~81276

https://github.com/LimeSurvey/LimeSurvey/pull/3999/
babiel

babiel

2024-11-08 11:01

reporter   ~81361

This bug has been reported to us by our customer yesterday. We are undecided whether we should wait for the fix or carry out a downgrade. Can you tell us what to do?
DenisChenu

DenisChenu

2024-11-08 15:30

developer   ~81365

This bug has been reported to us by our customer yesterday. We are undecided whether we should wait for the fix or carry out a downgrade. Can you tell us what to do?

It must not happen without debug mode.
guest

guest

2024-11-18 15:34

viewer   ~81408

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36635
LimeBot

LimeBot

2024-11-18 15:49

administrator   ~81411

Fixed in Release 6.7.0+241118

Related Changesets

LimeSurvey: master 1fea814e

2024-11-18 16:34

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 19805: Preview group throw PHP warning (#3999)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>		 Affected Issues
19805
mod - application/helpers/SurveyRuntimeHelper.php Diff File

Issue History

Date Modified Username Field Change
2024-10-15 18:27 DenisChenu New Issue
2024-10-15 18:27 DenisChenu File Added: PHP warning.html
2024-10-16 18:02 tibor.pacalat Assigned To => gabrieljenik
2024-10-16 18:02 tibor.pacalat Status new => assigned
2024-10-21 14:36 gabrieljenik Assigned To gabrieljenik => DenisChenu
2024-10-21 14:36 gabrieljenik Status assigned => ready for code review
2024-10-21 14:36 gabrieljenik Note Added: 81276
2024-10-21 14:36 gabrieljenik Bug heat 0 => 2
2024-11-08 11:00 guest Bug heat 2 => 8
2024-11-08 11:01 babiel Note Added: 81361
2024-11-08 11:01 babiel Bug heat 8 => 10
2024-11-08 13:18 gabrieljenik Assigned To DenisChenu => tibor.pacalat
2024-11-08 13:18 gabrieljenik Status ready for code review => ready for testing
2024-11-08 15:30 DenisChenu Note Added: 81365
2024-11-08 15:30 DenisChenu Bug heat 10 => 12
2024-11-18 15:34 Changeset attached => LimeSurvey master 1fea814e
2024-11-18 15:34 guest Note Added: 81408
2024-11-18 15:34 guest Bug heat 12 => 14
2024-11-18 15:34 tibor.pacalat Status ready for testing => resolved
2024-11-18 15:34 tibor.pacalat Resolution open => fixed
2024-11-18 15:49 LimeBot Note Added: 81411
2024-11-18 15:49 LimeBot Status resolved => closed
2024-11-18 15:49 LimeBot Bug heat 14 => 16