View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
19232Bug reportsTheme editorpublic2023-11-27 09:51
Reporterollehar Assigned Toollehar  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Summary19232: Missing cssframework default values for survey themes fruity and bootstrap
Description

Messes up copy survey when survey theme options is reset.

Steps To Reproduce
  1. Reset survey theme
  2. See faulty value for cssframework with @attributes etc (should be simple string), in the options column for lime_template_configuration table

{"container":"on","zebrastriping":"off","stickymatrixheaders":"off","greyoutselected":"off","hideprivacyinfo":"off","crosshover":"off","showpopups":"1","notables":"1","showclearall":"off","questionhelptextposition":"top","fixnumauto":"enable","questionborder":"on","questioncontainershadow":"on","bodybackgroundcolor":"#ffffff","fontcolor":"#444444","questionbackgroundcolor":"#ffffff","checkicon":"f00c","backgroundimage":"off","backgroundimagefile":".\/files\/pattern.png","brandlogo":"on","brandlogofile":"image::theme::files\/logo.png","animatebody":"off","bodyanimation":"fadeInRight","bodyanimationduration":"500","animatequestion":"off","questionanimation":"flipInX","questionanimationduration":"500","animatealert":"off","alertanimation":"shake","alertanimationduration":"500","animatecheckbox":"on","checkboxanimation":"rubberBand","checkboxanimationduration":"500","animateradio":"on","radioanimation":"zoomIn","radioanimationduration":"500","font":"noto","cssframework":{"@attributes":{"type":"dropdown","category":"Simple options","width":"12","title":"Variations","parent":"cssframework"}}}

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)-
I will donate to the project if issue is resolvedNo
Browser-
Database type & version-
Server OS (if known)-
Webserver software & version (if known)-
PHP Version-

Relationships

related to 17141 confirmed Multiple variation loaded 

Users monitoring this issue

There are no users monitoring this issue.

Activities

ollehar

ollehar

2023-11-10 13:44

administrator   ~78389

Reset of extended survey theme seems to have no effect.

DenisChenu

DenisChenu

2023-11-10 15:51

developer   ~78393

Empty : bootstrap : no ?

https://github.com/LimeSurvey/LimeSurvey/blob/bd32d1139cc71169540831bfa5c3f411bb85e677/application/models/TemplateConfiguration.php#L1695
https://github.com/LimeSurvey/LimeSurvey/blob/bd32d1139cc71169540831bfa5c3f411bb85e677/application/models/TemplateConfiguration.php#L1364
https://github.com/LimeSurvey/LimeSurvey/blob/bd32d1139cc71169540831bfa5c3f411bb85e677/application/models/TemplateManifest.php#L1345

gabrieljenik

gabrieljenik

2023-11-11 01:16

manager   ~78398

Please see https://bugs.limesurvey.org/view.php?id=19049#c77593
Maybe we need to merge it before merging this...

DenisChenu

DenisChenu

2023-11-13 08:53

developer   ~78400

Maybe we need to merge it before merging this...

:+1:

And more : fix the concept to use non valid XML … and loose attributes …

It's strange to use XML and never use attributes …

ollehar

ollehar

2023-11-23 17:52

administrator   ~78696

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35776

LimeBot

LimeBot

2023-11-27 09:51

administrator   ~78718

Fixed in Release 6.3.7+231127

Related Changesets

LimeSurvey: master eb27f860

2023-11-23 17:25:33

ollehar


Committer: GitHub Details Diff
Fixed issue 19232: Missing cssframework default values for survey th… (#3614) Affected Issues
19232
mod - themes/survey/bootswatch/config.xml Diff File
mod - themes/survey/fruity/config.xml Diff File
mod - themes/survey/fruity_twentythree/config.xml Diff File

Issue History

Date Modified Username Field Change
2023-11-10 13:23 ollehar New Issue
2023-11-10 13:23 ollehar Description Updated
2023-11-10 13:44 ollehar Assigned To => ollehar
2023-11-10 13:44 ollehar Status new => assigned
2023-11-10 13:44 ollehar Note Added: 78389
2023-11-10 13:44 ollehar Bug heat 0 => 2
2023-11-10 13:59 ollehar Status assigned => confirmed
2023-11-10 14:44 ollehar Status confirmed => ready for code review
2023-11-10 14:46 ollehar Steps to Reproduce Updated
2023-11-10 14:46 ollehar Steps to Reproduce Updated
2023-11-10 15:48 DenisChenu Relationship added related to 17141
2023-11-10 15:51 DenisChenu Note Added: 78393
2023-11-10 15:51 DenisChenu Bug heat 2 => 4
2023-11-11 01:16 gabrieljenik Note Added: 78398
2023-11-11 01:16 gabrieljenik Bug heat 4 => 6
2023-11-13 08:53 DenisChenu Note Added: 78400
2023-11-23 17:26 tibor.pacalat Status ready for code review => resolved
2023-11-23 17:26 tibor.pacalat Resolution open => fixed
2023-11-23 17:52 ollehar Changeset attached => LimeSurvey master eb27f860
2023-11-23 17:52 ollehar Note Added: 78696
2023-11-27 09:51 LimeBot Note Added: 78718
2023-11-27 09:51 LimeBot Status resolved => closed
2023-11-27 09:51 LimeBot Bug heat 6 => 8