View Issue Details

This issue affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
18563Bug reportsSurvey takingpublic2026-11-20 16:50
ReporterDenisChenu Assigned Toc_schmitz  
PrioritynoneSeverityminor 
Status resolvedResolutionfixed 
Summary18563: ANSWERTABLE and LimeExpressionManager::updateReplacementFields need to be done only one time by response
Description

Currently : code do same action 2 times by responses, and after https://github.com/LimeSurvey/LimeSurvey/pull/2794 : 4 times

This must be improved to do it only one time by response
And code is complex : separate action by single response and by a lot of responses can be great too.

Steps To Reproduce

See https://github.com/LimeSurvey/LimeSurvey/blob/39c198ed55c56a82ed67d392e7e28c10c54cc02f/application/helpers/frontend_helper.php#L573

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version
Git branch / Pull Request URLN/A

Relationships

related to 18507 closedgabrieljenik {ANSWERTABLE} not working in basic admin notification 

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2022-12-19 17:37

developer   ~73191

A quick cache (array by rsponse id) may do the trick?

DenisChenu

DenisChenu

2022-12-19 19:24

developer   ~73195

No !
Big size …

Rewrite to do action by responseId and not by mail adress

foreach(responseId)
foreach(emailaddress)
c_schmitz

c_schmitz

2026-11-20 16:50

administrator   ~87843

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=41386

Related Changesets

LimeSurvey: master 65602474

2026-11-20 16:50

c_schmitz


Details Diff
Fixed issue 18563: Admin notification emails built the answer table once per recipient instead of once per response
Dev sendSubmitNotifications() now builds ANSWERTABLE once before the recipient loops and shares it between basic and detailed notifications
Affected Issues
18563
mod - application/helpers/frontend_helper.php Diff File
mod - tests/unit/helpers/SendSubmitNotificationsTest.php Diff File

Issue History

Date Modified Username Field Change
2022-12-19 17:27 DenisChenu New Issue
2022-12-19 17:37 gabrieljenik Note Added: 73191
2022-12-19 17:37 gabrieljenik Bug heat 0 => 2
2022-12-19 19:24 DenisChenu Note Added: 73195
2022-12-19 19:24 DenisChenu Bug heat 2 => 4
2022-12-19 19:25 DenisChenu Relationship added related to 18507
2026-11-19 22:50 c_schmitz Status new => acknowledged
2026-11-20 16:42 c_schmitz Assigned To => c_schmitz
2026-11-20 16:42 c_schmitz Status acknowledged => assigned
2026-11-20 16:50 c_schmitz Changeset attached => LimeSurvey master 65602474
2026-11-20 16:50 c_schmitz Note Added: 87843
2026-11-20 16:50 c_schmitz Status assigned => resolved
2026-11-20 16:50 c_schmitz Resolution open => fixed
2026-11-20 16:50 c_schmitz Bug heat 4 => 6