View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 20
IDProjectCategoryView StatusDate SubmittedLast Update
18365Bug reportsRemoteControlpublic2022-09-21 10:192023-03-21 16:08
Reportersciarab Assigned Toollehar  
PrioritynoneSeveritycrash 
Status closedResolutionfixed 
Product Version5.4.x 
Summary18365: cpd_importParticipants not encrypting users attributes
Description

When using this function from remote_control, encrypted fields are saved without performing encryption, thus you are no more able to open cdp from interface: it reports that your encryption key is changed, but this is not true, simply the values are saved without encryption.
The bug should be in line 3519 of remotecontrol_handle.php (according to version 5.4.2 that you can actually download from https://community.limesurvey.org/downloads/ ).
In the code you find:
if ($model->save()) {
If you change this line with:
if ($model->encryptSave()) {
encryption is performed on fields where it is required and everything seems working.

Steps To Reproduce

Steps to reproduce

(Replace this text with detailed step-by-step instructions on how to reproduce the issue)

Expected result

(Write here what you expected to happen)

Actual result

(Write here what happened instead)

TagsNo tags attached.
Bug heat20
Complete LimeSurvey version number (& build)5.4.2
I will donate to the project if issue is resolvedNo
Browser
Database type & versionmariadb
Server OS (if known)
Webserver software & version (if known)
PHP Version7.4

Relationships

Relationship GraphDependency Graph
has duplicate 18184 closed cpd_importParticipants with encryption turned on, fails to save the participant encrypted in CPDB, causing 500 error to CPDB 

Users monitoring this issue

sciarab

Activities

DenisChenu

DenisChenu

2022-09-21 10:22

developer   ~71862

Great catch !
https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/remotecontrol/remotecontrol_handle.php#L3519

You can create the pull request maybe since you have the patch ?

See : https://manual.limesurvey.org/LimeSurvey_development , the coding guide line and the standard for commit message:)
DenisChenu

DenisChenu

2022-09-22 09:32

developer   ~71884

https://github.com/LimeSurvey/LimeSurvey/pull/2629
DenisChenu

DenisChenu

2022-09-22 17:33

developer   ~71896

Seems OK for me : reporter do the patch : i can merge but need a 3rp point of view ?
gabrieljenik

gabrieljenik

2023-03-21 14:41

manager   ~74216

@DenisChenu Have you seen this?

https://github.com/LimeSurvey/LimeSurvey/pull/2629#issuecomment-1440418406
I believe we can close this in favor of #2464

https://github.com/LimeSurvey/LimeSurvey/pull/2464
DenisChenu

DenisChenu

2023-03-21 16:08

developer   ~74218

18184 have a better fix

Issue History

Date Modified Username Field Change
2022-09-21 10:19 sciarab New Issue
2022-09-21 10:20 sciarab Issue Monitored: sciarab
2022-09-21 10:20 sciarab Bug heat 0 => 2
2022-09-21 10:22 DenisChenu Note Added: 71862
2022-09-21 10:22 DenisChenu Bug heat 2 => 4
2022-09-21 10:23 DenisChenu Assigned To => DenisChenu
2022-09-21 10:23 DenisChenu Status new => assigned
2022-09-21 11:32 sciarab Bug heat 4 => 6
2022-09-22 09:32 DenisChenu Assigned To DenisChenu => gabrieljenik
2022-09-22 09:32 DenisChenu Note Added: 71884
2022-09-22 09:33 DenisChenu Status assigned => ready for code review
2022-09-22 14:50 gabrieljenik Assigned To gabrieljenik => DenisChenu
2022-09-22 14:50 gabrieljenik Status ready for code review => ready for testing
2022-09-22 17:32 DenisChenu Assigned To DenisChenu => ollehar
2022-09-22 17:33 DenisChenu Note Added: 71896
2023-02-22 17:40 gabrieljenik Relationship added has duplicate 18184
2023-02-22 17:40 gabrieljenik Bug heat 6 => 16
2023-03-21 14:41 gabrieljenik Note Added: 74216
2023-03-21 16:08 DenisChenu Status ready for testing => closed
2023-03-21 16:08 DenisChenu Resolution open => fixed
2023-03-21 16:08 DenisChenu Note Added: 74218
2023-04-03 10:45 guest Bug heat 16 => 18
2023-04-03 10:58 djelusive Bug heat 18 => 20