View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
18337 | Bug reports | Survey editing | public | 2022-09-08 13:35 | 2023-01-31 17:28 |
Reporter | Mazi | Assigned To | gabrieljenik | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 5.3.x | ||||
Summary | 18337: Placeholders VALIDFROM and VALIDUNTIL at email templates do not use localized dates | ||||
Description | When using {VALIDFROM} or {VALIDUNTIL} placeholders at email templates, the date format is always like 2022-10-07 13:27:00. Even when adjusting the date format at the survey text settings, this doesn't change. | ||||
Steps To Reproduce | Steps to reproduce
Expected resultDate format of these dates should be localized according to survey settings. Actual resultDate format is always yyyy-mm-dd | ||||
Tags | No tags attached. | ||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | Version 5.3.32+220817 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Chrome | ||||
Database type & version | MariaDB 10.1.48 | ||||
Server OS (if known) | Ubuntu 20 | ||||
Webserver software & version (if known) | Apache 2.0 | ||||
PHP Version | 8.1 | ||||
@gabrieljenik, would it be possible to fix this short term? We need proper date display for a project starting in 1-2 weeks. |
|
I will catch it in the next few days. |
|
@mazi ready for you to grab it. |
|
I'm against update it directly
Maybe add it as VALIDUNTIL_FORMATED or something like this … but since second is rarely needed … |
|
@gabrieljenik: Tested, works as expected. @DenisChenu, I understand your objections. Are you using any such date comparisons or date formatting functions within your admin emails? @c_schmitz, your opinion? |
|
Tested OK. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34065 |
|
Fixed in Release 5.4.14+221205 |
|
Automatic Test: https://github.com/LimeSurvey/LimeSurvey/pull/2880/ |
|
LimeSurvey: master e54d2f53 2022-12-01 11:07 Committer: GitHub Details Diff |
Fixed issue 18337: Placeholders VALIDFROM and VALIDUNTIL at email templates do not use localized dates (#2591) - Added a 'dateFunctions' core plugin with new EM function: localize_date(date, language) - Make language parameter optional on localize_date() Co-authored-by: encuestabizdevgit <devgit@encuesta.biz> |
Affected Issues 18337 |
|
add - application/core/plugins/dateFunctions/EMFunctions.php | Diff File | ||
add - application/core/plugins/dateFunctions/config.xml | Diff File | ||
add - application/core/plugins/dateFunctions/dateFunctions.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2022-09-08 13:35 | Mazi | New Issue | |
2022-09-08 13:36 | Mazi | Relationship added | related to 18336 |
2022-09-08 15:40 | Mazi | Note Added: 71659 | |
2022-09-08 15:40 | Mazi | Bug heat | 0 => 2 |
2022-09-08 17:12 | gabrieljenik | Assigned To | => gabrieljenik |
2022-09-08 17:12 | gabrieljenik | Status | new => confirmed |
2022-09-08 17:12 | gabrieljenik | Note Added: 71660 | |
2022-09-08 17:12 | gabrieljenik | Bug heat | 2 => 4 |
2022-09-08 17:22 | gabrieljenik | Status | confirmed => assigned |
2022-09-09 16:57 | gabrieljenik | Status | assigned => ready for code review |
2022-09-09 16:57 | gabrieljenik | Note Added: 71668 | |
2022-09-09 16:58 | gabrieljenik | Note Added: 71669 | |
2022-09-09 17:32 | DenisChenu | Note Added: 71670 | |
2022-09-09 17:32 | DenisChenu | Bug heat | 4 => 6 |
2022-09-10 13:10 | Mazi | Note Added: 71672 | |
2022-11-11 14:01 | gabrieljenik | Assigned To | gabrieljenik => ollehar |
2022-11-11 14:01 | gabrieljenik | Status | ready for code review => ready for merge |
2022-11-11 14:01 | gabrieljenik | Note Added: 72704 | |
2022-12-01 10:07 | gabrieljenik | Changeset attached | => LimeSurvey master e54d2f53 |
2022-12-01 10:07 | gabrieljenik | Note Added: 72956 | |
2022-12-01 10:07 | gabrieljenik | Assigned To | ollehar => gabrieljenik |
2022-12-01 10:07 | gabrieljenik | Resolution | open => fixed |
2022-12-05 10:35 | LimeBot | Note Added: 72994 | |
2022-12-05 10:35 | LimeBot | Status | ready for merge => closed |
2022-12-05 10:35 | LimeBot | Bug heat | 6 => 8 |
2023-01-31 17:28 | gabrieljenik | Note Added: 73620 |