View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
18335Bug reportsRemoteControlpublic2022-09-24 17:05
Reporterjared.kail Assigned To 
PrioritynoneSeverityminor 
Status acknowledgedResolutionopen 
Product Version5.3.x 
Summary18335: jsonrpcphp client constructor not honoring debug
Description

$myJSONRPCClient = new \org\jsonrpcphp\JsonRPCClient( LS_RPCURL, true) does not turn on debugging.

Note:

public function __construct($url, $debug = false, $proxy = null)
{
$this->url = $url;
$this->proxy = $proxy;
$this->debug = ($this->debug === true);
// message id
$this->id = 1;
}

I believe this should be changed to be:

public function __construct($url, $debug = false, $proxy = null)
{
$this->url = $url;
$this->proxy = $proxy;
$this->debug = ($debug === true);
// message id
$this->id = 1;
}

Steps To Reproduce

Steps to reproduce

$myJSONRPCClient = new \org\jsonrpcphp\JsonRPCClient( LS_RPCURL, true);
$sessionKey= $myJSONRPCClient->get_session_key( LS_USER, LS_PASSWORD );

Expected result

Output should include debug info for RPC client; none produced currently

Actual result

(Write here what happened instead)

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)weberhofer/jsonrpcphp 2.2.2
I will donate to the project if issue is resolvedNo
Browser
Database type & versionn/a
Server OS (if known)
Webserver software & version (if known)
PHP Version7.4

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2022-09-23 23:56

manager   ~71928

Thanks!

Can you create a PR so we can review it and merge it?

DenisChenu

DenisChenu

2022-09-24 17:05

developer   ~71931

But : we didn't use in LimeSurvey core JsonRPCClient …

Issue History

Date Modified Username Field Change
2022-09-06 22:33 jared.kail New Issue
2022-09-23 23:56 gabrieljenik Status new => acknowledged
2022-09-23 23:56 gabrieljenik Note Added: 71928
2022-09-23 23:56 gabrieljenik Bug heat 0 => 2
2022-09-24 17:05 DenisChenu Note Added: 71931
2022-09-24 17:05 DenisChenu Bug heat 2 => 4