View Issue Details

This issue affects 1 person(s).
 0
IDProjectCategoryView StatusLast Update
18273Bug reportsOtherpublic2026-11-20 14:11
ReporterDenisChenu Assigned Toc_schmitz  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Summary18273: Move usercontrolSameGroupPolicy to UserGroup system
Description

See https://github.com/LimeSurvey/LimeSurvey/commit/49e2d2fcbcf0c85469243e6c2d9cf6237950e298

I think ask toi dev to move the new function in model. But since getUserGroupList + getSurveyUserGroupList are in common …

Steps To Reproduce

Move this 3 function ins UserGroup (Permission part ?)

TagsNo tags attached.
Bug heat0
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version
Git branch / Pull Request URLN/A

Users monitoring this issue

There are no users monitoring this issue.

Activities

There are no notes attached to this issue.

Related Changesets

LimeSurvey: master c354988e

2026-11-20 14:10

c_schmitz


Details Diff
Dev Moved the user group filtering of usercontrolSameGroupPolicy from common_helper to the UserGroup model (issue 18273)
Dev shouldFilterUserGroupList() and getUserGroupList() are kept as deprecated wrappers, getUserGroupList() now uses a query with bound parameters instead of string SQL
Affected Issues
18273
mod - application/controllers/SurveyPermissionsController.php Diff File
mod - application/controllers/SurveysGroupsPermissionController.php Diff File
mod - application/helpers/common_helper.php Diff File
mod - application/models/UserGroup.php Diff File
mod - application/models/services/SurveyPermissions.php Diff File
add - tests/unit/models/UserGroupSameGroupPolicyTest.php Diff File

Issue History

Date Modified Username Field Change
2022-07-25 19:32 DenisChenu New Issue
2026-11-19 22:50 c_schmitz Status new => acknowledged
2026-11-20 14:10 c_schmitz Assigned To => c_schmitz
2026-11-20 14:10 c_schmitz Status acknowledged => closed
2026-11-20 14:10 c_schmitz Resolution open => fixed
2026-11-20 14:11 c_schmitz Changeset attached => LimeSurvey master c354988e