View Issue Details

This issue affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
18230Bug reportspublic2024-11-19 18:15
Reporterc_schmitz Assigned Toc_schmitz  
PrioritylowSeverityblock 
Status closedResolutionfixed 
Summary18230: Question type 'Text display' shows the whole text as header h3
Description

While this makes probably sense for normal question types, it does not seem to make sense for text display question types
In that case the user should be able to format it with their choice.

Task:

Not sure - maybe implement a question attribute that would allow to omit the h3? have a customized question theme template inside skelvanilla?

Steps To Reproduce

Check a normal text question types

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version
Git branch / Pull Request URLN/A

Relationships

child of 18225 closedc_schmitz Make skel_vanilla a core theme 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2022-06-30 20:42

developer   ~70643

https://extensions.sondages.pro/themes-and-templates/skelvanilla-a11y-and-usuability/documentation.html#Decoration-options-different-for-each-question

Need Question attribute by SurveyTheme : https://bugs.limesurvey.org/view.php?id=14248
to have a clean way

DenisChenu

DenisChenu

2022-07-05 15:57

developer   ~70743

Quick fix : add skel-size-body Class to the question.

c_schmitz

c_schmitz

2022-07-07 11:55

administrator   ~70784

PLease fix it by changing the question theme to make an exception here, as we talked about

DenisChenu

DenisChenu

2022-07-07 15:06

developer   ~70790

In a fork ?

I don't understand

DenisChenu

DenisChenu

2022-07-07 16:42

developer   ~70803

Last edited: 2022-07-07 16:42

See https://demo.sondages.pro/532782?newtest=Y&lang=en#

  1. I add 2 Classes …skel-nohead and skel-head.
  2. I set question inside skel-group or skel-group-question to skel-nohead if it's possible (1)

[1] i think i already checked : but since PHP call theme one by one you can not get variable in 1st questio and get it in 2nd …

DenisChenu

DenisChenu

2022-07-07 19:21

developer   ~70805

Check : https://demo.sondages.pro/532782?newtest=Y&lang=en#

Manual : https://extensions.sondages.pro/themes-and-templates/skelvanilla-a11y-and-usuability/documentation.html?var_mode=calcul#Using-h2-or-h3-for-question

You can disable the head and the section on specific question: add skel-tagnoheader class on question Class name.

Default header size is h3 if group title are shown and h2 if not. You can force to be h2 with skel-tagH2 and h3 with skel-tagH3.

If you don’t enable global header and section : you can enable it for each question manually adding skel-tagheader to the question css classes. Bu default it’s a h2 header, you can set it to h3 with skel-tagH3. This can be used with Sub-group inside group.

OK ?

DenisChenu

DenisChenu

2022-07-07 19:22

developer   ~70806

System here : https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla/-/commit/fbb744de0b1a20eaabaf6ba35b823670d223f088

But a lot of other fix about this on other commit.

c_schmitz

c_schmitz

2022-07-11 15:23

administrator   ~70855

Looks good. Will present to the customer.

Issue History

Date Modified Username Field Change
2022-06-30 14:34 c_schmitz New Issue
2022-06-30 14:34 c_schmitz Issue generated from: 18229
2022-06-30 14:34 c_schmitz Assigned To => DenisChenu
2022-06-30 14:34 c_schmitz Status new => assigned
2022-06-30 14:34 c_schmitz Relationship added child of 18225
2022-06-30 14:35 c_schmitz Priority none => low
2022-06-30 14:38 c_schmitz Issue cloned: 18231
2022-06-30 20:42 DenisChenu Note Added: 70643
2022-06-30 20:42 DenisChenu Bug heat 0 => 2
2022-07-05 15:57 DenisChenu Note Added: 70743
2022-07-07 11:55 c_schmitz Note Added: 70784
2022-07-07 11:55 c_schmitz Bug heat 2 => 4
2022-07-07 12:01 c_schmitz Issue cloned: 18243
2022-07-07 15:06 DenisChenu Note Added: 70790
2022-07-07 16:42 DenisChenu Note Added: 70803
2022-07-07 16:42 DenisChenu Note Edited: 70803
2022-07-07 19:21 DenisChenu Note Added: 70805
2022-07-07 19:22 DenisChenu Status assigned => ready for code review
2022-07-07 19:22 DenisChenu Note Added: 70806
2022-07-07 19:22 DenisChenu Assigned To DenisChenu => c_schmitz
2022-07-11 15:23 c_schmitz Note Added: 70855
2022-07-18 10:07 c_schmitz Status ready for code review => in testing
2022-07-19 13:10 c_schmitz Status in testing => resolved
2022-07-19 13:10 c_schmitz Resolution open => fixed
2024-11-19 18:15 c_schmitz Status resolved => closed
2026-11-20 10:33 c_schmitz Category Accessibility => (No Category)