View Issue Details

This issue affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
18227Bug reportsTheme editorpublic2024-11-19 18:15
Reporterc_schmitz Assigned Toc_schmitz  
PriorityurgentSeverityblock 
Status closedResolutionfixed 
Summary18227: Brand logo image has not alt text
Description

If you are using the Bandlogo setting og the template there is no way to set an 'alt' attribute content for screenreaders

Task:
This subtask is a part of 18225

Create a template option in the attached template from 18225 ot be able to set an alt text for the brand logo file.

Steps To Reproduce

Run any survey having several pages and check.

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version
Git branch / Pull Request URLN/A

Relationships

related to 18256 closedDenisChenu Merge changes for brand logo to skellvanilla 
related to 18392 closedc_schmitz 3 times same title for screenreader ( title tag improvment) 
child of 18225 closedc_schmitz Make skel_vanilla a core theme 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2022-06-30 13:56

developer   ~70629

It's the survey name in vanilla
No ?

DenisChenu

DenisChenu

2022-06-30 13:56

developer   ~70630

(i set to alt="" in skelvanilla since title is used for h1)

DenisChenu

DenisChenu

2022-06-30 21:35

developer   ~70651

urgent ?

DenisChenu

DenisChenu

2022-07-11 12:57

developer   ~70843

With option on Powered text and Powered link
(use it as alt for all logo + use it as link for all logo)

? OK ?

DenisChenu

DenisChenu

2022-07-11 12:57

developer   ~70844

c_schmitz

c_schmitz

2022-07-11 15:14

administrator   ~70854

Last edited: 2022-07-11 15:15

Dirty hardcoded version:
Put all translations directly into the template twig file and output them dependant on the current language.
Customer needs to know here he can edit it in the twig files.

DenisChenu

DenisChenu

2022-07-11 15:33

developer   ~70858

OK,
Then close this one ?

c_schmitz

c_schmitz

2022-07-11 15:39

administrator   ~70861

Gabriel will do this.

gabrieljenik

gabrieljenik

2022-07-13 14:02

developer   ~70893

Done

image.png (14,342 bytes)   
image.png (14,342 bytes)   
image-2.png (9,193 bytes)   
image-2.png (9,193 bytes)   
DenisChenu

DenisChenu

2022-07-13 15:12

developer   ~70903

With option on Powered text and Powered link
(use it as alt for all logo + use it as link for all logo)

Can be done in skelvanilla … publicly available for all …

c_schmitz

c_schmitz

2022-07-15 15:54

administrator   ~70962

@gabrieljenik: Can you give Denis please access to the repository/commit?

gabrieljenik

gabrieljenik

2022-07-15 17:32

developer   ~70969

Done

DenisChenu

DenisChenu

2022-07-20 11:04

developer   ~71044

About multilanguage system : it must be a core solution ?

Else we can continously add hacked solution in theme and never improve LimeSurvey Plugin/theme API.

No ?

gabrieljenik

gabrieljenik

2022-07-20 14:48

developer   ~71052

About multilanguage system : it must be a core solution ?

Let's create a new ticket for that

Issue History

Date Modified Username Field Change
2022-06-30 13:53 c_schmitz New Issue
2022-06-30 13:53 c_schmitz Issue generated from: 18226
2022-06-30 13:53 c_schmitz Relationship added child of 18225
2022-06-30 13:53 c_schmitz Assigned To => DenisChenu
2022-06-30 13:53 c_schmitz Status new => assigned
2022-06-30 13:56 DenisChenu Note Added: 70629
2022-06-30 13:56 DenisChenu File Added: Capture d’écran du 2022-06-30 13-55-31.png
2022-06-30 13:56 DenisChenu Bug heat 0 => 2
2022-06-30 13:56 DenisChenu Note Added: 70630
2022-06-30 13:57 c_schmitz Issue cloned: 18228
2022-06-30 15:02 c_schmitz Priority none => urgent
2022-06-30 21:35 DenisChenu Note Added: 70651
2022-07-11 12:57 DenisChenu Note Added: 70843
2022-07-11 12:57 DenisChenu Note Added: 70844
2022-07-11 12:57 DenisChenu File Added: Capture d’écran du 2022-07-11 12-56-35.png
2022-07-11 15:14 c_schmitz Note Added: 70854
2022-07-11 15:14 c_schmitz Bug heat 2 => 4
2022-07-11 15:15 c_schmitz Note Edited: 70854
2022-07-11 15:33 DenisChenu Note Added: 70858
2022-07-11 15:39 c_schmitz Assigned To DenisChenu => gabrieljenik
2022-07-11 15:39 c_schmitz Note Added: 70861
2022-07-13 14:02 gabrieljenik Note Added: 70893
2022-07-13 14:02 gabrieljenik File Added: image.png
2022-07-13 14:02 gabrieljenik File Added: image-2.png
2022-07-13 14:02 gabrieljenik Bug heat 4 => 6
2022-07-13 14:02 gabrieljenik Assigned To gabrieljenik => c_schmitz
2022-07-13 14:02 gabrieljenik Status assigned => ready for code review
2022-07-13 15:12 DenisChenu Note Added: 70903
2022-07-14 11:22 c_schmitz Status ready for code review => resolved
2022-07-14 11:22 c_schmitz Resolution open => fixed
2022-07-15 15:54 c_schmitz Note Added: 70962
2022-07-15 15:55 c_schmitz Assigned To c_schmitz => gabrieljenik
2022-07-15 15:55 c_schmitz Status resolved => assigned
2022-07-15 17:32 gabrieljenik Note Added: 70969
2022-07-15 17:32 gabrieljenik Assigned To gabrieljenik => c_schmitz
2022-07-15 17:32 gabrieljenik Status assigned => ready for code review
2022-07-18 10:02 c_schmitz Status ready for code review => resolved
2022-07-18 10:03 c_schmitz Issue cloned: 18256
2022-07-18 10:03 c_schmitz Relationship added related to 18256
2022-07-20 11:04 DenisChenu Status resolved => feedback
2022-07-20 11:04 DenisChenu Resolution fixed => reopened
2022-07-20 11:04 DenisChenu Note Added: 71044
2022-07-20 14:48 gabrieljenik Note Added: 71052
2022-07-21 16:51 c_schmitz Status feedback => resolved
2022-07-21 16:51 c_schmitz Resolution reopened => fixed
2022-10-18 18:17 DenisChenu Relationship added related to 18392
2024-11-19 18:15 c_schmitz Status resolved => closed