View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
18104Feature requestsPluginspublic2022-05-23 20:01
Reporterollehar Assigned Toollehar  
PrioritynoneSeverityfeature 
Status assignedResolutionopen 
Summary18104: Add new plugin updater class for git repositories
Description

Title

TagsNo tags attached.
Bug heat6

Users monitoring this issue

User List ollehar

Activities

ollehar

ollehar

2022-05-14 16:53

administrator   ~69641

Ping @DenisChenu, I didn't start yet but will ping you on commits when I have something :)

ollehar

ollehar

2022-05-14 19:42

administrator   ~69642

Btw, do you want an update by a local "git pull" to a tag, or fetching a zip file?

DenisChenu

DenisChenu

2022-05-16 08:09

developer   ~69645

I think it's better to have a zip dl, no ?

PS : i need to really check how it work to create my own update server too.

ollehar

ollehar

2022-05-16 11:01

administrator   ~69650

It should be enough to check the git tags and compare with local version. So local computer would need git installed. Maybe need to be configured for both Windows and Linux.

DenisChenu

DenisChenu

2022-05-16 11:14

developer   ~69652

git tag usage ?

Let's play with skelvanilla, i do the update

ollehar

ollehar

2022-05-16 11:14

administrator   ~69653

Yes, git tag. Tag your versions on git, then git pull tags from local installation, compare with version, config.xml.

DenisChenu

DenisChenu

2022-05-16 11:31

developer   ~69663

With tag : no way to have 2 different branch ? One for 3.X, one for 5.X one for testing purpose (for example)

ollehar

ollehar

2022-05-23 10:29

administrator   ~69963

What about: The updater reads a remote JSON file instead of a git repo? The JSON can be written manually or be an API. JSON contains array of object, each object describes plugin name and latest version available.

DenisChenu

DenisChenu

2022-05-23 10:36

developer   ~69964

An xml file … config.xml for example … ;)

ollehar

ollehar

2022-05-23 10:54

administrator   ~69965

No, I don't want to read remote XML... Security issues and crap. JSON is better.

DenisChenu

DenisChenu

2022-05-23 11:33

developer   ~69979

mocking ;)

ollehar

ollehar

2022-05-23 11:48

administrator   ~69982

Boooo :D

So the updater needs two thing:

1) Link to JSON file (includes plugin name and version, and maybe new zip file location to download from)
2) Link to ZIP file to update with (can be included in the JSON file)

DenisChenu

DenisChenu

2022-05-23 12:07

developer   ~69983

:+1:

and after we can find a solution to allow parameters in ZIP file :)

Issue History

Date Modified Username Field Change
2022-05-14 16:52 ollehar New Issue
2022-05-14 16:53 ollehar Note Added: 69641
2022-05-14 16:53 ollehar Bug heat 0 => 2
2022-05-14 19:42 ollehar Note Added: 69642
2022-05-16 08:09 DenisChenu Note Added: 69645
2022-05-16 08:09 DenisChenu Bug heat 2 => 4
2022-05-16 11:01 ollehar Note Added: 69650
2022-05-16 11:14 DenisChenu Note Added: 69652
2022-05-16 11:14 ollehar Note Added: 69653
2022-05-16 11:31 DenisChenu Note Added: 69663
2022-05-23 10:29 ollehar Note Added: 69963
2022-05-23 10:36 DenisChenu Note Added: 69964
2022-05-23 10:54 ollehar Note Added: 69965
2022-05-23 11:33 DenisChenu Note Added: 69979
2022-05-23 11:48 ollehar Note Added: 69982
2022-05-23 12:07 DenisChenu Note Added: 69983
2022-05-23 20:00 ollehar Issue Monitored: ollehar
2022-05-23 20:00 ollehar Bug heat 4 => 6
2022-05-23 20:01 ollehar Assigned To => ollehar
2022-05-23 20:01 ollehar Status new => assigned