View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
17257 | Bug reports | Survey editing | public | 2021-04-19 20:04 | 2021-07-12 11:53 |
Reporter | Mazi | Assigned To | ollehar | ||
Priority | high | Severity | block | ||
Status | closed | Resolution | fixed | ||
Product Version | 4.5.x | ||||
Summary | 17257: Can't edit question code of activated survey | ||||
Description | After having activated my survey I am not able to edit the question code, the field is disabled. At LS3.x this was no problem at all and often you simply have to edit the code, even if the survey is active. | ||||
Steps To Reproduce | Activate a test survey. | ||||
Tags | No tags attached. | ||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | Version 4.5.1+210420 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Chrome | ||||
Database type & version | MySQL 5 | ||||
Server OS (if known) | Ubuntu 20 | ||||
Webserver software & version (if known) | Apache 2.0 | ||||
PHP Version | 7.3 | ||||
Wait, is this really safe? Question code is part of the response table. @Shnoulle? |
|
@ollehar, then the DB layout must have changed a lot. At LS3.x the question code never was part of the lime_survey_123456 tables. Only subquestion codes were listed there. These are disabled at LS3.x which is fine. The question codes you could always edit! |
|
No, that part is unchanged between LS3 and LS4. Response table should be in format surveyidXquestionidXgroupid. Uh, OK, maybe it's id and not code? Will check tomorrow when I'm back at work. |
|
Its allowed since years and clearly : it's NEEDED ! |
|
Else : even for subquestion code : we can not, but if we can : it's better to allow edition … |
|
Alright, everybody relax, haha. We'll fix it. |
|
Sorry for uppercase :( , really soory. I'm relaxed :) To remind : if possible : it can be great to allow edition on whole survey if it's activated. Maybe with :
:) |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31604 |
|
Pull and review, please. |
|
Release done. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2021-04-19 20:04 | Mazi | New Issue | |
2021-04-19 20:06 | ollehar | Priority | none => high |
2021-04-19 20:06 | ollehar | Severity | crash => block |
2021-04-19 20:06 | ollehar | Note Added: 64015 | |
2021-04-19 20:07 | ollehar | Note Added: 64016 | |
2021-04-19 20:12 | Mazi | Note Added: 64017 | |
2021-04-19 20:14 | ollehar | Note Added: 64018 | |
2021-04-20 06:32 | DenisChenu | Note Added: 64026 | |
2021-04-20 06:33 | DenisChenu | Note Added: 64027 | |
2021-04-20 10:16 | ollehar | Note Added: 64029 | |
2021-04-20 10:58 | DenisChenu | Note Added: 64032 | |
2021-04-20 11:35 | ollehar | Changeset attached | => LimeSurvey master eb9229e2 |
2021-04-20 11:35 | ollehar | Note Added: 64035 | |
2021-04-20 11:35 | ollehar | Assigned To | => ollehar |
2021-04-20 11:35 | ollehar | Resolution | open => fixed |
2021-04-20 11:35 | ollehar | Status | new => ready for testing |
2021-04-20 11:35 | ollehar | Note Added: 64036 | |
2021-04-22 17:19 | ollehar | Status | ready for testing => resolved |
2021-07-12 11:53 | c_schmitz | Note Added: 65320 | |
2021-07-12 11:53 | c_schmitz | Status | resolved => closed |